Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 09:01:15 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     <herbert@gondor.apana.org.au>
CC:     <linux-crypto@vger.kernel.org>, <qat-linux@intel.com>
Subject: Re: [PATCH 0/2] crypto: qat - unmap buffers before free
Message-ID: <ZIA5S8G+j1Q1x4nE@gcabiddu-mobl1.ger.corp.intel.com>
References: <20230601101000.18293-1-giovanni.cabiddu@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230601101000.18293-1-giovanni.cabiddu@intel.com>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?N9yVTIX5S9bA+obFNPPs7VBOKfmAb9trvDXXEc/wtVlxf4Ej5UV780DM9Yuu?=
 =?us-ascii?Q?TuJcZ103sQWFIgZphHqp6ybNok+fQBk7RE+3BrNZWir9/pHi7wXYZvhIIqn9?=
 =?us-ascii?Q?U0EPiRLbnbjfP/TdT3s49BQn82BEdMRiBGGb7RBk3bPqAyNl23DbB5aM4dkf?=
 =?us-ascii?Q?LHtcE2iflIit9cObfX4fE23sTc9U4wI7Ct0260ARLCFFvM7d97d08IdZ0Ksx?=
 =?us-ascii?Q?qMZxF6QueEGcde1l0ikNNdbhOUtrWWAMd7dCQlYWwGWYGaUhgnsgQ+Z8Z9ku?=
 =?us-ascii?Q?BG7FJurjeaL7W7aai5p0jugZffgs/9R1s9/zrqdUDj1+8UXJXSbYaq3Te/WP?=
 =?us-ascii?Q?2LtDjv37LpKXGFtuVu7UnVsZoehDlyJVUJ2kLLFIuyCOR45ucuusQrTPESnT?=
 =?us-ascii?Q?llGSowvelYxkACm921btF/PJNDs/5WDyGse6EXUAw45jbvTWChKWiCYogvAj?=
 =?us-ascii?Q?HPfkYHDr/fxEtdpe5vKxz3S4MUkypsMNjrskU0MxrxlAsPU9iMmbCbt1uy/2?=
 =?us-ascii?Q?r5IAXyb4JYz5tyn0vKsE6S1F77/wMpYuFbiOqHWwg940uzmva2rWfUjg6aik?=
 =?us-ascii?Q?1pU95ibIBTPT/XK/q8YKdFRXVzJBgJlBC2sJ4qtJUeR98qpzg2akGzZemyFc?=
 =?us-ascii?Q?h6JcRn8uHvMxVOxBDjk3HWJ9nb1BDUanv2w4mT8fpYdJ3M0/V7VDHa8WFz+Q?=
 =?us-ascii?Q?QqCTMiB9/0TzDdU/t+DfmA85wkaT605VzjXSxvfO9v+wdX2NzI12FiO8bN0V?=
 =?us-ascii?Q?KI3raYnUtnLmYhWndMpnWI+2XgNK2f7S+1WLJUdZH75m+4oBZ63ViLHL9NmM?=
 =?us-ascii?Q?n/F6iv8/1iXA05940ejAUHeH9cxKzd2B0UnJvNAf2skYXGJfayICaIizgev4?=
 =?us-ascii?Q?eE4+/AUBacJTbbzgjKCO7p9TeT7G5QN/SxJFoQlvCIvhce+JA8tBzVUu1sSa?=
 =?us-ascii?Q?egunxaVVQfEmlndtIOVmuKQbeBALHdC8b2y3VkyUpr515HB2hQ1X+fxBl7Nv?=
 =?us-ascii?Q?hqkwrVakRR2mahVYXEB6hyFrXyS5NFbu+e2pIzcqaPRiEQ9V+nAdyt6PZjF0?=
 =?us-ascii?Q?2Abyw0vW8PkxsVvIouNzL96NleBqq2kV/W6MMqkWFaSzC/8qXVSwIXq8bw7y?=
 =?us-ascii?Q?/46oJ3KawmJc04GsX0ynSZVrVt1g/knztNAGAlUAlMDWKcyXLjc4OCpJ3C7Y?=
 =?us-ascii?Q?KrLKZ44HWs95B7Iq65xGk5+UW41+3nuF7M3wNn44c3DKbk3tmw/yNNdOwyu5?=
 =?us-ascii?Q?kpw9rXlLG+CbSS0niN/tTufLF5b5Q8t3lkCIKdtaVD57Q3lgSJvbEfxy+BPi?=
 =?us-ascii?Q?/UND9PHWbNsz5Wj+2CX/3MLxKaGy53foWKcRT8iA62394PpJm7Qnli4ZeZQ0?=
 =?us-ascii?Q?/+He4zD5nyEQ4Ni5NndDZGn6JOwPyzMIBODtM29qBOVZ0J1I5VNqKWDI4Eet?=
 =?us-ascii?Q?gASO+yzUO2vARqUS5iZmaiOhei6M4GMqix34Fms5tOa+GEJyOsm1bYSusVj+?=
 =?us-ascii?Q?saUlLf53FwwCvQqa0HPy9tA1DJNwMszbu7xhxoZUoMvsv6t2vwlbqlWxyBjF?=
 =?us-ascii?Q?rk2H2hHtTkEOBfIpJWx1zsJBm333iARjP5Jbytc9tcbOLuH+YO4Ab3YB48JM?=
 =?us-ascii?Q?1Q=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e6e03f40-2572-421c-73ce-08db672d61af
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 08:01:21.4038
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 711CdY/+oyUjzFPHxq2q3VZ684hyYgy5vN73+EDw7NObhf8VhBdnhFH8f0SAr7mLMerMngb0cnZqFC/kgzVjAg+1thYoq5qCC5iCzOePxdg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7380
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi Herbert,

On Thu, Jun 01, 2023 at 11:09:58AM +0100, Giovanni Cabiddu wrote:
> The callbacks functions for RSA and DH free the memory allocated for the
> source and destination buffers before unmapping it.
> This sequence is not correct.
> 
> Change the cleanup sequence to unmap the buffers before freeing them.
> 
> Hareshx Sankar Raj (2):
>   crypto: qat - unmap buffer before free for DH
>   crypto: qat - unmap buffers before free for RSA
> 
>  .../crypto/intel/qat/qat_common/qat_asym_algs.c    | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
Just in case you haven't seen it. There is a RESEND for the same set with
an additional Reviewed-by tag.

Regards,

-- 
Giovanni