Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230607053940.39078-10-bagasdotme@gmail.com> <20230607053940.39078-11-bagasdotme@gmail.com>
 <CAC1cPGxD6xOLksyMHCcreFyEv5Yoo50LY=xM9BmOEP=oECoNww@mail.gmail.com>
 <CAMj1kXGnzphm5Wyz7RfZdWVxPnEihR0NGy5mFs4neQM+7EfEGQ@mail.gmail.com> <2023060850-shakable-dynamite-c4ff@gregkh>
In-Reply-To: <2023060850-shakable-dynamite-c4ff@gregkh>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Thu, 8 Jun 2023 11:07:02 +0200
Message-ID: <CAMj1kXF4eXrVcXxEpGnjRcg5KDBiEzbA_9XS0mBX_FdMPyHa1w@mail.gmail.com>
Subject: Re: [PATCH 1/8] crypto: Convert dual BSD 3-Clause/GPL 2.0 boilerplate
 to SPDX identifier
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Richard Fontana <rfontana@redhat.com>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Franziska Naepelt <franziska.naepelt@googlemail.com>,
        Linux SPDX Licenses <linux-spdx@vger.kernel.org>,
        Linux Kernel Janitors <kernel-janitors@vger.kernel.org>,
        Linux Crypto <linux-crypto@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        David Howells <dhowells@redhat.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Dan Carpenter <dan.carpenter@linaro.org>,
        Alexander Kjeldaas <astor@fast.no>,
        Herbert Valerio Riedel <hvr@hvrlab.org>,
        Kyle McMartin <kyle@debian.org>,
        "Adam J . Richter" <adam@yggdrasil.com>,
        Dr Brian Gladman <brg@gladman.me.uk>,
        Stephan Mueller <smueller@chronox.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 8 Jun 2023 at 11:05, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Jun 08, 2023 at 10:37:33AM +0200, Ard Biesheuvel wrote:
> > On Wed, 7 Jun 2023 at 16:38, Richard Fontana <rfontana@redhat.com> wrot=
e:
> > >
> > > On Wed, Jun 7, 2023 at 1:42=E2=80=AFAM Bagas Sanjaya <bagasdotme@gmai=
l.com> wrote:
> > > >
> > > > Replace license boilerplate for dual BSD-3-Clause/GPL 2.0 (only or
> > > > later) with corresponding SPDX license identifier.
> > >
> > > This is at least the fourth or fifth time (I'm losing track) where yo=
u
> > > have incorrectly assumed a particular non-GPL license text matches a
> > > particular SPDX identifier without (apparently) checking.
> > >
> >
> > What exactly does 'checking' entail here? There is no guidance in
> > Documentation/process/license-rules.rst on how to perform this
> > comparison.
> >
> > Also, checkpatch now complains about missing SPDX identifiers, which
> > is what triggered this effort. Should it stop doing that?
> >
> > > Bagas, I urge that you learn more about the nature of SPDX identifier=
s
> > > before submitting any further patches at least involving replacement
> > > of non-GPL notices with SPDX identifiers. For this unprecedented
> > > license notice replacement initiative to have any legitimacy it must
> > > attempt to apply SPDX identifiers correctly.
> > >
> >
> > Since we're in language pedantic mode: it must do more than attempt,
> > it must apply them correctly, period.
> >
> > Arguably, this is an 'attempt to apply SPDX identifiers correctly' on
> > Bagas's part, which apparently falls short (and I may be guilty of the
> > same for some arch crypto code)
> >
> > So what is the ambition here: do we just leave the ambiguous ones as-is=
?
>
> I recommend yes, leave them as-is until the legal people who actually
> care about having SPDX lines in all of the files take the time to do the
> work to resolve these issues.
>
> Remember, they are the ones asking for it, no need for us to do their
> work for them :)
>

Good point.