Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 17:07:16 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Damian Muszynski <damian.muszynski@intel.com>
Cc:     linux-crypto@vger.kernel.org, qat-linux@intel.com,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: Re: [PATCH] crypto: qat - add internal timer for qat 4xxx
Message-ID: <ZILrxDmxkHyIZ1Sw@gondor.apana.org.au>
References: <20230601091340.12626-1-damian.muszynski@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230601091340.12626-1-damian.muszynski@intel.com>
Precedence: bulk

On Thu, Jun 01, 2023 at 11:13:40AM +0200, Damian Muszynski wrote:
>
> +static void timer_handler(struct timer_list *tl)
> +{
> +	struct adf_timer *timer_ctx = from_timer(timer_ctx, tl, timer);
> +	unsigned long timeout_val = adf_get_next_timeout();
> +
> +	/* Schedule a work queue to send admin request */
> +	adf_misc_wq_queue_work(&timer_ctx->timer_bh);
> +
> +	timer_ctx->cnt++;
> +	mod_timer(tl, timeout_val);
> +}

So the timer simply schedules a work.  Could you use a delayed
work instead?

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt