Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3045255rwd; Sat, 10 Jun 2023 00:02:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7hFG6SnS8NI2ZlKPXnq9jczehSInAwAk2Sk6EI8L85ZmWLCvMY1kaXpBO8b+8Tio3N2vKq X-Received: by 2002:a05:6a21:999e:b0:117:a86:6c64 with SMTP id ve30-20020a056a21999e00b001170a866c64mr4504867pzb.2.1686380536968; Sat, 10 Jun 2023 00:02:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686380536; cv=none; d=google.com; s=arc-20160816; b=lWfFNqck5P04ttQX3UOZJqd8g7iIG3eRuJvOSiM3vdFuvtyQAat6FfqHE6EHoiW1dz kl0AbHdoqMC9Pi4+rD/v6XMJo10q0WVom8Nvmomo3QjOhcww8WUSYIevEFjSA2xWHwBN Zw5cuSV0yRfsZ3w5W6TRz7sUHNnEC6EsYFSBWknqYONtcv6NIuVLTQ9X2Qa/0vraPW+p sW7fzS5i261qX4Pqkoj02wGBuy1zEWCBc/q/XRk92BuGuXsO635Bu58Kt5EJNqWEW0ws HqdHAyX3YPQqiGfSZw4AZSQ3+7mNfFhdiQzloyYUf3aiaKsCFY1THEJ3o6dO7a0x76Iz Z88A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xnwuusMMVyJcb9Dgng1xLlHzGx2WfS2fdT7sQtKkDaY=; b=unuAHliEDAhKux+XGYG7NzJZieUXdowHJKSaCnCyXtks55upyKs3kXdsl1GcmuKVC7 qncSFwB+8TCSKEEHJTs3QNgkt8XWgBLGo18tiTLISw/02G3MG2ZN5NXgGYapM16h345j 0VpzdXC7+rjB2OjWS+Y5Q5H8fzIEmkOaV3duRLsRL0tN30EBn6DLCnszN+HkE99TH4XQ jwIVBcisI1ZjNT7B8aZ7bdDaaGcJTrMBqwtpGconQIm5Y7LjHTwNBTlaQXPKjIr2E8Sg gWLs00qtGdiU76P43QjDNijOLfzwTy1iWUbxrk/WVCnKNx1mdAK1CSgud4sK1bSQP+cR Glaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DLyNaTuB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x66-20020a626345000000b0066032c675dcsi3633871pfb.3.2023.06.10.00.01.55; Sat, 10 Jun 2023 00:02:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DLyNaTuB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229746AbjFJGvI (ORCPT + 99 others); Sat, 10 Jun 2023 02:51:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbjFJGvH (ORCPT ); Sat, 10 Jun 2023 02:51:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 107AE3C00; Fri, 9 Jun 2023 23:51:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A0B9862162; Sat, 10 Jun 2023 06:51:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92E12C433D2; Sat, 10 Jun 2023 06:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686379864; bh=9+jSZur8kKMdp4QWKKR2gLKbPRbyGHjjK9ectU9UX8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DLyNaTuBZQE7+MgYKCoxoCdQRA94X8bROaqvfbkU8gx0+NpwaPibZJk0l5oukkECv 8shxby16yQICGsI/X9KxsIYpcvuMmRmv7jmH1pproqP6uZLaxRNF6gfzkNeplAAhtY PNYR16QU+v/DdQh80N9kmwlgVWWVSsxtRb62w5TA= Date: Sat, 10 Jun 2023 08:51:02 +0200 From: Greg KH To: Xianting Tian Cc: "Michael S. Tsirkin" , arei.gonglei@huawei.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, herbert@gondor.apana.org.au, davem@davemloft.net, amit@kernel.org, arnd@arndb.de, marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Xianting Tian Subject: Re: [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs Message-ID: <2023061036-lived-earflap-26ee@gregkh> References: <20230609131817.712867-1-xianting.tian@linux.alibaba.com> <20230609131817.712867-2-xianting.tian@linux.alibaba.com> <20230609115617-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Jun 10, 2023 at 11:20:49AM +0800, Xianting Tian wrote: > > 在 2023/6/9 下午11:57, Michael S. Tsirkin 写道: > > On Fri, Jun 09, 2023 at 09:18:15PM +0800, Xianting Tian wrote: > > > From: Xianting Tian > > > > > > Cpu stall issue may happen if device is configured with multi queues > > > and large queue depth, so fix it. > > What does "may happen" imply exactly? > > was this observed? > I didn't met such issue, this patch set just a theoretical fix. Then I would not recommend adding it at this time, as you just slowed down the kernel for something that no one has reported :( thanks, greg k-h