Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 10 Jun 2023 09:41:28 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Eric Biggers <ebiggers@kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>
CC:     "meenakshi.aggarwal@nxp.com" <meenakshi.aggarwal@nxp.com>,
        "horia.geanta@nxp.com" <horia.geanta@nxp.com>,
        "V.sethi@nxp.com" <V.sethi@nxp.com>,
        "pankaj.gupta@nxp.com" <pankaj.gupta@nxp.com>,
        "gaurav.jain@nxp.com" <gaurav.jain@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "iuliana.prodan@nxp.com" <iuliana.prodan@nxp.com>,
        <lucas.segarra.fernandez@intel.com>
Subject: Re: [PATCH 0/5] Remove CRYPTO_ALG_ALLOCATES_MEMORY flag
Message-ID: <ZIQ3OKYyOcwRIOLR@gcabiddu-mobl1.ger.corp.intel.com>
References: <20230523153421.1528359-1-meenakshi.aggarwal@nxp.com>
 <20230523165503.GA864814@google.com>
 <ZHh0DF4meU2ze+g7@gondor.apana.org.au>
 <ZHh/zqNu7XzwJTl5@gcabiddu-mobl1.ger.corp.intel.com>
 <ZILvtASXQKLG43y9@gondor.apana.org.au>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZILvtASXQKLG43y9@gondor.apana.org.au>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y9CRjJj9ulbLFyZNF674i/UZyqFREiYrIadHY0Lw4bEXxz6DplQGvjAVtvfX?=
 =?us-ascii?Q?jc+8qzIFsDobuxvAFBCyLgaZq4yffUyVebY8bMYz4nSiJXlantIz1y20rGWw?=
 =?us-ascii?Q?cQCmhuvDbDZc5QfH9wU9Edf32O2GQwMzDYVoUpRJqXFQ8kNVe82cOfSslldM?=
 =?us-ascii?Q?N9ifS3NIxnlk7bYylOlZumlJRZuw3B3zGGF+f619ezdMpWo/fmvSmjcbF7rM?=
 =?us-ascii?Q?APUtKby3Z+iFiix0M80rCR8A9FMge9LMwh1rBLpF0Vjcm3fCVvjx/nsuZ/kD?=
 =?us-ascii?Q?grZdxDdpkirs73fx+NyPZDRaz1cpBz2kDRFvkkjDo6vaiFW5Idur6SimzbQG?=
 =?us-ascii?Q?eWMbNg3sdzv8tJVu8d1gzcFgo+AE4Jq6Uo3u3Wc6F9Ajen6cffjqbXxsBmxh?=
 =?us-ascii?Q?myrPzGli6+vLny7JMRhYzSUdw9f/36n3uplZ7yvFTyKRQYs9RaLR+KOA1xEl?=
 =?us-ascii?Q?Ix/E7jcWEIO+D9n19HV10XpJTy38YjBBE6a7hM/VVDUSXGGe53YiK6lf4twJ?=
 =?us-ascii?Q?vRmc+TmV811KapBJZbX+4847y9MQsziSkbLEEryiFb8Qikan977PATWb/28R?=
 =?us-ascii?Q?jbGR6IQWs0lpdW+uexie7CQsvvLyNPXr3bjnqt4C2wPwFTJTamdVSJweDLIy?=
 =?us-ascii?Q?mTWmTocuPI2KWNaqQcqnoDvwp9C3TXrymY4uQ0Mlf6LjJxG9Z2vSSGAcMund?=
 =?us-ascii?Q?uf7QJfkKuYHka/N90QsKuf534vKx1es6GFkvaJNlcsPbQDH5pVSZv/0zVcqP?=
 =?us-ascii?Q?mUdjTSn534mngqAqfod4WytchFyJhpkVhWX+lALHvhGbKqm3KEEeaHA6D+fE?=
 =?us-ascii?Q?ascC1GO5K52MU7If0XQQyGzb5z6EsQWDdarAyKW5g7dTGIk0VT8qd4Nb/ETj?=
 =?us-ascii?Q?hA2GXwunaabj6/kng3XhExZVyZR0YZ3v3LOUhZR47pzNUtN8Mwt46RAnTjxD?=
 =?us-ascii?Q?wLIL26NK+duORVC59O0ZXQ07IqyrJ22i4T8oDoKigzcy+TPBtjrDuxT8hwTS?=
 =?us-ascii?Q?MdEE6YKUEwSlG9kVe2jhzXNpSUXXBy1ZNsXcI03/I9zp5y7dZqAZs2N+rK6C?=
 =?us-ascii?Q?kLZTTk6VArTF6aPlpmoDjpBeJ1LJCofsprT8aCWgVlQPJg6/1RANCoUBkaLg?=
 =?us-ascii?Q?Ny3Oi+O20pYqu1Dmv0B/NnxPp+fABq+1exxjL4icxACuSKj2OYd0tb3zDY1O?=
 =?us-ascii?Q?5mc73JA3HnTAFr6Zd7WXO3/nGQq+bZd6fxC+w5G7G+nPgiwAaugYXnMUwBbH?=
 =?us-ascii?Q?YW9k+oQXKcIYaiiMcnjM246vEkIEgpxWk27TIP8GH7XmTp6GNahxiS2tD7WT?=
 =?us-ascii?Q?+u8rRGqgecjcmy8WJvd3dH9V6ibRDlQYSv12/UelYeD6DAH6lGrs5W1Bnuz3?=
 =?us-ascii?Q?Yb7p4bdkmR+W3DZTfxtD+xKjVe2NS7vOHmPjUvuqFszpJ73w5N9FttVWICVE?=
 =?us-ascii?Q?t8Gg8Xn0sCTEpucbbmpjnXL/TRZEFXvwa7AQGe1yLVCPdsEKiN4sOtO2evWf?=
 =?us-ascii?Q?fC2H2B8LjxlicoetZq03hkyFi7CMeFSwBIcVVSJJ/uH+qMnfx+OdhNhnDt7N?=
 =?us-ascii?Q?YvftpB/rtlMGyTaD4m9lDbNjcNNvR071pqVWKL1uPpiI5ALsTrhDZZNRjrno?=
 =?us-ascii?Q?mg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c31b9168-0127-4615-94da-08db698e8109
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2023 08:41:37.6603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qedw0mnaOsbmIBArczis3AoQR4D7ZLyFvfv7Bsy2KL2ldBQu740clQV7cQDNr9OVFEy+cisrGe5dJSdb2kUi0bIDuQqlyvJ+GGE9wTSeX+w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8192
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Fri, Jun 09, 2023 at 05:24:04PM +0800, Herbert Xu wrote:
> On Thu, Jun 01, 2023 at 12:23:58PM +0100, Giovanni Cabiddu wrote:
> > BTW, some time ago we did an assessment of the users of
> > !CRYPTO_ALG_ALLOCATES_MEMORY and we came to the conclusion that we
> > cannot just update the documentation.
> > dm-crypt uses scatterlists with at most 4 entries. dm-integrity,
> > instead, might allocate memory for scatterlists with an arbitrary number
> > of entries.
> 
> dm-integrity shouldn't be using ALLOCATES_MEMORY at all.  It's
> using GFP_KERNEL allocations right next to the crypto operations.
If you all agree, I can send a patch to remove CRYPTO_ALG_ALLOCATES_MEMORY
from dm-integrity and update the documentation in crypto.h.

> But those are some seriously big crypto operations, 16 thousand
> 4K pages in one hit?

Regards,

-- 
Giovanni