Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
To:     Eric Biggers <ebiggers@kernel.org>
CC:     Horia Geanta <horia.geanta@nxp.com>, Varun Sethi <V.Sethi@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Iuliana Prodan <iuliana.prodan@nxp.com>
Subject: RE: [PATCH v2 1/5] crypto:caam - avoid allocating memory at crypto
 request runtime for skcipher
Thread-Topic: [PATCH v2 1/5] crypto:caam - avoid allocating memory at crypto
 request runtime for skcipher
Thread-Index: AQHZmr6YL2tp4KlYrkWHE/h2xyHxZK+DTjqAgAOKPjA=
Date:   Mon, 12 Jun 2023 08:22:46 +0000
Message-ID: <DU0PR04MB95632454BBABC70B936925448E54A@DU0PR04MB9563.eurprd04.prod.outlook.com>
References: <20230523153421.1528359-1-meenakshi.aggarwal@nxp.com>
 <20230609103842.4159321-1-meenakshi.aggarwal@nxp.com>
 <20230609103842.4159321-2-meenakshi.aggarwal@nxp.com>
 <20230610021835.GB872@sol.localdomain>
In-Reply-To: <20230610021835.GB872@sol.localdomain>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RZL5M0L8AqeRGjPsQ0W9nmppwyy7K6qlkOSxt76WSzORVuIYu/GR9pv+tALz?=
 =?us-ascii?Q?nZ+Pfn3j2YVnfBMuPk+RtopawpRBuAnXSlaQimIHaTOH3RWkc3BFb17T3K6l?=
 =?us-ascii?Q?Vje5DKWOa6EEzIW9U46RAEz0cgVryJEUuWZIUce0SFLtsD3bB0DyXcTG/ZsP?=
 =?us-ascii?Q?2k33gCfUb8dyW4u1buISq9qsj9S/x5tW6zdW8jqbzFHZOxNnOvs1N7LD9Tch?=
 =?us-ascii?Q?+sMxnG9GEQQmFCwRHl1pNzwmwbB68cwTJAuP13NnmI/y7j+ZYvENYzH7MUYR?=
 =?us-ascii?Q?a3CriFxsNjdlYEw7FoB9T9Tx0DXWUb78F2xjr3DHjeTDqx1sn5Fpzw09Umzq?=
 =?us-ascii?Q?SJMKitU5c2MQi1ot6wxqDpYr3/CqZx9Ad4lkBoIHIPcxlmDhEyCl24N2JTds?=
 =?us-ascii?Q?U8UbiHImpC4qCh7v0r3N5riP4J5Yn01Sp/nycnpOWH2D8wNZ9rjucojHpmqK?=
 =?us-ascii?Q?JXq70eOIMdwQfdqWCMkJi15v/bjWLgIfs7qlYIYftUm3+Jp3IHVyzu80Pjn7?=
 =?us-ascii?Q?0FrF6lBz3o7Lz1icKLC2mM6+F07bq3XZT6YGvemB0J5TCnLD6QwM5Te7wqGu?=
 =?us-ascii?Q?k+Lgmj4XZvGpVPgQIFwTbmkVAHLmDJD4VRYiHE4a76w22s/UySlHZvuAmq7q?=
 =?us-ascii?Q?yelT6rLi5fHGv4zpvub9l1huQX77Z/lQGmdmq/z58RBCEHhoEqx4Hw/eGBru?=
 =?us-ascii?Q?YjAtBimYdtMWD36mHVBQlLfHvlAhDHYYwxqBWoml2lcJHf/6oP5hU9ffuyCk?=
 =?us-ascii?Q?kMOUPQVwxc7ufFS3+/X4LdsNaEITj9rDYACKvHIKP2Y0THYlBkkRuKjjGc7m?=
 =?us-ascii?Q?KSjfmMHCfJFTiUAknAhjO4z/lrlOCU+u8rQYM9qv/DP6mNrohd5JIlJ33zfn?=
 =?us-ascii?Q?eRyg9CnAIv50sYa5rcDKO5WTG7bLJmIJx0jmrONpEl+QTDC8+SIu/Wv4y9l0?=
 =?us-ascii?Q?QZ7YjMbJ8zQaYJFxAfdUNEbccuWS00+54zrxN3+MrF6/v0M2PmVP95HJUix2?=
 =?us-ascii?Q?EDZAzq+xKupIOTlmTFAadf565JAkieG2TSpu4BH4HqgrFn7o75VYtXxR0tmV?=
 =?us-ascii?Q?ALxW8uwsBnOrih353nR/5FNKeS1GVekidLKAG02QhU9DqWD4QnGucmZWVoq6?=
 =?us-ascii?Q?mJ7CvW6M/SeZguClaUsHTTteAceYQuU2I68F5eBd4ZennNMiiU90qgWI5AWD?=
 =?us-ascii?Q?jnuiSoP3sf5RUBKuH37lHinKMpHhN5koxXNOsmf1vPVHpjTCn37d6fe9HoZU?=
 =?us-ascii?Q?Gf6ABXOniTCCucki6FI/5pAgzYb36hCN59UJvJmbiQlPf4unJefjvDnqPkkm?=
 =?us-ascii?Q?jHOIQBySLt3/yajY3OpjnbkPlyJSBGQKtMcUYYyxOWVq7Pqa5WgvEP+6VNmR?=
 =?us-ascii?Q?D6QpvqZfHYcOWIQTZsme4+lj+M9mKWWMGDilRhvG120W0U8ovCUB20Iw8SkA?=
 =?us-ascii?Q?ptjyh6KLvjhw023JUnMCyDCpzl40r/cRHgHfjn3R3ZwQVocNdd1+ImrOPGP0?=
 =?us-ascii?Q?cBSDHa3MTPLlHxUq6jC1BAkYC5Rrl1siOMwdFuOF568ijAz+20XXcYM9c++k?=
 =?us-ascii?Q?tKalDQnxpm8eXSX62r799dBFmlaYjRtlFWvGnw4r?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9563.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc33f372-2baf-4832-62f3-08db6b1e33d1
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2023 08:22:46.5407
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qovH7UC3DUhkqzMijpmxa8ZbaxvB+IHguqoniz/bnT6KaAuU1Twm2W2mwwofxZQFEEsQ/dJjfrqe/3MmIVNw8dFaNXmw1Wh+hgliYaqDplg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7595
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi Eric,


Because of CRYPTO_ALG_ALLOCATES_MEMORY flag, caam algorithms are currently =
been skipped by dm-crypt, and we want to enable dm-crypt caam offload suppo=
rt.
As per earlier discussions, we are pre-allocating memory for 4 S/G entries =
and, if needed, extra memory will be allocated at runtime.

I suggest, we should update the documentation of CRYPTO_ALG_ALLOCATES_MEMOR=
Y with above information.

Thanks,
Meenakshi

> -----Original Message-----
> From: Eric Biggers <ebiggers@kernel.org>
> Sent: Saturday, June 10, 2023 7:49 AM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Horia Geanta <horia.geanta@nxp.com>; Varun Sethi <V.Sethi@nxp.com>;
> Pankaj Gupta <pankaj.gupta@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>;
> herbert@gondor.apana.org.au; davem@davemloft.net; linux-
> crypto@vger.kernel.org; linux-kernel@vger.kernel.org; Iuliana Prodan
> <iuliana.prodan@nxp.com>
> Subject: Re: [PATCH v2 1/5] crypto:caam - avoid allocating memory at cryp=
to
> request runtime for skcipher
>
> On Fri, Jun 09, 2023 at 12:38:38PM +0200, meenakshi.aggarwal@nxp.com
> wrote:
> > If the driver needs more than the 4 entries maximum, the memory is
> > dynamically allocated, at runtime.
>
> Again, this is not currently allowed.  Please see my comment on v1:
> https://lore.kern/
> el.org%2Flinux-
> crypto%2F20230523165503.GA864814%40google.com&data=3D05%7C01%7Cmee
> nakshi.aggarwal%40nxp.com%7Cfb75f9f6a37346e27eef08db695903a2%7C686
> ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638219603267394331%7CUn
> known%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1
> haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DENoae4C6pFeMAIn%2B
> GVDqK%2F3PfwiqM0HEvFjjGMUepeo%3D&reserved=3D0
>
> - Eric