Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 20:22:58 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Damian Muszynski <damian.muszynski@intel.com>
Cc:     linux-crypto@vger.kernel.org, qat-linux@intel.com,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: Re: [PATCH] crypto: qat - add internal timer for qat 4xxx
Message-ID: <ZIxUIjwZMHrZiDg6@gondor.apana.org.au>
References: <20230601091340.12626-1-damian.muszynski@intel.com>
 <ZILrxDmxkHyIZ1Sw@gondor.apana.org.au>
 <ZIMVSDWXOcS6/Whg@dmuszyns-mobl.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZIMVSDWXOcS6/Whg@dmuszyns-mobl.ger.corp.intel.com>
Precedence: bulk

On Fri, Jun 09, 2023 at 02:04:24PM +0200, Damian Muszynski wrote:
>
> We considered the usage of delayed work when implementing this, but it will 
> break functionality. Apart from scheduling the work queue, timer_handler() is 
> incrementing a counter which keeps track of how many times the timer was scheduled.

Please be more specific.  I don't understand why the counter can't
be incremented in the delayed work instead of the timer.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt