Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2577185rwd; Fri, 16 Jun 2023 05:43:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7P01VE0tZTFiWfFuW6NBOFNBxdJ3hZnrJAgG3Md8DhGHKQnPCAf8nGFtSNhJvwICg1htIq X-Received: by 2002:a05:6a21:6da8:b0:110:c8f:b581 with SMTP id wl40-20020a056a216da800b001100c8fb581mr2991530pzb.2.1686919413478; Fri, 16 Jun 2023 05:43:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686919413; cv=none; d=google.com; s=arc-20160816; b=qF0NcJj1dBe3TxjFw1TaYhvOBESVjH8OeEDnFF1IWoKTO+ldxY6RQsQh79hlWfhKPc guQQzpEMoEysOVwyGM9kiEhALUPL0cJtTq2FN3UP+LUphnIEshWzyF6VQNFcq4JcKSYm Fyhlb2SQ06i9AXqzSkhejpSxH2i7BCnTp52aj1w7BgoOl6l0yyCCU2QXCwOgLGb9MTOj VSUWraHUUF5th/6y8rg8QO+mJEJ90OKt8SFs/kqi+lYf9rS6mCSFlVuXbETdKj7Oeofm 54czYTKXqdlViEY8iXvyv0uYwCrt/c9CQG9mLRq0+et9UBx5C2lZ+zGqd1XZcHnJDufE fTsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=vYzfGSMA5Q7f9ZaQiwYMbWXxRDqpl0Xz6nRQkme3DsQ=; b=igYfWf7+5PQCNaxFMOXY6FEnKNNWlAbXhurzue0iuOpWGUOc0w04RJ+ae8M8rpELH0 S/V9b/UjvDitTo7O/b3pqqJXvEcfaKpnjJtlTZJLvSsfCIJ/KZaD/ecf0k6dj0z7SE8S lN6PBp3dOIEebQXpUdPWW2CT0KuQmbj7jwCeh1N52xVS4tHE7zw47dgc6KWZ82czVFPy YQICORi3gDoS2FDQPq6MU/0E2OtFaF5cMg2fpHdNsgia+HA/2p4Ex0o4T/9QmS0guwKu YiWdQGeBJXiEQHUg0Hr3DGv/xKz5JLX8m+ttAYTio+uEo+YN7jayhUq8Jj6D/S0czwWu PtPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e12-20020a63db0c000000b005533895d37dsi2279605pgg.272.2023.06.16.05.43.20; Fri, 16 Jun 2023 05:43:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbjFPMdA (ORCPT + 99 others); Fri, 16 Jun 2023 08:33:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbjFPMc7 (ORCPT ); Fri, 16 Jun 2023 08:32:59 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F03C268A for ; Fri, 16 Jun 2023 05:32:58 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qA8dJ-003ouA-AA; Fri, 16 Jun 2023 20:32:54 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 16 Jun 2023 20:32:53 +0800 Date: Fri, 16 Jun 2023 20:32:53 +0800 From: Herbert Xu To: Giovanni Cabiddu Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com Subject: Re: [RESEND 0/2] crypto: qat - unmap buffers before free Message-ID: References: <20230605210607.7185-1-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230605210607.7185-1-giovanni.cabiddu@intel.com> X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_00,HELO_DYNAMIC_IPADDR2, PDS_RDNS_DYNAMIC_FP,RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS,TVD_RCVD_IP, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Jun 05, 2023 at 10:06:05PM +0100, Giovanni Cabiddu wrote: > The callbacks functions for RSA and DH free the memory allocated for the > source and destination buffers before unmapping it. > This sequence is not correct. > > Change the cleanup sequence to unmap the buffers before freeing them. > > Resending adding Reviewed-by Andy got from an internal review. > > Hareshx Sankar Raj (2): > crypto: qat - unmap buffer before free for DH > crypto: qat - unmap buffers before free for RSA > > .../crypto/intel/qat/qat_common/qat_asym_algs.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > -- > 2.40.1 All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt