Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 15:51:03 +0200
From:   Damian Muszynski <damian.muszynski@intel.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     <linux-crypto@vger.kernel.org>, <qat-linux@intel.com>,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: Re: [PATCH] crypto: qat - add internal timer for qat 4xxx
Message-ID: <ZIxox6SL8r8aNuH6@dmuszyns-mobl.ger.corp.intel.com>
References: <20230601091340.12626-1-damian.muszynski@intel.com>
 <ZILrxDmxkHyIZ1Sw@gondor.apana.org.au>
 <ZIMVSDWXOcS6/Whg@dmuszyns-mobl.ger.corp.intel.com>
 <ZIxUIjwZMHrZiDg6@gondor.apana.org.au>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZIxUIjwZMHrZiDg6@gondor.apana.org.au>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173,
 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QX7yeQOBuV4Y5kFNrqg7Hwtv7fSB/NOYJhFwOM/fqWa7TA3VhjfjHn6zztOK?=
 =?us-ascii?Q?BbMEKt2Q6nH+qv2njwpZooQRCLmZ/83HqLHRZEfrRXFUsuZyzTDpcxHxEgr/?=
 =?us-ascii?Q?xI+BZ2KyBiVDUlqJllmFKEay23EjJlJmMZN30BLBF5mOnvIOXzK40ApB/szM?=
 =?us-ascii?Q?XhwNaa1a4CJAUzli1OsddY+NNSs67OLSpQ+/zFObDzFvbkfo5jRP2aAfQNZc?=
 =?us-ascii?Q?NzCSmbaCtz7Z3Dt6pohec00NZZv13dhjmkcN1z7e9TFPewP6EoKCvo8iZqtr?=
 =?us-ascii?Q?OXF8+nWuYPGGAmPMJWWI2Kx1OmobQrdLAnp+Nr2exs8AYmKo60hTliJn++z7?=
 =?us-ascii?Q?gUZEcYQwdHIWQlW1B4+9d2l6bKaMdFoKCCHc2cDDY8CZGhIXEB+kv3T9eQc+?=
 =?us-ascii?Q?nQUhxEUidP8ZtiWN3qsDHRzlsm454gGNbGzMk1oppe4eGmOsh8GbMyHSN2ul?=
 =?us-ascii?Q?OnIcsdCOGddsVJi8bSwIM54/25KlVrrtZBYozLNTrAu6uGpxlCQaEfSSBgUz?=
 =?us-ascii?Q?gnG5wZbYkY65vR7BnbXRAMKUJyf5Iifu0fDvMbfLCVgoNKxwCIgwIyk04aNl?=
 =?us-ascii?Q?MbfjsFeyfJFmUDnKoEhQ68bCSP5FVEXaumVQbwYMkPUp6NVAkyVAdmyvXF98?=
 =?us-ascii?Q?73WqrT+3W35odcFD+4s2lBFUpu6K3OAA3upV59338Imf0ZdiwYCRVCAZcsh1?=
 =?us-ascii?Q?pps+vNZn5BLCnipuoT5pxdJ3PXNysaBHphEs8Pso+faGTXw4ygo/pnvMvkXd?=
 =?us-ascii?Q?Aa9S4I7Nlx5BMw31kh4YWm4RzqKt9YOKHdlhgQAt1IlrX4wNfIZQTNnaEm9J?=
 =?us-ascii?Q?A3C6oYyRkKwAIIzngVx+iCOWmVVLPl2mXHQ53IP/E1sw5DD/vuyaUirAc2TP?=
 =?us-ascii?Q?+siZG5luQ8pMgZwWu4ihliRZAtsO9JjCgQ3pHl6howe7ELlfIyd5mVq0QTvF?=
 =?us-ascii?Q?RmlZ1v5CwoOsxCo/jJ4ISf8AmCWu7DS8001aC4PPQep8jC4ynnzJOnh8tHtP?=
 =?us-ascii?Q?AH8hbg1NjkvxUoxBWEyx4WRnr9ROJ2ToCNh/cAAenG0PFOTHdyhRHQLE2MfZ?=
 =?us-ascii?Q?IRH/xdHpfcL+SkN1io1nkvb3G0WKgv0ut87eLLFIauCA2I/bPEin/VqpG4pV?=
 =?us-ascii?Q?DbvxdZJEdiY5amoHRruN4XjJ5kUnPVrMmnctWNxGGJwdvAg7AGjzz0iE/Vd0?=
 =?us-ascii?Q?WH6H7BQS6O/kuQiDl4USdYm8/goW3DcMYH95tdBaAe0StVmdqgTWZtTmVOnf?=
 =?us-ascii?Q?CvSuLowRKUL4pdyof0SY+7l6aKsiDCnrumMvcjcI/qIZ+19Ug8Xm66nTwSAx?=
 =?us-ascii?Q?2KlHkvhmVoIg6/vFcuushbck2Mt9dXPpeEr6KAVztF5GMJ7Hq8Bf9VZkvyj9?=
 =?us-ascii?Q?KqpaGzc03v0rMbJKFu79IwjpzdZia+wQgyaUgiPVWBuUIEXPGaRJYImcQ7Ti?=
 =?us-ascii?Q?yeJKD9gj1tVO/+SW8s3ND+ZSD57NOQELABvWGA4O6rTRLPPHrO/2eGydLU8h?=
 =?us-ascii?Q?bHQwpm9iQfeBfzEuk9GeiLlotkOaLWuLbcaN7I9hENHd+7HvdLHNc2qDnpmu?=
 =?us-ascii?Q?aStjEFJf6uYuemaSNAIrovJ8P6FtRmvEMQ0K5NK3V/S8PSO53/FaDbsZUwfh?=
 =?us-ascii?Q?aw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f848c21-20f7-4f8d-e637-08db6e70c132
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 13:51:16.3056
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3b9a2mKjS18ohdJufqJrYL53ulcBrt3HBsIeItwiiKIA4mC4WFHK865bP8roVgBrjTDHNQW9Eyq0MunDUldqc67VxG1IuiQtZV9XwNyzfoQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7473
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 2023-06-16 at 20:22:58 +0800, Herbert Xu wrote:
> On Fri, Jun 09, 2023 at 02:04:24PM +0200, Damian Muszynski wrote:
> >
> > We considered the usage of delayed work when implementing this, but it will 
> > break functionality. Apart from scheduling the work queue, timer_handler() is 
> > incrementing a counter which keeps track of how many times the timer was scheduled.
> 
> Please be more specific.  I don't understand why the counter can't
> be incremented in the delayed work instead of the timer.
> 

We have chosen the timer instead of delayed work because it gives us more 
accuracy in incrementing this counter. The value of this counter is used by 
firmware to track the time so it requires that.

---
Best Regards,
Damian Muszynski