Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Jun 2023 15:46:12 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Damian Muszynski <damian.muszynski@intel.com>
CC:     <herbert@gondor.apana.org.au>, <linux-crypto@vger.kernel.org>,
        <qat-linux@intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 0/4] crypto: qat - add heartbeat feature
Message-ID: <ZJBqNHXy1PmKpiNz@gcabiddu-mobl1.ger.corp.intel.com>
References: <20230615090437.436796-1-damian.muszynski@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230615090437.436796-1-damian.muszynski@intel.com>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qTuQh8MhAXi93UOyX1L3JIbKmvfv4VpB9k5C7SYSiZ2fcQX6yPkeaP2etWVG?=
 =?us-ascii?Q?pSKKEcr2HVe5FD3oqKc087eSHTBUGSbGRWDY1NfVTWnjQbGBEX1n2HKQJzvi?=
 =?us-ascii?Q?+cElFHiBJydmM1pqxw4KbdGw4zhyBvi0K7xSst+05bjY7TP5W0sUMgmw0O/l?=
 =?us-ascii?Q?4ftIfcFgs1RXjWXHFMWU0jlptJq0K8guak19VcGnaNXmDbNTnFZgLMURRLtG?=
 =?us-ascii?Q?cXleYYseHnQxoNkjXLVAnjH0K4+/wDgu80AKnCRxB5MbLQfYeI4Gc6GHHlrt?=
 =?us-ascii?Q?nkt1mn0tMyrhVbMxcMWsxWlX93aPWE4/QlG/LovU1HBhf/i1wVb+ZuJd9gyZ?=
 =?us-ascii?Q?c0B2TreQ6jE4+g6mnG3XzNNpIsxKSm7Dt/T8rY6tu4oumSQHgcCLcZ0h+Jg3?=
 =?us-ascii?Q?9PTL2tx34Xs/7U+lbQZhqYppveKjxg6mhkKesdV6P4MGNZEss8WiEDs67f3t?=
 =?us-ascii?Q?xXm8TmsTm0vskkv6WNKRqjB500kvvktTMTxlxO53yFGEbN09tHt5CwKb/VH7?=
 =?us-ascii?Q?c2uInvMv8tjFwC6AhJJe8jJiD9vAZVhw0y1FXuJqgsRfuVe/+I3FxwMGStWx?=
 =?us-ascii?Q?aL/4StlvShwVt8zhESDTcSmdiRfalEQovrXgQwCdYxFJiBo5jC4BqKP1kOmz?=
 =?us-ascii?Q?5T0XHQ5qGg3FBY+OJrVDvd56c8M8Rj2WVr1EkKGRHx/+Umej3HsdGYuWSJNS?=
 =?us-ascii?Q?sJsRJfY08ui99pgZya5TxWj7gvwnxdmKIuKyhSHPGKz+hU/SwBeBA1hIXjt7?=
 =?us-ascii?Q?Q6qcwvJUWpJXEkQFRk2MDk8ofmqOm6hb69525Zn5UmaHVvCmr7ivOmYK/9zB?=
 =?us-ascii?Q?1XMeUWp6kfRRrHmt8z3dvVugkSpTIuoNd1aLisaiF/AMz7TeEFYlng/xoNvg?=
 =?us-ascii?Q?Ib+YNaMB3YnBkD0A9iaRTHKan3blZfLH9BE5jX0oARnfnYAEbQrVjGJ2WrzO?=
 =?us-ascii?Q?j78lLYe8nmjkTsD051URl3JLdZOVEseLwPn58oKMFU0DMzsIH8WHxTnmcIq3?=
 =?us-ascii?Q?WM3HIKeTWB/Cy0bXJ2bTy6uiq9o6vzhFyXhuAGMtsG7ui5kACyylsMxe/by+?=
 =?us-ascii?Q?w35Yzdepm207BDwPrG6/atEAnvxpSIthmTUvExrpMOv9t1E3jW6rgdlwxtmB?=
 =?us-ascii?Q?xljyLuwFPaOgzK055HLN7ei2IFq/jUnXJGnHxOT8I8miI8rE7J3kaFYJVgFT?=
 =?us-ascii?Q?sxNSsyjtH7rCpUDaHJ74tAeqTFZlQoWQkXedjk47qcYInvoOspYDlBfz20Di?=
 =?us-ascii?Q?5cq3Vch7sP4xy/M0f+iAcBDrqkn1z/Af7r2w2uGiB12IoLxoRZqyGutFIXys?=
 =?us-ascii?Q?hn4WTpFKvLsmj4PczpNhGdopFvjYpRtz6SygN0hxw0NS412pp0U5aDvw0U4q?=
 =?us-ascii?Q?U6KmNK2v5vXfU8pmI6b+may6wseKvtNPMY8pPznTdq+6Ad9l9QdFDIfcxg3J?=
 =?us-ascii?Q?f0PxN22cHn1a45OD0BZB3dgvcRGZi3dMvLyJsIesuGFefRVMFdPDzpU1cebk?=
 =?us-ascii?Q?Yla49jVK+Hgdq2JKwRrSy9qW7yeZA/vcerDBV5EzP/RQ2sKuEcVELDR1WWrC?=
 =?us-ascii?Q?XK0temOMM7b1uV0hza8tjOTuTy8DXgtzBDkIP14P4ATivNEtfN5RuxbZ6vVo?=
 =?us-ascii?Q?dQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7175bb63-d5ef-4f38-7193-08db70d3f15d
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 14:46:19.5829
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N415NwA2L/W1In1pOMLLKvZfymKv4sCTGWqliIP7Vni+3P1eFLYYsJSAokvg5YJY+Y8O6JMpAR7kxTS5dXfVCWkHq+LJ4/eADXoypMsVCOw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6345
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi Herbert,

On Thu, Jun 15, 2023 at 11:04:33AM +0200, Damian Muszynski wrote:
> This set introduces support for the QAT heartbeat feature. It allows
> detection whenever device firmware or acceleration unit will hang.
> We're adding this feature to allow our clients having a tool with
> they could verify if all of the Quick Assist hardware resources are
> healthy and operational.
> 
> QAT device firmware periodically writes counters to a specified physical
> memory location. A pair of counters per thread is incremented at
> the start and end of the main processing loop within the firmware.
> Checking for Heartbeat consists of checking the validity of the pair
> of counter values for each thread. Stagnant counters indicate
> a firmware hang.
> 
> The first patch removes historical and never used HB definitions.
> Patch no. 2 is implementing the hardware clock frequency measuring
> interface.
> The third introduces the main heartbeat implementation with the debugfs
> interface.
> The last patch implements an algorithm that allows the code to detect
> which version of heartbeat API is used at the currently loaded firmware.
> 
> Signed-off-by: Damian Muszynski <damian.muszynski@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This set introduces a build failure with clang.
Ignore it. We are going to send a new version.

>> ld.lld: error: undefined symbol: __aeabi_ldivmod
>>> referenced by adf_clock.c:29
>>> (drivers/crypto/intel/qat/qat_common/adf_clock.c:29)
>>>               drivers/crypto/intel/qat/qat_common/adf_clock.o:(adf_clock_get_current_time)
>>>               in archive vmlinux.a
>>> referenced by adf_clock.c:24
>> (drivers/crypto/intel/qat/qat_common/adf_clock.c:24)

Regards,

-- 
Giovanni