Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Jun 2023 17:09:39 +0200
From:   Damian Muszynski <damian.muszynski@intel.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     <linux-crypto@vger.kernel.org>, <qat-linux@intel.com>,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: Re: [PATCH] crypto: qat - add internal timer for qat 4xxx
Message-ID: <ZJHBM1RZb3eXv/UO@dmuszyns-mobl.ger.corp.intel.com>
References: <20230601091340.12626-1-damian.muszynski@intel.com>
 <ZILrxDmxkHyIZ1Sw@gondor.apana.org.au>
 <ZIMVSDWXOcS6/Whg@dmuszyns-mobl.ger.corp.intel.com>
 <ZIxUIjwZMHrZiDg6@gondor.apana.org.au>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZIxUIjwZMHrZiDg6@gondor.apana.org.au>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173,
 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IXFeFo7L3yOj9ybwMLY2+gWRwVGwVINFIaq3rLA/NSS7jrNNMy8ykMaKaf1F?=
 =?us-ascii?Q?VEsQwx87o9DSRvwbU3tzY7WBwHLTVmNmGfEAQF/m0Bw6XsXYlT9IGpD42lqz?=
 =?us-ascii?Q?pAzA3retxLuMvfWCZ9ZJDSJTN+YqOzgF/tRfc+eSOU5GCe+xwR/+HxpJj+09?=
 =?us-ascii?Q?/vgjG+Qhu5tMgCu29HQtsqIfoo2stze4lU1slgnb5ZdiEKuPtuWkq4Jt9idw?=
 =?us-ascii?Q?JVJ2A9K+ibGYk/dg26UlCtCf2vFZw6Pqz7D6/AYfaquyOYN5COCUj4/fbhTv?=
 =?us-ascii?Q?TZg5h3fDFRca3gqIXGzvPPGXbVhLssA04AgvWBvmwko/KYRonMN673qyDnYn?=
 =?us-ascii?Q?2T5uylZ6DnnJnY+8UkukuW2Xzuh+OdfZ/UYIGtlfLCsRWjrDQhRypa0LTxqc?=
 =?us-ascii?Q?Lr9BP4HrYs05sncFNUcjpWiUmW3/u5qzz4OIXkY6mRiMTRwOA1Idl2QSGGuf?=
 =?us-ascii?Q?qDRvh/xcFkxg6MKXXxNL7Nrdak0X0CO2h+fu1jEvNVYfVA0LgTbf7i4bMF7n?=
 =?us-ascii?Q?oxQqI/QlydBRYhYFEWs3Nd+rp43P5MyLXP2nneP2YSUgXH32QP322e6lxqWS?=
 =?us-ascii?Q?/OZl9iDo92TLFiiQS9UhCNvuNwHkB2/k7Xz1lByirVWaH46H9M3BoFeABM8c?=
 =?us-ascii?Q?TAtTsQgVaQHWojhXyFPeIE5yyZE3z1e7oxMjt7AgUw9LCnB8Ad/PdVlaKX9l?=
 =?us-ascii?Q?z7AJkP405RLmafXTF0S9x2LIfVdWji2BoFf4mjE9mhVcJwKWKtlsNPMG7fVu?=
 =?us-ascii?Q?77vjil9IBvOfPUyD7N7EnxQ2zhDIm0xWST0qQf7SQKPQmbgZZWyIqf3NsBFk?=
 =?us-ascii?Q?07CFnMcphw02YPp8wMhYBTYl6p0E8FHXot5lZzg7yYyTPAl0Mrh3OrSDelk2?=
 =?us-ascii?Q?xqAIQqIQpsiZzzizQVTQ7ma4T+AjLxdgvg0fh6mQEkq2PyL6+3DeAlHxBDXe?=
 =?us-ascii?Q?MhpwzHVUAOloBoMcKfVj8u3pVHAYBRgDe6uHTwC9ZaukItC5tc08LgM6HxBz?=
 =?us-ascii?Q?maol2NxMGKhhyts6rX9Iz1PCRcJM7KEpZySwQiL6+tOlmOAX16YdX12GPDrA?=
 =?us-ascii?Q?SI/+ZHhiKRZhCjybShomc7yObkQiHDixrPBStocXfQA3kTv5kmvm86Z+de19?=
 =?us-ascii?Q?c7zdO8+KaimbC9d73LTXNbBR7TI1deG3p8usnf9o8oXPjkQNBQPdmv30qXeE?=
 =?us-ascii?Q?C7HsOdb26UzS1Ffc2nAhXwSv0AJxAtHUMUD0hgPtQaodEIGpY22MR1z+vHpb?=
 =?us-ascii?Q?eBl4JNbOF3CILd6EJGLMifca4eB9Ij3nnE9ctdPghOKjN5U2AodmdnmWu8Jr?=
 =?us-ascii?Q?i/pRKvWr4H9cBr1WceZflqIbuTyc1n6nlU2gvPdFQpV8EXYskQjuHfg4SGZI?=
 =?us-ascii?Q?gcwVHCa+HDG9twC44swJ1DUN15oIXlcXMpTzPzdNw5mXLXzS1XJYkkMqI3nD?=
 =?us-ascii?Q?D/s+10GN4j0mrx4jmbgKvphD96KLVsrJx7vZBpWjYz1jbNT55qYyoKZQdfWn?=
 =?us-ascii?Q?5D1CDLYjxkxm773H4n4i75vmI6KUfLnFI2CAKeCxhi/duWquyru4C1gM1eOZ?=
 =?us-ascii?Q?fydErltIjwleXsGvPIs/Us+TIgavn+1QF6HlkgpP2QVBmtTE15EiBN0Hluvs?=
 =?us-ascii?Q?mA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: af335740-5668-4a34-f8fc-08db71a06599
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 15:09:52.0370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9CHQ+FKKpZNxy/ssonkEVUfeqHQPBnXYQSMyCL95FuBuGPOKkfdau0QrC+P43OcmEE+DNNgxJ5fqtcXDmHUMGKOdI/aQiL9xovoO3IzSQ+0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6459
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 2023-06-16 at 20:22:58 +0800, Herbert Xu wrote:
> On Fri, Jun 09, 2023 at 02:04:24PM +0200, Damian Muszynski wrote:
> >
> > We considered the usage of delayed work when implementing this, but it will 
> > break functionality. Apart from scheduling the work queue, timer_handler() is 
> > incrementing a counter which keeps track of how many times the timer was scheduled.
> 
> Please be more specific.  I don't understand why the counter can't
> be incremented in the delayed work instead of the timer.
> 

We found a solution with which we can be sure about accuracy and replace 
the timer with delayed work as you suggested. An reworked patch is included 
with a new version of the heartbeat patchset as the feature development is now 
finished and this patch is a prerequisite for it. 

Best Regards,
Damian Muszynski