Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <89143a15-6368-0de3-5d76-a942fe877583@linaro.org>
Date:   Wed, 21 Jun 2023 08:40:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230609140745.65046-1-krzysztof.kozlowski@linaro.org>
 <20230609225442.GA2588193-robh@kernel.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230609225442.GA2588193-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/06/2023 00:54, Rob Herring wrote:
> On Fri, Jun 09, 2023 at 04:07:45PM +0200, Krzysztof Kozlowski wrote:
>> Cleanup bindings dropping unneeded quotes. Once all these are fixed,
>> checking for this can be enabled in yamllint.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  .../devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml         | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> You missed $id and $schema values.
> 
> Within drivers/crypto, there's also:
> 
> diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bi
> ndings/crypto/amlogic,gxl-crypto.yaml
> index ecf98a9e72b2..948e11ebe4ee 100644
> --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
> +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
> @@ -19,8 +19,8 @@ properties:
>  
>    interrupts:
>      items:
> -      - description: "Interrupt for flow 0"
> -      - description: "Interrupt for flow 1"
> +      - description: Interrupt for flow 0
> +      - description: Interrupt for flow 1
>  
>    clocks:
>      maxItems: 1
> 
> Can you add this in here. No reason to split this up more that 1 patch 
> per subsystem really. 

I'll add it. I am also fine for you to squash it or take your scripted
changes/commit if you have it ready.

Best regards,
Krzysztof