Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Abel Vesa <abel.vesa@linaro.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Biggers <ebiggers@kernel.org>, linux-mmc@vger.kernel.org,
        devicetree@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-scsi@vger.kernel.org
Subject: Re: [PATCH v7 1/3] dt-bindings: ufs: qcom: Add ICE phandle
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1ilbgqoq6.fsf@ca-mkp.ca.oracle.com>
References: <20230408214041.533749-1-abel.vesa@linaro.org>
        <20230408214041.533749-2-abel.vesa@linaro.org>
        <4aadaf24-11f6-5cc1-4fbd-addbef4f891b@linaro.org>
Date:   Wed, 21 Jun 2023 21:19:32 -0400
In-Reply-To: <4aadaf24-11f6-5cc1-4fbd-addbef4f891b@linaro.org> (Krzysztof
        Kozlowski's message of "Sun, 18 Jun 2023 10:53:50 +0200")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l1lW9fpCebjJRoj32+vVl83iQl03x9xYwP01t4uFLLZbeBsfBCIdNPYElaSD?=
 =?us-ascii?Q?QQBiRfa1sVi4WCRweMmIeecBhrICkkZ5vkzsw5/k185sirHIw1PdRCJpz/Ql?=
 =?us-ascii?Q?G4U29xgXhQB3KE54tXyk3Fkr7w37I0hs/HV0L49lTrLIwoii513ofJ5WENq8?=
 =?us-ascii?Q?Hhiv/fJq1t/DetB+r8myazSc/K8e9mflNQgDopkZi9sJL9uW29iyB1euDrKt?=
 =?us-ascii?Q?7uKUa+nRQGLrSZjn7XJvW+GZom870JuLELFfvMRHdXzZCUDU6sjutwjnwvsa?=
 =?us-ascii?Q?K/Ettlg3thl0UAwiC6xaQ0JMLKN7FvZ/qStMPWXwpdSVLRtRVHXtkYSo/bTJ?=
 =?us-ascii?Q?UMdzfQ2F/s2KRgcHMGuz01TQgB8Bndwuu1MidaAEe73HiXpRq/aSXni2XCl+?=
 =?us-ascii?Q?4QKMN6XxPtVJosrRu1OE1zpXU39JLrxWbb+fPEOIhGmZkWtrDdYbRROgk9rV?=
 =?us-ascii?Q?SUb7CcOMxd8go2PeqBLAIos/WOFTiHCDrgJit4t2zYD+CWtexSSml3nCQ07I?=
 =?us-ascii?Q?NwUAfCzfGWVBzELo+o3YHOeob6f731n5t/6BFeIjSNt7uQpRDomKeHgfzvUi?=
 =?us-ascii?Q?8vL3CjLUqL70tQVc6BnJHhlCJVcDqKlCoU70KzX+0hzASYUbSgJQPDRKKOjE?=
 =?us-ascii?Q?IiSJAzELTY9x0Dv3zgaARQp65gGX+jvLvWu4nYfjGdwx+fzHEn35ePI8yEsn?=
 =?us-ascii?Q?EKbj8BiuK7YdeAy+vT6EydOCCZZIYCNH/FXFdbJbc3PWytXf9IFjjfUZogNR?=
 =?us-ascii?Q?4Y/7WN/pqHz/6cCLHmG1NMc/fq0OVMHkNOSNFw8vc4hHiDfn8Gmbul3By8Dz?=
 =?us-ascii?Q?qKkwiNYFUj5XtY1djQ5/MTV4SGORpHJ6XKys8uavaZn49FzbczYV0sjYBpyc?=
 =?us-ascii?Q?d4wbnppS6FnZO7DhmEXcev78p2xQ0IoglZzW0XgN7N/tEadRIsEZFDU7NGlp?=
 =?us-ascii?Q?ZbCWGfExllv3/MperfVxTM2ZYSNIVd3Uk/3Hb9jXz1tNKUtUJd98b4/yI2oX?=
 =?us-ascii?Q?bRkGsQiO20opMFPeh4KTBJlPuFInZH18TomqN72/xW9q5SaCJscI3ysaPv4s?=
 =?us-ascii?Q?M/lEMud9+CLIS1W2rrE3fEgu4JblCK2oOz1TF8ihdWSbCS4I2vtTsXLmZ4+s?=
 =?us-ascii?Q?xnBE/b4e8jYz79DOSybwUrC8sYgue1uutMGrwN52MS8LUtKV1Fj/bQz0KbPc?=
 =?us-ascii?Q?NZDb47yGvfZ90fMIYMJQkIVKgjg0qQ6PWxXQsdQDES/P+QM7J3bh0kw9U6ty?=
 =?us-ascii?Q?mSf9nPic+gBeHGhwCqFuW4ZE49wrOE+Aonav83iVItT0RzWQiI2PUAwsJgDd?=
 =?us-ascii?Q?71m9mgONRNYpuVrZ/DPJFW07KEQQAxpM8xaXXcPmmSTLykd/h6+iKmMbj4Ep?=
 =?us-ascii?Q?FEZ70LwbpuRse+W/Bve3AWN+asaF0loPu6VcodWjThbEETxkJfxRu9MniPJn?=
 =?us-ascii?Q?0cPkNgFfkjaYXlp5W7Gg4pUDpQxKxzbV5Bqoy7C+i/V4xsW+41fodEEAoU0X?=
 =?us-ascii?Q?NBj7R1SOLs5ucEFvWFZkeHaz9g9UlxmdZLVJess6PhwOu1f+PRwxIdbBlbqe?=
 =?us-ascii?Q?y6Tj8X64RMnvXDQgjnyRqECNtGhRR6vLvF3SHE0vmdob3X3iI/1dWYBsMdRS?=
 =?us-ascii?Q?Bg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?7vXOixt7509sKxaW9STU/n1UWkhYbyoUeoWbEajaQzQtxqrJFsfa4r5aPjcu?=
 =?us-ascii?Q?4Ym053leUb1O9J2pi/yTTX7zJOMKN38HAT9dPXWc3C75tuJbK8yAFPswxPZP?=
 =?us-ascii?Q?ymRK0iGgTpDZxlS1QGi8DlDNaoU7J6nSMSxrsZgeRIGks1V0HO4N7MS6vO+c?=
 =?us-ascii?Q?EDYCUTQNJaC+PRIKxSOMl6rPZVKLunM+t0Y8k1Uw/3PXyoq0Tz+df23sJWoN?=
 =?us-ascii?Q?FB/6FyeriqlsIyKGIXP6xlv596LSWgEPDzw9AwaleZYbyEOefkjwaxnX5teB?=
 =?us-ascii?Q?0bpPjlXsSVHIqev/W3NjdiAeo+YRTpQRsVbhPwpL+8WJFLtm4ZOkUsemzXnM?=
 =?us-ascii?Q?CY0HfsA0YwHKPJBHVwdNWP4MniDgiiwR/ybDn4vKC2HmrCj8VkmcOMs+i2FE?=
 =?us-ascii?Q?3CHhLCEVpAsB005+EIsT1W/CqlyoCsLyrOMPcJpGk8U8Pn4VV0L5wiLQUMwF?=
 =?us-ascii?Q?oFm0bfqFVLXplh6GQsn66wj6+LJW6jgz0ecJevJ72w1RGkl5N/un5KDXUIwj?=
 =?us-ascii?Q?tksyATA0ciFaTt868NOcUHBlPhlHkqc+yRH7x9GGEPbGzXXdNbzfMYUj4QE8?=
 =?us-ascii?Q?XwFs0YWe4uZl74TH2wbQ42uwg5L1hElo9HGhFRdHU073nRGdQW/rrYl0b1tT?=
 =?us-ascii?Q?lmLcDFBX7UZ/SRLUtDfi2cHmpTezvVJ5MAt6b8noxJjVnKYlzRq+baWOPDBo?=
 =?us-ascii?Q?7F8cMBH2UGuFRGNCApnczxbn3RC3chRGogx64HosBzAnhqIMnEy2d+BvO/J5?=
 =?us-ascii?Q?xx7l5Ex05F8Eel2+XQV5sTD4SqTnN40nCUvR8KT/YEDbPlMHtb78oFbjd8u+?=
 =?us-ascii?Q?t1xClin5i/GzyhVkfjnw6RU1rxfS1FmCPh1QUepgVq2Zib3aEPENyRpaiDy3?=
 =?us-ascii?Q?yTlAu/1nAOGtO9a/R78r2MQbERnghndP+/C2OLK+UNIyKg1ZqyUK7DIqUE5H?=
 =?us-ascii?Q?KTQhfiOoCAT/nY9wS4BAGIT/HBH9WjD0jrREcq9M2zsuJ6t3Trix5upgEiN7?=
 =?us-ascii?Q?9LxVHEqP7dLI3asPGLHP/k+i3YVA4x/l3FWudKgyNSogQF8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91c6e529-51c6-49cc-9bf2-08db72bebd8c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 01:19:35.3584
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p4hiVC1GVdWDHPxL498AVdaT2HYLjZQBeuko/i3w35fZZUiUeoVWJmrGnZbmRrrlAXaR3kxmGoD7MKXTw7tTq/Vq8YnjHX/Zy2dXH5Tl28w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6348
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-21_14,2023-06-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 mlxscore=0
 suspectscore=0 bulkscore=0 mlxlogscore=947 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306220007
X-Proofpoint-GUID: 04TZD15CS6oNIaqtoCJStOEudwnO_W9o
X-Proofpoint-ORIG-GUID: 04TZD15CS6oNIaqtoCJStOEudwnO_W9o
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


Abel,

> Un-reviewed. This is broken and was never tested. After applying this
> patch, I can see many new warnings in all DTBs (so it is easy to spot
> that it was not actually tested).
>
> Your probably meant here:
>   if:
>     required:

Please provide a fix for this. I don't want to rebase this late in the
cycle.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering