Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Jun 2023 13:06:34 +0200
From:   Damian Muszynski <damian.muszynski@intel.com>
To:     <herbert@gondor.apana.org.au>
CC:     <linux-crypto@vger.kernel.org>, <qat-linux@intel.com>,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 0/5] crypto: qat - add heartbeat feature
Message-ID: <ZJQrOkNCoRl3UPZy@dmuszyns-mobl.ger.corp.intel.com>
References: <20230620130823.27004-1-damian.muszynski@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230620130823.27004-1-damian.muszynski@intel.com>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173,
 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kXRQDDk5c0YIWDzb2xL0Of9HzauWkPrj6v+30c8Eib9L9mgJiFbq4mgtkHe3?=
 =?us-ascii?Q?/VFl64hGM8meP4xracgGQgzaQrP+0BNp20Pu/PqorTt1aRy/hozgLsfF4RuN?=
 =?us-ascii?Q?yDKcl4QjxQIzYiR5bxbzQlp7FYap3HT9hii9q+JnIOOUTD1RPUbc0igxYKiX?=
 =?us-ascii?Q?DSOF8Dc5jkkcWbAqymjkKvmssjHJeDc2NQKDbBKmXdhpV6lh05iq+oOlBS2v?=
 =?us-ascii?Q?fpgczxM7/U543XQm26VMYB9twN3lnYtsCrZG2XFXaUJ2JqTRt30zaeVJ8f8H?=
 =?us-ascii?Q?Bo5VypH3dG3B8DPS0SH4OV+Xsm4TwZSl6qIZCx0zfEJQ6EoPy4SICvBk2hQ1?=
 =?us-ascii?Q?C3lYpJRim0MiSF7gyeMONIiVlI9FdPRuUlM1A3ojWGjerDOljGvqv+cDeSiv?=
 =?us-ascii?Q?wezAjVwXiDn+egwFXwy/IXso8ptGWZUOlFLtDsb/p2cWo4sfbIWYPmQRyBtD?=
 =?us-ascii?Q?ia4bpX2Xueqdn+JMJUNoSQYwE8lMjLtdaTxsp7+DktuiOUnWX7zNDVP6cQR6?=
 =?us-ascii?Q?+1LjUwK98txRIFX+ifrZMkAuE0MzUfyOaCwwTb2P5x+2NvSqm3OpbzG8dHu5?=
 =?us-ascii?Q?VS0FAhXoTEXYbhCB8MDv2Ma75X/9FlTMzrTjGA0LzmS+oXIFXbSv3a9u5sj6?=
 =?us-ascii?Q?oFJuAkxK7OL5ocGS7i+DUIAju/0gdC0EwCXP/fmkMujiAaiU9aO5blGFTZ5B?=
 =?us-ascii?Q?VtChEcwM9kieLtrDXF1xpoa8qF/R6N3niDvC46eUo0z1GE3HnV1Gr443CYtW?=
 =?us-ascii?Q?z1U6deI+25dLSZ/BpK7z2zA3EDnyPWGpSnsekFLpRglZ//gGv4LgjTmU7060?=
 =?us-ascii?Q?wzbCeVfsImvRbayrK9pzHJ2R99ztUGhuZtv+ALQ1VOBFYOky/XlADgfO4Ijc?=
 =?us-ascii?Q?IECfcU3FhqFz4ZGiHhb5MvNfvh8AtUGyZ+poTChAMPr+fJOVRAViPKaJv0BC?=
 =?us-ascii?Q?R0yDd3OWIfHncjD6etrdtMqxsxcPqsoF9Jisn73epAXLnudHVDgBJ3nqFFn2?=
 =?us-ascii?Q?cBVoj88iA+AA45fcPK+uGAyY4zj6BBVcbscZja0iXM9t3ctMa6SrMPFH6mPc?=
 =?us-ascii?Q?GentGMZLfDVmmZ+Cd6ZayvTGWvqKm6UrASenhZ88x6rY4ZrPYiRcDImg2rHO?=
 =?us-ascii?Q?PWZ4IH2EQOUVJy0fCfXtfyrMCyk1iWylFWwXOAAZHedPg6RG44RWeSXlcOVL?=
 =?us-ascii?Q?0TdkMSiFuWjPEoZWuJWlgBq0ZEHDM6R0YEfqZCtFIvZwSJshJfPsfTqBVr35?=
 =?us-ascii?Q?DN3hjXapa8n2b/rUPmxfUqXUZTi6KqCQsnpijFskyPwAC6CNRvdwE1SLCiEV?=
 =?us-ascii?Q?sy6vO2zclbFCAUWDPC+fI0+kDWyxd0mTkQUBAs388Z9yUIcqE/C4XK4cbqTg?=
 =?us-ascii?Q?l53lLnSym5J8ikL7n86n8OuZJriTR4EFm3FW4BE9lVdnAPSBLIbnRc3uWk5W?=
 =?us-ascii?Q?R0r1OeoQAYFSt1qNN7NjE06TG1ZU3tHOqmAaF/GGtYj2BzmxIzbvYOLnf2YZ?=
 =?us-ascii?Q?tdfWrTBHZJ7tef7zGLQXBIsQZmjWzeLBBN98WuScx5LPTcIkpBrE9A/rE8zE?=
 =?us-ascii?Q?d0EFj8xNDWux1BlXOBSeW9OjPbivtjhN/Uv5PTiReeMi8jA/9bJDlmodfBuB?=
 =?us-ascii?Q?Lw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c2821c58-8ab5-40c3-ad43-08db7310c434
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 11:06:45.4157
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z4Q4rckGO1od/CquYt66XpHc4RCJre1VGTC9jzlkyW4U9Hs6VJ6duDplQ2d99nkevV6gMVrTbQlwad8+gDU40IV2jhrogsKGViY5mgWcK0g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5179
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi Herbert,

On 2023-06-20 at 15:08:18 +0200, Damian Muszynski wrote:
> This set introduces support for the QAT heartbeat feature. It allows
> detection whenever device firmware or acceleration unit will hang.
> We're adding this feature to allow our clients having a tool with
> they could verify if all of the Quick Assist hardware resources are
> healthy and operational.
> 
> QAT device firmware periodically writes counters to a specified physical
> memory location. A pair of counters per thread is incremented at
> the start and end of the main processing loop within the firmware.
> Checking for Heartbeat consists of checking the validity of the pair
> of counter values for each thread. Stagnant counters indicate
> a firmware hang.
> 
> The first patch adds timestamp synchronization with the firmware.
> The second patch removes historical and never used HB definitions.
> Patch no. 3 is implementing the hardware clock frequency measuring
> interface.
> The fourth introduces the main heartbeat implementation with the debugfs
> interface.
> The last patch implements an algorithm that allows the code to detect
> which version of heartbeat API is used at the currently loaded firmware.
> 
> Signed-off-by: Damian Muszynski <damian.muszynski@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Unfortunately, with this set we found another build issue on 32 bit architectures.
Please ignore this version. I will send the fixed one today. 

>> ld: drivers/crypto/intel/qat/qat_common/adf_clock.o: in function `measure_clock':
>> drivers/crypto/intel/qat/qat_common/adf_clock.c:87: undefined reference to `__udivdi3'

Sorry for the noise.

---
Best Regards,
Damian Muszynski