Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Jun 2023 21:26:18 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Damian Muszynski <damian.muszynski@intel.com>
Cc:     herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
        qat-linux@intel.com, Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: Re: [PATCH v3 3/5] crypto: qat - add measure clock frequency
Message-ID: <ZJSSSnFhuDR9CkEc@smile.fi.intel.com>
References: <20230622180405.133298-1-damian.muszynski@intel.com>
 <20230622180405.133298-4-damian.muszynski@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230622180405.133298-4-damian.muszynski@intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Jun 22, 2023 at 08:04:04PM +0200, Damian Muszynski wrote:
> The QAT hardware does not expose a mechanism to report its clock
> frequency. This is required to implement the Heartbeat feature.
> 
> Add a clock measuring algorithm that estimates the frequency by
> comparing the internal timestamp counter incremented by the firmware
> with the time measured by the kernel.
> The frequency value is only used internally and not exposed to
> the user.

...

> +	/*
> +	 * Enclose the division to allow the preprocessor to precalculate it,
> +	 * and avoid promoting macro to 64bits before division.

"...promoting r-value to 64-bit..."

> +	 */
> +	*frequency = temp * (HZ_PER_MHZ / 10);

-- 
With Best Regards,
Andy Shevchenko