Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp12871275rwd; Fri, 23 Jun 2023 11:53:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ72dy9npKYnHE2gaQVQWUdyjJM7qWfQdj+43MTmu0J41obxm5jszdLTolG/+YDsJd58IE9C X-Received: by 2002:a05:6a21:329e:b0:116:696f:1dd1 with SMTP id yt30-20020a056a21329e00b00116696f1dd1mr28711552pzb.4.1687546422183; Fri, 23 Jun 2023 11:53:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687546422; cv=none; d=google.com; s=arc-20160816; b=dguKQVSe1KM+V/KqgCjgEQkPAj96wXGkjAlHUEFi+aIwyxcM0pP8Qcio+gU0MoJ+GR l0l8DfkveMOBGL3opHd5E64G97l4SW6dTdDmjUBnqju6PFwzogPD8gIi7xCuBVm3430r DBmhHVSNh/UCTZyYk3ODGWwgQ3mU4/k46YYLikjGSLBlI4BSpamfypRM2St9x5CCU8tB AXviW5evrtfZIfO0oWOPegJA7qlUAh9RrVjoM0udItEBp2KCCOqXMldKxl46f03GQJFU RqPnEi0j83JFCXwGY0qHl87s/HJKioJ3W7vfwA5sA6eg37H/LJSGfc38RiiDU6e7GeP/ l0qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=kPsFHZQ8Zy5mr/8/gGORRwtCiPlqJLBD/CyQhn75fbE=; fh=fr/HecOLcOvgvOD6PXOiWc+fkWQT1x4x7vUiRYJzC+0=; b=UfaZjMWmJaKBJCF7g2oUGHA+yhZsUS+Awyn0T02+ezTbSyZcL+oW7SsMnq4cDK+8nO 4dHkOM9BD4hn1k5SOpkPzqWDxPQSp+ofhVdhQ9WmhAWjn9JErwPS0w24D3/75pXxCU1J IOSD6grYF7YunemJeGNBO83quXw5zbk1YmPGDyHKellHhfeMU38bF7L8oPEXmKvRaJO4 +JQHtlpjvHgzOj1wVB0odtVhMwrZlpjtdlyvrVK9A2P65N4Talhr7Nc9txjjCceOa6bG 3VO8EPYVvV/H1uGZHSP8B3Jqi2RhU0oJDwS+86brzrBRxGTWzz5Kp8EnwmYeuCJ9kzr5 0W9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MwIuyytO; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d32-20020a634f20000000b005533c53f577si44084pgb.138.2023.06.23.11.53.25; Fri, 23 Jun 2023 11:53:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MwIuyytO; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231634AbjFWSin (ORCPT + 99 others); Fri, 23 Jun 2023 14:38:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbjFWSid (ORCPT ); Fri, 23 Jun 2023 14:38:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF8F1273D for ; Fri, 23 Jun 2023 11:38:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 73FD961ACF for ; Fri, 23 Jun 2023 18:38:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6D7BC433C0 for ; Fri, 23 Jun 2023 18:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687545491; bh=OtWHIwsSfrQ1UbW0o6UkWOmN15JAugavya5osLAtWxk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MwIuyytOCpzi5bTEpXsIlv89e8oVc40ptpIpx/AYq/yeLeHuK6BH/2op0mH0ygtTA OeQhyIVlF858fxkBrEj7KMajanqkBcVt7PsJT5wIoEXxQNTZS6s7t77yxN3JtlP6iB CbCXWDIuODC89jAgOoM83FYf227Qu5RbxWhdUF0ctNrDQCpMHO0IA4zAHvVq5WE/tq zmtxsKlvXaPfYr827sh8mE2btun4j8gZ09eR05yN8m7pbm/i97gi3vH3fhUgsc/l/L M4D5snI+stVJQ2plP/PVpRWb4j+7OIumEo9NXklDShUDu4vCRwzxfu+cvySt22hAo3 IFWFCnijK2zxw== Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2b4826ba943so15929501fa.0 for ; Fri, 23 Jun 2023 11:38:11 -0700 (PDT) X-Gm-Message-State: AC+VfDxxUsqyyQKxG55guvSh4arpVqwpx3qXY7gzIAPIRHH3C9TtAPVj 9NIPiPXP9WkV/WR8C8O389cfOaVRuhbHtBawh44= X-Received: by 2002:a05:6512:340f:b0:4f5:1418:e230 with SMTP id i15-20020a056512340f00b004f51418e230mr15249612lfr.52.1687545489648; Fri, 23 Jun 2023 11:38:09 -0700 (PDT) MIME-Version: 1.0 References: <20230606173127.4050254-1-ardb@kernel.org> <20230606173127.4050254-3-ardb@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Fri, 23 Jun 2023 20:37:58 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] crypto: arm - add some missing SPDX headers To: Richard Fontana Cc: Bagas Sanjaya , linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, ebiggers@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, 20 Jun 2023 at 05:50, Richard Fontana wrote: > > On Sat, Jun 10, 2023 at 3:31=E2=80=AFAM Bagas Sanjaya wrote: > > > > [also Cc'ing Richard] > > > > On Tue, Jun 06, 2023 at 07:31:26PM +0200, Ard Biesheuvel wrote: > > > Add some missing SPDX headers, and drop the associated boilerplate > > > license text to/from the ARM implementations of ChaCha, CRC-32 and > > > CRC-T10DIF. > > > > > > Signed-off-by: Ard Biesheuvel > > > --- > > > arch/arm/crypto/chacha-neon-core.S | 10 +---- > > > arch/arm/crypto/crc32-ce-core.S | 30 ++------------- > > > arch/arm/crypto/crct10dif-ce-core.S | 40 +------------------- > > > 3 files changed, 5 insertions(+), 75 deletions(-) > > > > > > diff --git a/arch/arm/crypto/chacha-neon-core.S b/arch/arm/crypto/cha= cha-neon-core.S > > > index 13d12f672656bb8d..46d708118ef948ec 100644 > > > --- a/arch/arm/crypto/chacha-neon-core.S > > > +++ b/arch/arm/crypto/chacha-neon-core.S > > > @@ -1,21 +1,13 @@ > > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > > /* > > > * ChaCha/XChaCha NEON helper functions > > > * > > > * Copyright (C) 2016 Linaro, Ltd. > > > * > > > - * This program is free software; you can redistribute it and/or mod= ify > > > - * it under the terms of the GNU General Public License version 2 as > > > - * published by the Free Software Foundation. > > > - * > > > * Based on: > > > * ChaCha20 256-bit cipher algorithm, RFC7539, x64 SSE3 functions > > > * > > > * Copyright (C) 2015 Martin Willi > > > - * > > > - * This program is free software; you can redistribute it and/or mod= ify > > > - * it under the terms of the GNU General Public License as published= by > > > - * the Free Software Foundation; either version 2 of the License, or > > > - * (at your option) any later version. > > > */ > > > > I think above makes sense, since I had to pick the most restrictive one > > to satisfy both license option (GPL-2.0+ or GPL-2.0-only). > > I am not sure "had to pick the most restrictive one" is necessarily > correct - the kernel could adopt that approach but I don't think > there's any reason why you can't have multiple > SPDX-License-Identifier: lines in a single source file, and it is also > syntactically valid to use > SPDX-License-Identifier: GPL-2.0-only AND GPL-2.0-or-later > For the record, my reasoning was that my code (which is a rewrite of the algorithm using a completely different ISA) is the derived work, and I am permitted to exercise my right granted by the original work to redistribute it under the GPLv2. So this is why the 'outer' license (as well a the SPDX header) is GPLv2 only. I didn't expect there to be a requirement for SPDX to describe the original licenses of all the constituent parts. In any case, I am going to take Greg's advice and not pursue this any further - if anyone needs this cleaned up, they can do it themselves. Thanks for the education on this topic, I'll know better next time :-)