Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp13485965rwd; Sat, 24 Jun 2023 00:53:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5tfXpx12KWuRQBPWHMjMLMja3vWyEVTkiesY1PhxxsNVCUfpffKu0TGft4FBEedZAhnI6H X-Received: by 2002:a17:902:dac6:b0:1a1:956d:2281 with SMTP id q6-20020a170902dac600b001a1956d2281mr29244167plx.3.1687593233862; Sat, 24 Jun 2023 00:53:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687593233; cv=none; d=google.com; s=arc-20160816; b=y1xTF24U3clTTu51zQdlfOFYJdRH5Td31/17KxK4+OjsKJWzFU+JMwx/yg+GCXVEnn bl5EMo2hZv+b/6oA+lAPyEc8alyIA2HsxQh6MRJeap/44+Kl/v7GC0ynI9+WD9FhRikc rdVLFbHJlFm+3mqyfZWT1FVuJEjm0HXVrIgJHnugErOGvHcXq/hOSeXGLORzCsXIBYcr 1x7JxU8wBFrUy2BKmthUbgaWJO2tqW0JY6vcj1sAdlRnmzuAt55lqtTWJ/+vgTPE83Tt 9yKUI6hTI16IWmJZC3/pVRHS9zfsUs86QsMNlOc/NvPSjUzT/Kn1AznPQ+AQEq4r9chn DO3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=W/rDaXsqUdEVc5mndL1TxOjLuicVm9iSidQSWVUkRP8=; fh=iKAUj4j7tdy6OXhmLhFffPyi4j7PSN5ryLjP1juDN8s=; b=ref/KDdc5afWrLzFMopd00Wj3Q0NZonlxd5Jjm8YJ7nfVEDb4DucKuAdEvUfI7hxXc Fr1y2ZbHGw1khcNAMPEGxMfndn6qJt1ZKYhw/uVcin4ehXcYktVMshGNaQ9CEMsR+Me9 R87jPm6o7sTJs5JCKd/p6xVSYZQG6rZRqUpwbmIgIhpizrbBAKq1IcKnaEHYA0JjAw4C HbnMciWkBH821vRN+/34k6c0BxIBQm7RE3mKrCXXo5NPAIS3OCY0snIsRZZl7msWhs7L v73e7c12qYPbV8Vn9TB4URE0m4qtgQBdkWOQWWlFGsjE9hm16WF4NwPmdSbUXH9PNmP/ 7+kA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j23-20020a63ec17000000b00543bfe3eaffsi981250pgh.762.2023.06.24.00.53.19; Sat, 24 Jun 2023 00:53:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229615AbjFXHrO (ORCPT + 99 others); Sat, 24 Jun 2023 03:47:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjFXHrN (ORCPT ); Sat, 24 Jun 2023 03:47:13 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4089AD3 for ; Sat, 24 Jun 2023 00:47:10 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qCxyu-006hCq-Kf; Sat, 24 Jun 2023 15:46:53 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 24 Jun 2023 15:46:52 +0800 Date: Sat, 24 Jun 2023 15:46:52 +0800 From: Herbert Xu To: Ard Biesheuvel Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, linux-crypto@vger.kernel.org Subject: Re: [PATCH] crypto: sm2 - Provide sm2_compute_z_digest when sm2 is disabled Message-ID: References: <202306231917.utO12sx8-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_00,HELO_DYNAMIC_IPADDR2, PDS_RDNS_DYNAMIC_FP,RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS,TVD_RCVD_IP, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Jun 24, 2023 at 09:40:59AM +0200, Ard Biesheuvel wrote: > > How is this supposed to work when > CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE=y but SM2 is configured as a > module? It will fail as it did previously. I'm just rearranging the code. Perhaps when another algorithm that requires a non-standard digest comes up we can think up of a proper abstraction. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt