Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202306231917.utO12sx8-lkp@intel.com> <ZJZ8/JifEeygojAq@gondor.apana.org.au>
 <CAMj1kXGKnusvWDV8rSUhQexeKy1e2+x2-ZXw6_6RiExvtiR_8A@mail.gmail.com> <ZJafbEJ4SOYPEo1N@gondor.apana.org.au>
In-Reply-To: <ZJafbEJ4SOYPEo1N@gondor.apana.org.au>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Sat, 24 Jun 2023 09:47:43 +0200
Message-ID: <CAMj1kXE7GT99EnjsmO1HYX1KOoAfbDUNZwpYxfuo5oYptdW_KA@mail.gmail.com>
Subject: Re: [PATCH] crypto: sm2 - Provide sm2_compute_z_digest when sm2 is disabled
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     kernel test robot <lkp@intel.com>, oe-kbuild-all@lists.linux.dev,
        linux-crypto@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 24 Jun 2023 at 09:47, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Sat, Jun 24, 2023 at 09:40:59AM +0200, Ard Biesheuvel wrote:
> >
> > How is this supposed to work when
> > CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE=y but SM2 is configured as a
> > module?
>
> It will fail as it did previously.  I'm just rearranging the code.
> Perhaps when another algorithm that requires a non-standard digest
> comes up we can think up of a proper abstraction.
>

Fair enough.