Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 10:42:59 -0500
From:   John Allen <john.allen@amd.com>
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     Tom Lendacky <thomas.lendacky@amd.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v5 00/11] Add dynamic boost control support
Message-ID: <ZJsDg7xl6P8YfaaV@johallen-workstation>
References: <20230623135001.18672-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230623135001.18672-1-mario.limonciello@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DLMj5HUQAl7v59ILPKbk9Qz4sUxsEZqKw7C+xJuI7gg6pXnKrNSh2+F3kyoB?=
 =?us-ascii?Q?ZsmDkIn5udunxAKlxMgMzd9u2pkBRBuZKay14zXaHlEVAmK35slacGqFo2UQ?=
 =?us-ascii?Q?rm4mti3yttcGcg0GAI4vnTcjtw7OTUFoUNVCOaOB/C64xKFfeLML6f61I//G?=
 =?us-ascii?Q?cMM/i5k7CyZS9wX4P9v+EFx+NRdrm6tElBeXPXvVXm8OkGoIXPMrxVF4fna0?=
 =?us-ascii?Q?9HIrPpw8br/m519qHzt6bo0TlXkbui11MAb94YxnR5Aym734NRBPAz/skSyo?=
 =?us-ascii?Q?AkZBdYVfqJsI0l7YKGl9yUut49qcYlWiCBA6D+8nhSDTbAo1mvm4x9yfWcVh?=
 =?us-ascii?Q?rf/b+2D4DuvXBjHT2Ry+XVfRv090PxHuvl2nlXDP2bDQcW4zrsyQgDh3k1jr?=
 =?us-ascii?Q?dvpjLwwGMGcFy3EqYrhkkAOlA7TydfGjWdRXaDAyY5Bgnr9t3M9OG7Nu2LAE?=
 =?us-ascii?Q?qAcazttVVMsFXkYa/W32TaG8E41of5SeWmNW3QTlopysNCPq8aXqzY4QQwQA?=
 =?us-ascii?Q?FJaXEJvuUAXsRR/dMpQ+jR3rGAkpaqXIHEBWTA/DZxoBrTGnpYHVwZVTrgmz?=
 =?us-ascii?Q?MTLn6ysASrUDRjtXJtw9dxYYo12heMzR5Qyws065FggxzH6TU16yDTXC5hqU?=
 =?us-ascii?Q?+CyEH5lFh8vls4s1X1Zj5F5eaUDaBg9/lE4+k3TZ+GSddT4+o5F2lcrgbExY?=
 =?us-ascii?Q?IVcPuR++vU7F1iQFRGmVQcNsVuMOP/RELjwj6YhrSPohDJwGtX0Kt6fxz3cH?=
 =?us-ascii?Q?7E2+itbNt4iGytPPZiLTftdVkCoritqZHSBwVRqZPrCxnRid8b45KqULKl0L?=
 =?us-ascii?Q?QdX8/FDuUJIqjYZVuTyTOpdtc/yzb1XgO/ID9hEV02R/MEvyFNr3x+dtxpw2?=
 =?us-ascii?Q?l5UbJHe1ARShsWs1yB4lw2PhM+0utbmiOBJMCkgbE+pzR2KS/dSEiZXSfTER?=
 =?us-ascii?Q?P2xvb5WG9q1WShjh0g3tOZqSwF+9zrt04yECs2t9+uiRGnMPXTAYCxeKVHYO?=
 =?us-ascii?Q?T+QPc/bHiW1z8HvUTs+FWTI3Rexy2gmO4BXEzBKk8LbatzhgJaDFkRmqJnl/?=
 =?us-ascii?Q?7AbSiqvO73md7EgyXYMtWBB2MpPzkioPae8K5tuKtXIZM/e01z50eT4PsDWb?=
 =?us-ascii?Q?F2R1LCbB5bThnIaJ7WQMr5qJQXMemd3PGnm4oQRvU3fOOAd5Y3kwFw8jD639?=
 =?us-ascii?Q?90+HU9S1Lo0KGfrOemjkv6+0H/nfCNg92LiOGvcIeHkhlzFZ513WXskuWGx4?=
 =?us-ascii?Q?YyhToSoOQVQ6e3acmRYC27JnQ7O5q3fC8S4DX8AgGVI5p+0KvZFK2Kbz6k3I?=
 =?us-ascii?Q?JdWVDCoWRb8FL3OFqbANRDrePx+TcpuffazEP0U8y/a1uwxJDj6SYA8ub/Gd?=
 =?us-ascii?Q?7IyDziR2v20+G/Q8WR3o04S6DYZWqIPkcSg7SoVwMOn3DoiUx8ECOd203W81?=
 =?us-ascii?Q?AMvEivLReJFclxOYJmaTP9Zjl+ZqkgbPHsN2ydQ3ljNyBk0Rn+TmVg/V2ibj?=
 =?us-ascii?Q?SFrVRPsoqCFjz0t8i8M5Hba9AQ+71D0tZ8/+gREzZxpVUBi+pB33z1zKVdHD?=
 =?us-ascii?Q?+I62xzFdl7oxwiPSh03gxbUgmB60xxnfW96S7y4W?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb618c1e-3a3a-49ad-b063-08db7725340d
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5995.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 15:43:07.5151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GiGIZkCc0PMTgp1jHNE5mQwCAB6/c0Ow1vMSD/onx6gBCFmlEbBonDsgM7yEYzh46cQA6FhWLPQtBaA6lDqCow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6066
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Fri, Jun 23, 2023 at 08:49:50AM -0500, Mario Limonciello wrote:
> Dynamic boost control is a feature of some SoCs that allows
> an authenticated entity to send commands to the security processor
> to control certain SOC characteristics with the intention to improve
> performance.
> 
> This is implemented via a mechanism that a userspace application would
> authenticate using a nonce and key exchange over an IOCTL interface.
> 
> After authentication is complete an application can exchange signed
> messages with the security processor and both ends can validate the
> data transmitted.
> 
> This series includes a test suite that can be run on real hardware
> to ensure that the communication works as expected.  This can also be
> used for an application to model the communication path.
> 
> Two sysfs files are introduced for reading the PSP bootloader version
> as well as TEE version which can be useful data points for debugging
> communication problems.

Series looks OK to me.

Acked-by: John Allen <john.allen@amd.com>

> 
> v4->v5:
>  * Pick up tags
>  * Pick up a static fix
>  * Fix a mistake found in dbc_cli
> 
> Mario Limonciello (11):
>   crypto: ccp: Rename macro for security attributes
>   crypto: ccp: Add support for displaying PSP firmware versions
>   crypto: ccp: Add bootloader and TEE version offsets
>   crypto: ccp: move setting PSP master to earlier in the init
>   crypto: ccp: Add support for fetching a nonce for dynamic boost
>     control
>   crypto: ccp: Add support for setting user ID for dynamic boost control
>   crypto: ccp: Add support for getting and setting DBC parameters
>   crypto: ccp: Add a sample library for ioctl use
>   crypto: ccp: Add a sample python script for Dynamic Boost Control
>   crypto: ccp: Add unit tests for dynamic boost control
>   crypto: ccp: Add Mario to MAINTAINERS
> 
>  Documentation/ABI/testing/sysfs-driver-ccp |  18 ++
>  MAINTAINERS                                |  12 +
>  drivers/crypto/ccp/Makefile                |   3 +-
>  drivers/crypto/ccp/dbc.c                   | 250 +++++++++++++++++++
>  drivers/crypto/ccp/dbc.h                   |  56 +++++
>  drivers/crypto/ccp/psp-dev.c               |  19 +-
>  drivers/crypto/ccp/psp-dev.h               |   1 +
>  drivers/crypto/ccp/sp-dev.h                |   7 +
>  drivers/crypto/ccp/sp-pci.c                |  96 +++++++-
>  include/linux/psp-platform-access.h        |   4 +
>  include/uapi/linux/psp-dbc.h               | 147 ++++++++++++
>  tools/crypto/ccp/.gitignore                |   1 +
>  tools/crypto/ccp/Makefile                  |  13 +
>  tools/crypto/ccp/dbc.c                     |  72 ++++++
>  tools/crypto/ccp/dbc.py                    |  64 +++++
>  tools/crypto/ccp/dbc_cli.py                | 134 +++++++++++
>  tools/crypto/ccp/test_dbc.py               | 266 +++++++++++++++++++++
>  17 files changed, 1146 insertions(+), 17 deletions(-)
>  create mode 100644 drivers/crypto/ccp/dbc.c
>  create mode 100644 drivers/crypto/ccp/dbc.h
>  create mode 100644 include/uapi/linux/psp-dbc.h
>  create mode 100644 tools/crypto/ccp/.gitignore
>  create mode 100644 tools/crypto/ccp/Makefile
>  create mode 100644 tools/crypto/ccp/dbc.c
>  create mode 100644 tools/crypto/ccp/dbc.py
>  create mode 100755 tools/crypto/ccp/dbc_cli.py
>  create mode 100755 tools/crypto/ccp/test_dbc.py
> 
> 
> base-commit: b335f258e8ddafec0e8ae2201ca78d29ed8f85eb
> -- 
> 2.34.1
>