Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 2 Jul 2023 00:05:37 +0100
From:   Conor Dooley <conor@kernel.org>
To:     jiajie.ho@starfivetech.com, Palmer Dabbelt <palmer@rivosinc.com>,
        olivia@selenic.com, herbert@gondor.apana.org.au,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        kernel@esmil.dk, Conor Dooley <conor.dooley@microchip.com>,
        linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v5 3/3] riscv: dts: starfive: Add TRNG node for
 VisionFive 2
Message-ID: <20230702-ajar-stingy-3eb04f334575@spud>
References: <20230117015445.32500-4-jiajie.ho@starfivetech.com>
 <mhng-348475f1-5880-4951-9692-78210a17acd3@palmer-ri-x1c9a>
 <ZKCgXvcbWBGWZnsU@aurel32.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ej1htFhOe1EwGlXT"
Content-Disposition: inline
In-Reply-To: <ZKCgXvcbWBGWZnsU@aurel32.net>
Precedence: bulk


--ej1htFhOe1EwGlXT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jul 01, 2023 at 11:53:34PM +0200, Aurelien Jarno wrote:
> On 2023-03-14 18:45, Palmer Dabbelt wrote:
> > On Mon, 16 Jan 2023 17:54:45 PST (-0800), jiajie.ho@starfivetech.com wr=
ote:
> > > Adding StarFive TRNG controller node to VisionFive 2 SoC.
> > >=20
> > > Co-developed-by: Jenny Zhang <jenny.zhang@starfivetech.com>
> > > Signed-off-by: Jenny Zhang <jenny.zhang@starfivetech.com>
> > > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> > > ---
> > >  arch/riscv/boot/dts/starfive/jh7110.dtsi | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > >=20
> > > diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/bo=
ot/dts/starfive/jh7110.dtsi
> > > index 4ac159d79d66..3c29e0bc6246 100644
> > > --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> > > +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> > > @@ -455,5 +455,15 @@ uart5: serial@12020000 {
> > >  			reg-shift =3D <2>;
> > >  			status =3D "disabled";
> > >  		};
> > > +
> > > +		rng: rng@1600c000 {
> > > +			compatible =3D "starfive,jh7110-trng";
> > > +			reg =3D <0x0 0x1600C000 0x0 0x4000>;
> > > +			clocks =3D <&stgcrg JH7110_STGCLK_SEC_HCLK>,
> > > +				 <&stgcrg JH7110_STGCLK_SEC_MISCAHB>;
> > > +			clock-names =3D "hclk", "ahb";
> > > +			resets =3D <&stgcrg JH7110_STGRST_SEC_TOP_HRESETN>;
> > > +			interrupts =3D <30>;
> > > +		};
> > >  	};
> > >  };
> >=20
> > Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>=20
> It appears that this patch has never been applied, although the rest of
> the series has already been merged.

Ditto here, depends on the stgcrg, so it can't be applied yet.

> Unfortunately it doesn't apply
> anymore due to other changes to that file.
>=20
> Could you please rebase and resend it?

No harm in a resend of course, given it doesn't apply.

Cheers,
Conor.

--ej1htFhOe1EwGlXT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZKCxQQAKCRB4tDGHoIJi
0lmZAP0SNjqkT8s0n5wtApbSeSzlCFqL+QWYwc90EmHZ2nvUAAD6AyyO6yS2S+0w
9vMPZEB+a1Y4AmHnkfKGkzunks9MQw8=
=Mc7t
-----END PGP SIGNATURE-----

--ej1htFhOe1EwGlXT--