Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Jul 2023 10:55:55 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     =?utf-8?B?5bCk5bq35LuB?= <youkangren@vivo.com>
Cc:     Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Damian Muszynski <damian.muszynski@intel.com>,
        Adam Guerin <adam.guerin@intel.com>,
        Tom Zanussi <tom.zanussi@linux.intel.com>,
        Srinivas Kerekare <srinivas.kerekare@intel.com>,
        "open list:QAT DRIVER" <qat-linux@intel.com>,
        "open list:CRYPTO API" <linux-crypto@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "opensource.kernel" <opensource.kernel@vivo.com>,
        =?utf-8?B?6Lev57qi6aOe?= <luhongfei@vivo.com>
Subject: Re: [PATCH v4] crypto: qat - Replace the if statement with min()
Message-ID: <ZKPQi+C/9ibEVTfa@smile.fi.intel.com>
References: <PUZPR06MB5936BE4F5D5353CF2A08A07BAA2EA@PUZPR06MB5936.apcprd06.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <PUZPR06MB5936BE4F5D5353CF2A08A07BAA2EA@PUZPR06MB5936.apcprd06.prod.outlook.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Jul 04, 2023 at 07:45:42AM +0000, 尤康仁 wrote:
> Hi Andy,
> 
> Can you tell me what is your tag? I haven't found it in Re: [PATCH v3]
> crypto: qat - Replace the if statement with min()

Please, avoid top-postings.

Tag in this case is the line started with Reviewed-by:.

Please, read this [1] to get familiar with the tags and process.
And be respectful to the reviewers in the future.

[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

> -----Original email-----
> On Tue, Jul 04, 2023 at 02:56:39PM +0800, You Kangren wrote:
> > mark UWORD_CPYBUF_SIZE with U suffix to make the type the same with
> 
> You need to respect English grammar and punctuation.
> Here should be
> 
>   Mark...
> 
> > words_num and replace the if statement with min() in
> 
> (drop trailing space)
> 
> > qat_uclo_wr_uimage_raw_page() to make code shorter
> 
> ...and here the period is missing.
> 
> Also, Haven't I given my tag? Why it's not added?
> 
> > Signed-off-by: You Kangren <youkangren@vivo.com>
> > ---
> 
> Where is the changelog from v3? What had been changed so far?

-- 
With Best Regards,
Andy Shevchenko