Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Jul 2023 21:57:54 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Eric Biggers <ebiggers@kernel.org>
CC:     <herbert@gondor.apana.org.au>, <agk@redhat.com>,
        <snitzer@kernel.org>, <linux-crypto@vger.kernel.org>,
        <dm-devel@redhat.com>, <linux-kernel@vger.kernel.org>,
        <qat-linux@intel.com>, <heinzm@redhat.com>,
        <meenakshi.aggarwal@nxp.com>, <horia.geanta@nxp.com>,
        <V.Sethi@nxp.com>, <pankaj.gupta@nxp.com>, <gaurav.jain@nxp.com>,
        <davem@davemloft.net>, <iuliana.prodan@nxp.com>,
        Fiona Trahe <fiona.trahe@intel.com>
Subject: Re: [PATCH 1/3] dm integrity: do not filter algos with
 CRYPTO_ALG_ALLOCATES_MEMORY
Message-ID: <ZKXZUl4VgZkMbOL0@gcabiddu-mobl1.ger.corp.intel.com>
References: <20230705164009.58351-1-giovanni.cabiddu@intel.com>
 <20230705164009.58351-2-giovanni.cabiddu@intel.com>
 <20230705201205.GA866@sol.localdomain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230705201205.GA866@sol.localdomain>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AF8O9itqQb2xGU42YPgWnOI8wPzMencjFUXFcTMe9ZeOGd4PE6UyYEKxZ5p3?=
 =?us-ascii?Q?iBgW6ftDrLzYNOlua7SnQlCeve5NtWhsvPd+QwZA5oGTzzCXu3VuTDADes2M?=
 =?us-ascii?Q?yTlUAhQSkpuKi5WdWwYzvstD00jujiO2urm/qFg+mwUSfBidR4fGY0/Om/4z?=
 =?us-ascii?Q?iCfsu6/CFvxsAqxKyyk03NjT+H8Vw0UzrozEq8/BXk7uX70+sihuOUvwsIaf?=
 =?us-ascii?Q?30Bms+eBwjnet9OaWwK/CbTFyHTNRqdUjIF+4QB0C7nATh9cEGP/zfFaVOpO?=
 =?us-ascii?Q?/L+a9LhbLg47gSUKAT867LLbkMn8CrIUN/zMDI8ero1Yb8UaeniBvfxdHpOE?=
 =?us-ascii?Q?rbM9drRLCuwoKnzi1PtCNhGyMeCm6YN24cjHrsLY3KNOl1aBrg/umByCZ2Dd?=
 =?us-ascii?Q?UMlewTj9ysw55duVegRlepH5wACFgvctdFxZP/7ccoSK6SPKEX4n9n2QD0k2?=
 =?us-ascii?Q?63bBgzWox01Ol7QYQStnU2KT+snYM79fRQoSyGBPazeg/jsp2c6C2qgtRhi0?=
 =?us-ascii?Q?k9TFJvEWKLoiO2bt8Wxx4SPep1ydfu7J/p0+Lb3TtRAqKyZuy+3wlWeMkPo0?=
 =?us-ascii?Q?Fi0VRPCUriWrifMXQKAj6dTNmCrsxFjULwFWKcAHee5Un4viWvflrUjeMwj2?=
 =?us-ascii?Q?1Y7a79JTG3sLRTiW23EJ9LGOedFG9JC4IUwlnbnWIDdisl4Is7n2QUvU3kzo?=
 =?us-ascii?Q?3GhmqQ0VIazp+pQ5UR3wzz2PUTOO5EyYPZuixpqZPop6swdnOamuPKWZsQls?=
 =?us-ascii?Q?A7FGuht9NHA404pB/qhUA6JYceyrNoaheIFnVIFb1lR9h/I3WOGroNxbwAbU?=
 =?us-ascii?Q?4JPXF23/SP3xt/S5kCSBbDT94rtP6tjOjUmgutFFlnXboRw4727AdEUbq1ir?=
 =?us-ascii?Q?TiblUU+zc8iU0cITCtbSG3iMlTWN7IS1k1sY8tNQz+lxxOfOcAXPG2bXHytk?=
 =?us-ascii?Q?ihRVcnEqa5nKalYtuVWkLp42lDuJD8L8+xKDlyTWAY7beWE1+kUJ+cYsatlh?=
 =?us-ascii?Q?IAJg/w0smKtF20ppMwtbNAtNIUFBl83Ja+Zdwf7wwnzhuOrmYPMcD1ZH3cAj?=
 =?us-ascii?Q?fBOabRmOkaNnkpmyMOcaEUiFMQvRHuEKOqtrjfzfqt5dQZaJqbbM+AVMRh+M?=
 =?us-ascii?Q?jPFqrcLtwcrpo0uBfxGWec8+vwRQ7PsEVY8psxhBS7i0iE/oDXZyhpmnRkm2?=
 =?us-ascii?Q?YD7gJ/aUcBbfqcp9TYFYTq1SC822y9ZWBNyX0g5BVDPm1pF9lYAjSTOyA7I0?=
 =?us-ascii?Q?y6e8kVA/FyuB6o2DeKBp7kHfk6Lm56w+cUctwdtPHidI04cC4kds+iMdBbWB?=
 =?us-ascii?Q?NsuQJtBhtgJ7jLtj9j4fJKWfY2GcO3HjwvolWOKkzihV4sbzjeBbXsAUowtL?=
 =?us-ascii?Q?QKcZYTbSOhfsEODSj6hVfPsmJMkpI0z/wYyHQS0p30TDgy+H4mMppMYpz/9k?=
 =?us-ascii?Q?crAaJjJLCWTacKjW7xceeNTJktWV7E9G69zvu3a5ZTeapVy5vliawRdm/IVL?=
 =?us-ascii?Q?GQW2n1qxYLBgkpiE2ry+Cze7lqaghECSgJ6BPPdva2Wxw3QtjhAuowF5TEBz?=
 =?us-ascii?Q?XeZeHvMsI8RdbFFO4pdUh96EPFtG8ot30+j5PTBGa5R2RMlL2RM1aNK9p9Nu?=
 =?us-ascii?Q?tQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bb114ed9-2d60-43ae-6774-08db7d9a8886
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 20:58:07.3319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5kXYxw9Rf8UyNh4GKLq3QRUEFAIZtegL+bMRiZERUsOHEg0Ht+SWJvyG+CXceTqZdSmPGEbbCzuUstDzUMZGAy6oNT0RS55acs+/grW/MdU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6831
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Thanks Eric.

On Wed, Jul 05, 2023 at 01:12:05PM -0700, Eric Biggers wrote:
> On Wed, Jul 05, 2023 at 05:40:07PM +0100, Giovanni Cabiddu wrote:
> > The flag CRYPTO_ALG_ALLOCATES_MEMORY indicates that an algorithm might
> > allocate memory in the datapath and therefore sleep.
> > Dm-integrity is filtering out implementations of skcipher algorithms
> > that have this flag set. However, in the same function it does
> > allocations with GFP_KERNEL.
> 
> Which function is the above referring to?  The actual encryption/decryption
> happens in crypt_journal(), and I don't see any memory allocations there.
You are right. I was referring to create_journal() which is allocating
memory right before calling do_crypt().
However, I didn't consider crypt_journal() which might not be allocating
memory before calling do_crypt().

Then we are then back to square one. We need to check how many entries
are present in the scatterlists encrypted by crypt_journal() before
adjusting the meaning of !CRYPTO_ALG_ALLOCATES_MEMORY.

Regards,

-- 
Giovanni