Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp31404879rwd; Thu, 6 Jul 2023 21:50:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlFsAXdcHsfIgu4Z5Ww1LdAKiGzPG+AdAkk/F2Yb+7liyZCS0Kk5aYWVjm7W3VZipYDVCiF9 X-Received: by 2002:a05:6a00:1ca0:b0:681:9fe0:b543 with SMTP id y32-20020a056a001ca000b006819fe0b543mr3996431pfw.2.1688705449562; Thu, 06 Jul 2023 21:50:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688705449; cv=none; d=google.com; s=arc-20160816; b=ADWEZVJ4RFnwEChjTDcUGQpPGAMPqHbRLQq0a7MpUv0xZ7SSUVstt1grAXb5uaOiyq zfNwqohLASkuTalFvGoNPsw6j+QOKXd+jo4hIwttsiG+b2o4/FuYZ0cKKsfFOTjBRDQY VMIk4tmm6uqCfJBFJ6IPv4d7zKLESpg81Mw7rTjwK/8zDVjTabO+3yFg/qwnRJyKLa1r Oc+sGIr9yf3PL2UImX2pULnDbxYTK1SyNVsIOW8+chkYFbTYwfmL5FMjjV0qVProR8fc 5TRGCKEOajcVYcdHr9CndRxETyovaPBIwPQy/SD9RdnW348gVX+TIE7DJfqzIowpHHZf QYaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=TtRR8RTLh3fHkXb/YvU6Dr3c2HDRy2HMFLpoV36fnZA=; fh=WQ95SDK+h7EulRr9v1/NyaLoKNF1ceCLLV3hGz52wSk=; b=L7IonRNZu3ZjUM7N69D2pwq7AjLLjBjD3jEL0wwtOH7qjNVmS3MW8O1DQb7S5wAsbB otLXFqVeBkxDGuitsGp93QDSNkVuO7esZFVEwE/E0wMJT39074pzlnmpsAn2sZc6wp2t Ta7E7klb8p3JcTHZfveMdqM41sFdiSWugjSnyUO5g0MUTUAe5UFt3Sr+HwbcpyM2WXh2 a4X6U8ciprkcRVXXsmpT1QdrykbIcNe07yqW+WfaO9wafnavqVI/PXYVmhk24uGCGHo2 YUTwJCA6mPDAie9xJwRNCZn6UWAOiJtk8xqoGhnzvXZYNF2f253owjARKKUTnhIc2tx8 pvtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bq25-20020a056a000e1900b00674311392f7si2891732pfb.31.2023.07.06.21.50.26; Thu, 06 Jul 2023 21:50:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230415AbjGGEUp (ORCPT + 99 others); Fri, 7 Jul 2023 00:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230022AbjGGEUo (ORCPT ); Fri, 7 Jul 2023 00:20:44 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC6F89E; Thu, 6 Jul 2023 21:20:42 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qHcxI-000ihl-UY; Fri, 07 Jul 2023 14:20:30 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 07 Jul 2023 14:20:21 +1000 Date: Fri, 7 Jul 2023 14:20:21 +1000 From: Herbert Xu To: Dan Carpenter Cc: David Howells , "David S. Miller" , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] KEYS: asymmetric: Fix error codes Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_00,HELO_DYNAMIC_IPADDR2, PDS_RDNS_DYNAMIC_FP,RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS,TVD_RCVD_IP, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Jul 03, 2023 at 05:18:08PM +0300, Dan Carpenter wrote: > These error paths should return the appropriate error codes instead of > returning success. > > Fixes: 63ba4d67594a ("KEYS: asymmetric: Use new crypto interface without scatterlists") > Signed-off-by: Dan Carpenter > --- > crypto/asymmetric_keys/public_key.c | 20 +++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt