Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp31468366rwd; Thu, 6 Jul 2023 23:05:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlHnZRhfxcCOMcFXW/GnGqtFs8kF+2ZOWmkNzxEbSmWWbwdTr1aEt1KPOceRAtMLCTrhG3E1 X-Received: by 2002:a17:902:da92:b0:1b8:35fa:cdcc with SMTP id j18-20020a170902da9200b001b835facdccmr5133290plx.5.1688709911075; Thu, 06 Jul 2023 23:05:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688709911; cv=none; d=google.com; s=arc-20160816; b=yHSv9GjJYTCHCCiOQePVPXcmtl4b2Os7peguM0MrKcteisjj+flcthwSlTbyY/lQvk tZV3iQOXrcUv1D7Jp2ITSHLzRMIHi55dK7Ya7DRGm+k7uzVqv6+9PmJIpbKo0fr4LOFC G1yvttmMhr6PnPpteGLKZNGCxh6HMdbnf2kJvKsLOve8fCd7NathAe2cgJrtYeUNTc3i tkq+QhK7UF44L+3q49UkXPNKFouXcHntXCUzQBM3Jzs8FqkuucxfkaJ0MAjm42qlNyPi kpBcQmS7RL0R++uUnhHA4ws9ysXDbEUwE+O0LSXQNHQdrSYVZJKASede/KieBKlBGGTK yNBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization:dkim-signature; bh=RW78yBHBVifbb508B+Nr2a052QJ90AYozIpUCk7W+5k=; fh=9I90XFYonqkYWYgD+jeM6GegAQv7FNm05wHUTlUx+l8=; b=tRfjI1ZBvRXOdJzE1eOAOkt0RGjwFz/J1AXzEOogq4t6stiQzYrDhkDvAWLMPngNPa 5acROPr9BhfUdRqkVI82R372ryP4bauXxfn/nX2PmT+hFwbE9n5NoszoCU56Xb0c9LDu gT7ROV3nX7ARAdp7CEvyyJzOVW6UteO36wueATAYqzwix0YLoDThfoUaYXo1EjDZxHqd /1Hq87vmwglGB9vljrcNsiTvrcWJqnecyaCe1+wnTLNLrGx4ZxNCAvze8/WX3YpNG4H0 z9rqaWVcZ85ojZYZDfhaVm8AIgGJjdBuHQHfZ+LEKnFwDLJN4wQ6GUyqxyhJij2LVUMQ 6h6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Xj0S8JYe; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a170902d50900b001b8c689061asi2622103plg.421.2023.07.06.23.04.47; Thu, 06 Jul 2023 23:05:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Xj0S8JYe; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229452AbjGGGB7 (ORCPT + 99 others); Fri, 7 Jul 2023 02:01:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjGGGB6 (ORCPT ); Fri, 7 Jul 2023 02:01:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CDBE1FC6 for ; Thu, 6 Jul 2023 23:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688709676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RW78yBHBVifbb508B+Nr2a052QJ90AYozIpUCk7W+5k=; b=Xj0S8JYecXlMi4PgyhMOqonLKHx8cE+IqS6+nYG5doX77prjVQjPtqtKAS4IcyebkL+olx Nt284dHBQtOcTBZKoX61Ev5jco7BFmHrLTjVzv+SWdadJ4uRliCOPTDqzOoPPCYVkIN2nj KIbnFNhu3+yoS2FZFMCE4Loi6/Nw97M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-62-L8ycMmuaOm6Y_LdlEWrHkA-1; Fri, 07 Jul 2023 02:01:11 -0400 X-MC-Unique: L8ycMmuaOm6Y_LdlEWrHkA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F6E7803B25; Fri, 7 Jul 2023 06:01:10 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2F484087C6B; Fri, 7 Jul 2023 06:01:09 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: To: Dan Carpenter Cc: dhowells@redhat.com, Herbert Xu , "David S. Miller" , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] KEYS: asymmetric: Fix error codes MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2210839.1688709669.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Fri, 07 Jul 2023 07:01:09 +0100 Message-ID: <2210840.1688709669@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Dan Carpenter wrote: > These error paths should return the appropriate error codes instead of > returning success. > = > Fixes: 63ba4d67594a ("KEYS: asymmetric: Use new crypto interface without= scatterlists") > Signed-off-by: Dan Carpenter Reviewed-by: David Howells