Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp35842970rwd; Mon, 10 Jul 2023 13:33:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlF/5N4z/wCFhDQkqGYQgj//oEbS482RcqEF48tJTCn9CeFB0i6S0NV5a7rsFNc70nS5mNfg X-Received: by 2002:a17:906:d965:b0:98e:1c4b:10bb with SMTP id rp5-20020a170906d96500b0098e1c4b10bbmr13915895ejb.35.1689021227458; Mon, 10 Jul 2023 13:33:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689021227; cv=none; d=google.com; s=arc-20160816; b=wCtjLenTZLQ1eCRHQ6HiULfEsFGWXOzQTkyTzZs5iePaSpvPjOIJgYAAfRnMGSKih2 rDcscKZjHcR3t8k4Cifx4JP+7RdPmfEnf3B/IxgPKv0lRoX3j06Inpoz+Wy9tU8HhGSI 355vW0Qlie5Xw9KV1VX30+0VE6p1INOE6IlSQNFzt9B6X8KHRY8EPn5lyeE61GioBZQc c3rfGqqPvZE/txfh+u2dBaR038vM9Bjz+EWleYg8W5ffT9CUANgYwQEDODoJLyN+zR7F VLOyrHhHJDB7/Fdz1G/8DgOQdxnvRXlGvKRgYDlZGPbnAdefi7C2opkRLcD7wPI/NH7L P43Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=NGagndghDOkiNn3CGVhgbcZSeOY+UYy66oNmW3rStuk=; fh=GUQwZ7uCW3sOebrGSFJwPRX8di32vmIzxh/oFyyWwpA=; b=YkC6MalyLgYzcRGxT0ZXXX+3W/DeADtbLMHAtoj9TJnHZkJqG7Pws/k3COs3wtsvuu fPBijqEVZdDddCHNHrOXGzuAJsDDTyUBSCZQM5J8WWnkrzRq8WaKw3ZlaXJCwP+nnpOO r9GbQHEEHZuBqLJi6ZKyz99n6K8j+HDIPZB98oNPWaqfP0kYOmfENfIoz1W31pacuaaA CamZByE5zikF+BMCIsMkWEzSUJbXfNTBFbGw+xnHmLwcdvGEIaX9Qox10jLfgreluzWm oWMeceizs/2I/Yh8Zfpe7gx/07HpDMIusNoWOffttPYGjUEa+S+MZ3Kfwi53cq5aXiGL XN5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g20-20020a1709063b1400b00991ece4c961si340924ejf.267.2023.07.10.13.33.22; Mon, 10 Jul 2023 13:33:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230273AbjGJU3i (ORCPT + 99 others); Mon, 10 Jul 2023 16:29:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230406AbjGJU3e (ORCPT ); Mon, 10 Jul 2023 16:29:34 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2642195; Mon, 10 Jul 2023 13:29:29 -0700 (PDT) Received: from 250.57.4.146.static.wline.lns.sme.cust.swisscom.ch ([146.4.57.250] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1qIxVf-0002mg-1g; Mon, 10 Jul 2023 22:29:27 +0200 From: Martin Kaiser To: Herbert Xu Cc: aric.pzqi@ingenic.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 3/7] hwrng: ingenic - remove dead assignments Date: Mon, 10 Jul 2023 22:27:29 +0200 Message-Id: <20230710202733.116133-4-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230710202733.116133-1-martin@kaiser.cx> References: <20230710202733.116133-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Don't assign a value to ret if we're about to return from the probe function and ret's value is not used. Signed-off-by: Martin Kaiser --- drivers/char/hw_random/ingenic-trng.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/hw_random/ingenic-trng.c b/drivers/char/hw_random/ingenic-trng.c index 64286cbdf158..bfec28ceab00 100644 --- a/drivers/char/hw_random/ingenic-trng.c +++ b/drivers/char/hw_random/ingenic-trng.c @@ -86,13 +86,11 @@ static int ingenic_trng_probe(struct platform_device *pdev) trng->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(trng->base)) { pr_err("%s: Failed to map DTRNG registers\n", __func__); - ret = PTR_ERR(trng->base); return PTR_ERR(trng->base); } trng->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(trng->clk)) { - ret = PTR_ERR(trng->clk); pr_crit("%s: Cannot get DTRNG clock\n", __func__); return PTR_ERR(trng->clk); } -- 2.30.2