Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2180921rwp; Fri, 14 Jul 2023 01:59:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlEhbt5W43IeFg3y08tCBl/zehjwJrUzg68jqfStjOxqwia0CQrJv4hjsApQ4sJ+oMdHjqyP X-Received: by 2002:a17:903:428d:b0:1b2:48c:4db with SMTP id ju13-20020a170903428d00b001b2048c04dbmr2765861plb.38.1689325156153; Fri, 14 Jul 2023 01:59:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689325156; cv=none; d=google.com; s=arc-20160816; b=ET+DiT95571snm2suHKX6ZtKJ/gZeZVoAL19IAJzw5slLKiQw7I33wddcTVoEP8XtS L8hSQZgKA4iWwzbapczc9T/2axCA79Poo/WwH/YCyVa8e9LDbi3X7s/C8tsAiQNo5Tex Gx1sGk/hBFhat0JGr1z9I5/QNJhvcnyQ0NJfEne95qH0Y4qjQ2NGSRmApWR9wgDIBI0u 0t2osFeYNpFVYkDwGqWc6ZB8ugfbpifc7u14o6Fyr336lKKpR+vi1EtL2hxYlmS3iAJI /8Asffwqk5Cey2kJ6fNgfch9vx/SLfqjY2/3BAhtCzXRRPSJCEoqRz1vDmaelH15zYL6 CHKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=qVaYL/QZ6pWmzTNt1YDXppM85piAsHkZgtSI2lxaBUY=; fh=X2R8T/xmQg0JqGiC7+CqXd7ltA5MVtyUxbvx2If+yEQ=; b=Y+uiz9momUf5D5/7ZqDx8jsUOxAFyStp6mTRv1XhyUgIksLbBCtng8pA/9ULnKcqqL UPyrjqM9BMNL1Ajg1txHAK1P78xpRO9YA2XxJCmYSQMicL8d+d2YDq1SwVCo9Qpn0m9W gNlDIrYxqp0dpWLDnfdVTHSFZKFqnMmO/9SSB2U6m2cN4V0yjXGqPLt6mhZPQPEFOLOw p+xuVTg0HbRbqDCeBG5mb9SMrG+0HBnL/ig1++MoTblpozIY7QhMYQ0uXwzkgQRueq2Y ivnljYjhHtiL3mZcjBU8qUaz1rfSkoDFled8Kiy6ZTwszuZ/UwkTpZXhUEKvo17QMuC4 4X8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j4-20020a170903028400b001b8ae69289dsi6959499plr.539.2023.07.14.01.59.01; Fri, 14 Jul 2023 01:59:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235809AbjGNIxL (ORCPT + 99 others); Fri, 14 Jul 2023 04:53:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235727AbjGNIw4 (ORCPT ); Fri, 14 Jul 2023 04:52:56 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B443C1FC8; Fri, 14 Jul 2023 01:52:55 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qKEXd-001Rdy-Ls; Fri, 14 Jul 2023 18:52:46 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 14 Jul 2023 18:52:38 +1000 Date: Fri, 14 Jul 2023 18:52:38 +1000 From: Herbert Xu To: Mahmoud Adam Cc: dhowells@redhat.com, davem@davemloft.net, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] KEYS: use kfree_sensitive with key Message-ID: References: <20230622124719.93393-1-mngyadam@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230622124719.93393-1-mngyadam@amazon.com> X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_00,HELO_DYNAMIC_IPADDR2, RCVD_IN_DNSWL_BLOCKED,RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS,TVD_RCVD_IP, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Jun 22, 2023 at 12:47:22PM +0000, Mahmoud Adam wrote: > key might contain private part of the key, so better use > kfree_sensitive to free it > --- > v1: conflicts with c3d03e8e35e0: > KEYS: asymmetric: Copy sig and digest in public_key_verify_signature() > kfree_sensitive the buf variable also because it might has private > part > > crypto/asymmetric_keys/public_key.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt