Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2187522rwp; Fri, 14 Jul 2023 02:05:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlGHpqdXL4IwkUbd4/I0nvYtuHMnVsAxcs4ioo4Aj8m/vqWQom/9QmC8dvC25ouTlVpLuYVS X-Received: by 2002:a17:903:2345:b0:1b5:5fd2:4d6e with SMTP id c5-20020a170903234500b001b55fd24d6emr4783826plh.58.1689325542119; Fri, 14 Jul 2023 02:05:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689325542; cv=none; d=google.com; s=arc-20160816; b=spkfwDpJJMdLx7Z5LK2BT7xgFEfDzz90BBXOyjaJtiCeyfPKBMaoL94NRegmY8Ejn7 2Y0bQzHifqiVMXPSl2sHBwiWzQ/fK2C6XAAO4YNs3lxnRk0CeGm5vUTbqSmrcGpl+9pa THTuSKhJBffNGxphMVaoDMAEy3jSiiVkBupfGnVG+ONR3NY5geAaXYyrEE7fV/3f6rab YVJHl6INAD1+c9ePlULg19wnoiUmvpHYxdDcuH2os9MlXi2xcIahB3RK2EgOCMjk+4Bk FpDwgpVenDEuL8NDhLqETr+ra2dMtx+R4xAh1IsY+RydUREzPhJ1FK+oImcvduEypq1M caNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=PzwbdfeGMKnU/RQWQlCy54ZTFVf5YfLD2BhP/AGimZc=; fh=WD2iHBjV3HGWwrur80dQ5OqFJg3z61Z4xoquh+7nxuE=; b=eCBYFZ/QzXK8fXy18Aq6Dc1Evxb41iVI32q1HUESh+YzQSv9T/pHrGU4uk5Bwrzlhe xPmbkjADX2musUYa+yOTVXXF38ZtK4+nV9NfXrUHZ4Zo7uos3FT7HV3WOe3+jWAEm2yU J/Oplb9c7qsTKvonVMO8IcLufo3XMO3mSuS/JDhoHVEdv3cYC4GHTDvGveM4a4HfOacQ xY2446eTqMU/mKSvWj+Jds3z7xqArxwNqbG11ec3n3m0++EeljGupuITRC0spcrd5jaC lqeJGDNNtzK+0IDOeR8YQQeEZ67Jhdc4JvQR+onAIT/KrMEsrx0XCCz3qwlsydA/aXPY cBdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a170902e5cb00b001b3c7e6a8c0si7317427plf.531.2023.07.14.02.05.28; Fri, 14 Jul 2023 02:05:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235359AbjGNI45 (ORCPT + 99 others); Fri, 14 Jul 2023 04:56:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235300AbjGNI44 (ORCPT ); Fri, 14 Jul 2023 04:56:56 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D8D026B2; Fri, 14 Jul 2023 01:56:56 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qKEbT-001Rgr-2s; Fri, 14 Jul 2023 18:56:44 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 14 Jul 2023 18:56:36 +1000 Date: Fri, 14 Jul 2023 18:56:36 +1000 From: Herbert Xu To: Martin Kaiser Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] hwrng: nomadik - two simple cleanups Message-ID: References: <20230702173503.163152-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230702173503.163152-1-martin@kaiser.cx> X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_00,HELO_DYNAMIC_IPADDR2, RCVD_IN_DNSWL_BLOCKED,RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS,TVD_RCVD_IP, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Jul 02, 2023 at 07:35:01PM +0200, Martin Kaiser wrote: > Use devm_clk_get_enabled to fix a (theoretical) race condition during removal. > Call dev_error_probe to print an error message and exit. > > Both changes were compile-tested only, I don't have this hardware. > > Martin Kaiser (2): > hwrng: nomadik - keep clock enabled while hwrng is registered > hwrng: nomadik - use dev_err_probe > > drivers/char/hw_random/nomadik-rng.c | 19 +++++-------------- > 1 file changed, 5 insertions(+), 14 deletions(-) > > -- > 2.30.2 All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt