Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2190200rwp; Fri, 14 Jul 2023 02:08:25 -0700 (PDT) X-Google-Smtp-Source: APBJJlGc0HL6Apo9iE5RMAI56uoRTMvRBOV6tMDjwt39ChpgYtr1PpP6sWul+i+aqLVXdKdPvSH9 X-Received: by 2002:a05:6a00:130d:b0:678:5629:fd43 with SMTP id j13-20020a056a00130d00b006785629fd43mr3524067pfu.9.1689325705557; Fri, 14 Jul 2023 02:08:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689325705; cv=none; d=google.com; s=arc-20160816; b=F3uiABjbxPii52rjwJz0RVDe9vJeD9fu+itBw5CzZfVxcht39KJb/Ss0p120UmCNSz XVY0CDbsXTp21ZW824m2miFq84i7X+j1x3xlqFcfuwgEmEt6I41J6pagZzPwcxNU9Dvd 6d8Gpu72iLzX5Tu2owqrA6KekMzZeLILK2KdbOdVknuoarmcbjl3CflM+QgYJFDLg3YG IS3v30Uzd5m7FOZ3M7rIOmbb2PXD3Dj8XfB8tdiL27vquFG6h+I7fa5jKEvJx+Uw1B5m AG6l0jQ9AyqIFccEyr7fRWD8IRbpzlyKQOVEWTOXjMZVajANyZMivy1CVvwkNN2+1veP sluQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=/0rgBgBHAaVZQ+8HDCzDCJASXSec1Sk2v8xdqRgGQ6M=; fh=WD2iHBjV3HGWwrur80dQ5OqFJg3z61Z4xoquh+7nxuE=; b=cfgoMLZlbThHs5y31vzw0bWhnuVqZj7oNTMulPXT4a3c+x6DhEd7YWTptdIuJhO1tV pWxBUUXb5TNXTk7L6p4YMfyXsMEPT9AOxC53bl9Vj49HZeKKvCZ7/LClKjZdrkG8ROOy KyUvJylzXi/9MkJOrFriXxHrtSqaHCefpTRkaDozRS8lTaZowVNT39P+NVZ+UWYaLk37 FJgIqrVKLWaVsSA2U0Thlp3Xm7SdZDAdVHrxjlAdyREmMDlWxQ+cJTOuo3TM4SeHVheI g7VayNUUX0qdS3PE3fOQjQ4fk4bEpBHjCtZ+VhYKciBw9G6eRLh/gLG0sZr3jw1pVGCA a2uQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n10-20020a635c4a000000b0055c5be17068si6438337pgm.751.2023.07.14.02.08.12; Fri, 14 Jul 2023 02:08:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235713AbjGNI6W (ORCPT + 99 others); Fri, 14 Jul 2023 04:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235717AbjGNI6V (ORCPT ); Fri, 14 Jul 2023 04:58:21 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98AF02713; Fri, 14 Jul 2023 01:58:20 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qKEcw-001RhJ-1C; Fri, 14 Jul 2023 18:58:15 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 14 Jul 2023 18:58:07 +1000 Date: Fri, 14 Jul 2023 18:58:07 +1000 From: Herbert Xu To: Martin Kaiser Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwrng: imx-rngc - use dev_err_probe Message-ID: References: <20230704170644.69669-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704170644.69669-1-martin@kaiser.cx> X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_00,HELO_DYNAMIC_IPADDR2, RCVD_IN_DNSWL_BLOCKED,RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS,TVD_RCVD_IP, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jul 04, 2023 at 07:06:44PM +0200, Martin Kaiser wrote: > Simplify the code by calling dev_err_probe instead of dev_err and return. > > While at it, use the same device for all error messages. > > Signed-off-by: Martin Kaiser > --- > drivers/char/hw_random/imx-rngc.c | 24 ++++++++---------------- > 1 file changed, 8 insertions(+), 16 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt