Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        linux-crypto@vger.kernel.org (open list:CRYPTO API),
        linux-s390@vger.kernel.org (open list:S390 ARCHITECTURE),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] s390/crypto: use kfree_sensitive in _free_kb_keybuf()
Date:   Mon, 17 Jul 2023 15:41:12 +0800
Message-Id: <20230717074112.6580-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8ua7Bbjs+fa7pulPgOEvDuXS56ERQUHApJxluf1s/O15nPMGmR7Zg0f+jjC1?=
 =?us-ascii?Q?nPaqQxInopzusZ/G1nhih9II09ax925JHkTsU5QaYOBlk78uSlaVaBjjI8TU?=
 =?us-ascii?Q?i1zD+dbCIgZzRJncKV7n2VeIzIR9gUfQffRRg+KWMbvP2ThOBK3nhXlyTPoy?=
 =?us-ascii?Q?Isp0Ime/v1Tkx4hTNrZiXFduMmdMkYgasAVTnOiJoLkH3CEdfLnXj+YQ9sVh?=
 =?us-ascii?Q?MLePRAlmBkz0+qO74vXTLwX9XAmp+UpixSJt0vJGF2Z2PQQpVuWLnCeRnWt4?=
 =?us-ascii?Q?XQ35hGGdSrYHGpZAaQuEEdNRpFCXgA+Jo8WEGqXujlN8jZbFaoSr4cs7Yrun?=
 =?us-ascii?Q?nO5VJF7H2vvfsqA/qec24lSRbUYWCEWRYs17m6EjJaLqFk8wPQ6f7wq3lZ/D?=
 =?us-ascii?Q?p/S6vWktmqb06sRqYl9DDPeiiqTz8/eeZQsDtq/bq03DLkRLH/a6cXKFKrx5?=
 =?us-ascii?Q?y+Gq71EAkISOyi10iytdpRuNWYDTCfQWK5WicpHSeQIbUugfzlTzeFGxMbw+?=
 =?us-ascii?Q?FBR8GK7fYzRUMdUsK5IjO/S1ym/siN2rZo3JLF0SKTdWknFar94HKH0xi72S?=
 =?us-ascii?Q?Sln/le56V1/Q7bgyYs6Q2SAraCQ8erwhwWb/UqlBOBEl+JuEvaFgWi4ZmbaN?=
 =?us-ascii?Q?YI9y7xVsPD+VGSD82KQakU9o/JLfe8Ek+OA7U/fPAHBnbkWs+BzRCB++oNXa?=
 =?us-ascii?Q?3wUhEGRjN0Mp0x5+E+H0MMRcmQoZh/zgPS/zgbWRnoOevRrhOUXU7zferp+G?=
 =?us-ascii?Q?J+kW9dNHU2S+YFRS3CLvPdP6x/xrgK4ZxPMm7SenVlY68HW+6btMhb78LX3m?=
 =?us-ascii?Q?eobv3izMD7nVzWVjnDjDTHSE3Wk+CO35b3YwSMHbNAUEU0zEF4WXUmuDN1JT?=
 =?us-ascii?Q?K4HfYlAGs3x5a0McpY5Mwab5sdZWb3xsutX75qWP6W6lyWQErMiH3HVPODq9?=
 =?us-ascii?Q?YOZiYq1NdPPGxQ0MLKuQiW+59mHu1LiLlp+QKruN/MqcXo4IsCzW/rkrZkNW?=
 =?us-ascii?Q?cuIyT3uCulXGIQK4/dpdUTrgMa+w54Tg5Jiw03sO5IXUG42/hjiFKR0Pw37y?=
 =?us-ascii?Q?Q6y/xsEGpcbaUt44LHn5qb7gez8Xb30QNilPndRRsoZC34gQLnPJKKUQU9ZN?=
 =?us-ascii?Q?DnGpJ9oS1cu/zLdh2xDyw/GWqaGYr2jjUgP8RrSQTXmepFjB8U/kFdmrpldY?=
 =?us-ascii?Q?ESK3zM8T12qFyAHwdrfXY2dRMn0F6Vno4NY1pbPL5eQ4K+I1zrWgegH4BrgN?=
 =?us-ascii?Q?gA2xD47m9FYbeE4MKnO/QPqVPADPTf4Mo3TqmXuJpE11/X0k1E2aBEtgTx+x?=
 =?us-ascii?Q?1MidbfSA99jbMMIzmpYNFfVjLjRWyYEG8GwwjnTM31zygZDZcjPZEV1DZsBL?=
 =?us-ascii?Q?Qym0nGpV6xOyZqe6sV2ffzzB4CGmkhp1YuXsE0ZcYeehFs1nUePMadAHZP3I?=
 =?us-ascii?Q?6/CrLpQehMOxbmd3dNFLX0MdAqMxVt5Dvz9ZMz5m3g8OGYAIA5G/n2F5zR4g?=
 =?us-ascii?Q?Zq8gVpQPDJ9I41VsUcXzHYvnB6R+jrhS3uV64+clc083miIn1ThBdNoPcgOg?=
 =?us-ascii?Q?Ku/dEqh45BE8UNZ/qrJPr1pUPoSAIgLTCFdUzd1J?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33b7fde7-cc43-48fc-33ad-08db8699530c
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 07:42:08.7077
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: toHQTy0DRfZrtYMYm95ZId3o8aG6Dj9dv9+i+gdc0U568U3gTzNgwiZ4yfgMuunFPcGunAV/Cn0dtXUzt/Vj/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6482
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

key might contain private part of the key, so better use
kfree_sensitive to free it.


Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 arch/s390/crypto/paes_s390.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/crypto/paes_s390.c b/arch/s390/crypto/paes_s390.c
index d29a9d908..38349150c 100644
--- a/arch/s390/crypto/paes_s390.c
+++ b/arch/s390/crypto/paes_s390.c
@@ -103,7 +103,7 @@ static inline void _free_kb_keybuf(struct key_blob *kb)
 {
 	if (kb->key && kb->key != kb->keybuf
 	    && kb->keylen > sizeof(kb->keybuf)) {
-		kfree(kb->key);
+		kfree_sensitive(kb->key);
 		kb->key = NULL;
 	}
 }
-- 
2.39.0