Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        linux-crypto@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] arch: s390: Use kfree_sensitive instead of kfree
Date:   Mon, 17 Jul 2023 17:45:19 +0800
Message-Id: <20230717094533.18418-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rdaMsDGKpokxV3I/lcz7Nmy2hyfysmErfEE8S6myb4sadXoi+Yi74CCyc4ns?=
 =?us-ascii?Q?vN+PGoCIo4LY2Y5BFHl1NAu6UBd65ItET3OeOMObS5cAqUNHTEVK78CnX7Om?=
 =?us-ascii?Q?6IqrXBfjcr7huw1hvnrxoqT++LSHWidDTt8QG7tueeD+tvlbmgzaXdJINTfW?=
 =?us-ascii?Q?GFLPsidIE2Z1JR4z/rmNUj9lgdk8yQa9WbRre4YuyRpJmhOu6OOidsGgjCRs?=
 =?us-ascii?Q?X4J5nMiCfuG13ELbPRugXdsEHdJWmgKiBC5Bd3V24vs5ZFTTQao0TBUIDTIc?=
 =?us-ascii?Q?4/ejuzXzHcxJKxRwJjluK4bMYdKgImnXIeMcwKqoJ6BjyyiqOsVNGuMspGuw?=
 =?us-ascii?Q?xv4DqMuvCAbcBKFXkeU49AVCJlhwh2Bqu7Wf1+y8s0FtrypgTKU9kqqkWT3w?=
 =?us-ascii?Q?neCO8awhHM2p8Pu9hXDp0gNoQE9X3Y1ME0pP0rrf31MpV/GovwG9ntT2LGh3?=
 =?us-ascii?Q?bmJlvIZsPoXzC97N3craW302Ff6p0rr7k/wMUob+aXwSptOUAhDxieCIZXfa?=
 =?us-ascii?Q?LRIN3C6chFG/8W3Ew18nVOqLPBh5/wNcPfbGTPkGwFUaspIE1+8Oz+zYKGHi?=
 =?us-ascii?Q?BySgRK4lyssaG6t4M36wXFQlUJfEBeAXtm5plqppK8vpq3hM/ZhSSDaUlqAu?=
 =?us-ascii?Q?jdRQ2bHHuKsiHmht1udQawQcvwy1vcLLiNri4ChkPD885m0xjo+4cYKW6+jp?=
 =?us-ascii?Q?q1NU+xsexBijyeBDne2JU4wIOSv3AX6E0feVEMy68fTW5n4FAoW+ROq3TSWN?=
 =?us-ascii?Q?lXCUwiIpMtueXH9YdK1tugdwg3pPT6194752UQmZZYJWRVcxHzyjJ8A/ntTK?=
 =?us-ascii?Q?M0jnsf1kDfyttQgRDeWLHTBnVB+MCLG/QRbzCAGlyJpKZtmK9LUPzBP5Uzw6?=
 =?us-ascii?Q?vBGbW6ivc4OprC7092hiWkfBoIdYuGsiHa87/TZVN83/zUbEoEb1ejSQ0PH0?=
 =?us-ascii?Q?ANeRm0zkZk8y/e3XdMBwa/DcDbrC0/wlMqym0pRdfUOdMLVbGcdRVqaaKe0g?=
 =?us-ascii?Q?19cV8aAMMJrfM7GRElsjeEWxUos6BZ/ACCgtlJMS8DFTUArCOffw+28RfkQS?=
 =?us-ascii?Q?gkYpoYQhtBPqcGkL79LSs6HsapI3AgcEArEH5m7n7iaZJdS9zm4Lz3nANmJP?=
 =?us-ascii?Q?VeaTlJDKzar929mMxGYW4aLJAqPyj5X22BMQp49Vowm88W6fhncAmZU+RsMu?=
 =?us-ascii?Q?JKkP5WxIH66pYXvbFOhC9EN8KFdSHLzqAKxfIB0KBEO2F7lLf4Ji35iM9LyU?=
 =?us-ascii?Q?y8gqySGemYFKUJSf3zt6qh0/s2zlefTvlh7lDWZQpJFfYg5M8c/7VQrQKwpI?=
 =?us-ascii?Q?fIi8Rrcui1bAfWmi+9Sum1buQvpq/4aEvVvlmD81mwrOVm7uca7+GalWgmhM?=
 =?us-ascii?Q?NNQMnUVALurTnp/KMMUPOa0nMvGeHoTAGWpGeRL3fF2WV5Bp92P8HVnmsaMN?=
 =?us-ascii?Q?7ayLDY9mMxg7Fz0Xalx7BYo4Kzbnls2boWPK+WFsFK8h9rm947mrZrrgKAr8?=
 =?us-ascii?Q?h7Cwhr24nuLmWPZawh1BhK5Q7OV6f3dOcCmxcwG50WlB5bEoUYzycoGgOrzW?=
 =?us-ascii?Q?S0qXWoY1l/B2ZsumlPVlXYr1DPKKusikPw7jVDeX?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a035b591-e75e-4073-72ec-08db86aa9ad5
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 09:45:51.1776
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2/QMi4luglGsj4NUJUcdvkw/mXbraSbyVda8QX7bgZA7jz6GuyN+sWsvtCpy5XUJ+/TAjlBThNXjBTUeh+Wx8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5002
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

key might contain private part of the key, so better use
kfree_sensitive to free it.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 arch/s390/crypto/paes_s390.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/crypto/paes_s390.c b/arch/s390/crypto/paes_s390.c
index d29a9d908797..38349150c96e 100644
--- a/arch/s390/crypto/paes_s390.c
+++ b/arch/s390/crypto/paes_s390.c
@@ -103,7 +103,7 @@ static inline void _free_kb_keybuf(struct key_blob *kb)
 {
 	if (kb->key && kb->key != kb->keybuf
 	    && kb->keylen > sizeof(kb->keybuf)) {
-		kfree(kb->key);
+		kfree_sensitive(kb->key);
 		kb->key = NULL;
 	}
 }
-- 
2.25.1