Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <06bbe95c-118a-0e19-3480-49fc42f3dcb0@nxp.com>
Date:   Mon, 17 Jul 2023 20:08:30 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] caam: init-clk based on caam-page0-access
To:     Pankaj Gupta <pankaj.gupta@nxp.com>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Iuliana Prodan <iuliana.prodan@nxp.com>
Cc:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
References: <20230710053418.2406915-1-pankaj.gupta@nxp.com>
Content-Language: en-US
From:   =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>
In-Reply-To: <20230710053418.2406915-1-pankaj.gupta@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkJ5RnlGWFI3OHBWVlp3SGN6OXY2STJqSmR2M1ZOSkdVZmxFaTBKc2lVY3VH?=
 =?utf-8?B?R2JMSkJDblovY2pPdnpsYWRoNjdxZVl1TThwRGxMVDVJUDdoRXpTekM5czQ4?=
 =?utf-8?B?OStkWnhGYVg5ZWhmVWVZb0JQSHhaWTFHcHVEMThvMXI2KzJjb2xhVWYyQy9j?=
 =?utf-8?B?ZXNFbStrWjFDSW9Pcmc1RWVUazNhWjdsS3JtbjlvVlRndUdqeERLayt2L0F1?=
 =?utf-8?B?TUZ4Rkk3WUNQMzZzWFBNUE95YjJ1KzdNMnVZZmdsUVhNT0FVcWVqZWdXeTZZ?=
 =?utf-8?B?TllCZkVJVXFsS2txdG1BRG1ERy94YzBDaXEwdTAwZDk4UEdnRmFGVjdiT0E4?=
 =?utf-8?B?YTZFMGQvNFY5cERBZGl0VVNyVWwwQWtXcVVJWFNsVUhka3pWRXhJUDllcG5s?=
 =?utf-8?B?ZFlwZXB6blBma1p2aWYxaWpwWWt3TDNQMGRkNFhBejBDTXFXY280dTF3OFlu?=
 =?utf-8?B?dlZYWGMrNmJvVTNJUzhLOFBZWXZOSDdlN1R5MGNvbTZuNUhPZkRkWm0vak1l?=
 =?utf-8?B?NEE2TGRXeCtBNm1MT3lEVU1mUFhoQUNHZ3NnRmM2dVYyRVg2MFNkc2ZSL0tk?=
 =?utf-8?B?cTRpNEVEQUU3VGErTWhMWkNvUWJ3YTN4M1UreWM3TzZMOVlZZFdDUjFjZnpW?=
 =?utf-8?B?OGNCelhhWW5mVUVWODRXM0dJTGV0S2Y4dUhQMmhOcldQRklJd1hiT1Z3YzBI?=
 =?utf-8?B?eEhLbHlYVHNmT3NqWi9jZVN2QlBxNkQ3dEkrWnFsL2cyRnlwYys2RVRQUnhL?=
 =?utf-8?B?MW9Ea1ZVMWs0QndtYythL3RSakszRWY4UkhVV1BUdzkyYng4cm5UemFOaGZx?=
 =?utf-8?B?RGxUckdwRXFvem5XNXJPUEVIRENkZ3J1cmN4UTJuRVRLUnVvSzY1NmN5eGNZ?=
 =?utf-8?B?TWJCaitzQXJzc3dNVjNXdXVaWGZGTWZTUGF1bTMrajlRNmlvRDZIUTlOY1Y3?=
 =?utf-8?B?RFNHWXdoTmt3cytWMUUrcWdKTkpaQWh6aHdLUVV0VG1SbVZKcHdidTFEZVdx?=
 =?utf-8?B?N1RwdzZFQTlJTFJoQWtXZkdsUVNZUHBKQVJVbDFNVEpqMXhQOXhPN2lZZmR6?=
 =?utf-8?B?T1gxVHA3aGU4WWtNbW9uWXhjVzJmUUFLdnRxV3N3MWtrNk1lTklRUGRETHdv?=
 =?utf-8?B?VmNQbllrZVNJMTNsWnNmZVVqa3V5M1lWUnovYzZsc3MxK1p4dVJyNFd4Mkh6?=
 =?utf-8?B?Vlk1SXNZbVl6bDAwOFBGbG5KRXdzblZIQzdhUC8wclZkN2k1c3h2aVpvVHla?=
 =?utf-8?B?RE1NMEUrSW5QRHAzVWJYckRUZ1NSRy8xWFZvNmdROUZ0SDJPaWx6Slp6R2t2?=
 =?utf-8?B?WW9WQmpOZDRlaDNEa3hOc0trWjhtWXBhUnNhZWI1dngwbWZUZVEvZi9uVUJh?=
 =?utf-8?B?Vlk1S0lucXlrYTFmaHkvelFML0FESzdSWDVFU0NCOVBXZHJaUVY1cGZWd0hi?=
 =?utf-8?B?T090WkJWSVhvMElmRTVaTWNoRWJyWGk2Mk9IdUUxZ2xJYmtIcUNmeEpiZjNm?=
 =?utf-8?B?UTdwUUpaMVc2SFhDRTNOK1RyRjk0TlJrTXcyZUNqQnJOTk1GbzJJUGlDM01v?=
 =?utf-8?B?UHI4bmk0Z3FSVXpRSVFWR2cyekJvNXhneE1FNGFrS1RBU0xuWEduV3RZZ2Fh?=
 =?utf-8?B?K042a3dpZmpHMnZUZUZvOE5WbmVnQ3pPMmtOdmY0UGFYeVpVQkZQQWdaNFAv?=
 =?utf-8?B?aWF4RFowWUt0SHEvd2lxRzBrWTA1YmRhYTEwcWVaQVpodFZHZlovYzlDMlpX?=
 =?utf-8?B?QzFSemNIM3pCS2pZVi9HejJ1Qmp6MkVKR052QjgwZEljUEk1RzNmTEd5U0p0?=
 =?utf-8?B?Y2hFYXlKUm9VU1Z4dnA5YktGbVkxc2x2aHVMTmpKTWlDVExXUUZaZ0ROVkFQ?=
 =?utf-8?B?Z3kwSW91b0ZBTk5pL3NWTE90ZUIrdzVXRXBHUTR2Si93SWVkSElvZFJFOWQ1?=
 =?utf-8?B?S2Jzeis4SmhFWEM5SWlmVU1JTHpHalluOVg0WklFaDJpNjRoTUM5VzZoeEU5?=
 =?utf-8?B?YjJnU3Nxdm1Tb2VmSWxEa0NDSk02WGR6bDNVM0pITU4rWkZGVEpJRVpRREZm?=
 =?utf-8?B?em5wb1REWVg5U1RGNkpqSUtabnRtdHVPMUlhU0NpZjFsWGxHSXdvSUlUZlo3?=
 =?utf-8?Q?Jhw+8IFvkfGH/paIbyhODaqWk?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51fdf632-1a25-453f-648b-08db86e872f8
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3875.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 17:08:32.4143
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CibVioUCfKAMbcVqSGdB6gVlj7vZR+vJcWC8hE8Yp/P2pRJFzgFxSt8eeAPm+2GKvtNOJVoidV25LBfS5WOX/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7914
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 7/10/2023 8:34 AM, Pankaj Gupta wrote:
> CAAM clock initialization to be done based on, soc specific
> info stored in struct caam_imx_data:
> - caam-page0-access flag
> - num_clks
> 
Any specific reason for deviating from downstream implementation
(based on DT)?
https://github.com/nxp-imx/linux-imx/blob/lf-6.1.1-1.0.1/drivers/crypto/caam/ctrl.c#L911

Thanks,
Horia