Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 12:07:48 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Eric Biggers <ebiggers@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Haren Myneni <haren@us.ibm.com>,
        Nick Terrell <terrelln@fb.com>,
        Minchan Kim <minchan@kernel.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Jens Axboe <axboe@kernel.dk>,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
        Richard Weinberger <richard@nod.at>,
        David Ahern <dsahern@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Steffen Klassert <steffen.klassert@secunet.com>,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        qat-linux@intel.com, linuxppc-dev@lists.ozlabs.org,
        linux-mtd@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 19/21] crypto: remove obsolete 'comp' compression API
Message-ID: <ZLpnBN5zMuWlGFoh@corigine.com>
References: <20230718125847.3869700-1-ardb@kernel.org>
 <20230718125847.3869700-20-ardb@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230718125847.3869700-20-ardb@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KID24e69QFUyrZSpFz2oLXssfr9pGxI1fxYj5o4aNs4Dm7q+oSCXEY+eXWly?=
 =?us-ascii?Q?v5MPrf09l8EUZimCXKv3Cda3Xo3WoM1atSaaGeCfXMr5KacoElo/yvDHdj3Z?=
 =?us-ascii?Q?9e3Qxb0qR/b5oRkppaDUlRYL7TuWvjUviEUgrzmmR0Yyek7zmQTGl85ZthYd?=
 =?us-ascii?Q?qNebq518o56+LQ4KMJu1ek9YZ1rUI4j9+CKWKlMZSB9LNFX/KGaDae6Fr/pr?=
 =?us-ascii?Q?qBZcZX6q85+SKWg6UfoFdPgIRB1uVZElfxylPsDmTyyYKulLamR1lSx6pSoi?=
 =?us-ascii?Q?xBxRVPuAmrBSlPhO2rxNKVIfqlO90jMc2kilLR3/GCDArJaXojRL/r5wPt2J?=
 =?us-ascii?Q?rI9AF/hfgIRQrBAnVeAZktgBxgTrTMR+EtH/3KG0/GNNEfxraE5hFeM3FulT?=
 =?us-ascii?Q?u+wzc0UU3+aZYrYL4xQH3A2gbCAnOayQc6hw7VszQJxcbvyGZnfLZwzXdB/Y?=
 =?us-ascii?Q?NIa3JtoZcbwWraAZpe8Vkt6HJwFsYwKHX7teM51cV1CiVwOI47+c0Gqm6tv4?=
 =?us-ascii?Q?JFldYmQm0c52/x/M/Jm9X4B8TUePToZL48+et1fcSRr70/HqIJJaHikDHFrP?=
 =?us-ascii?Q?098k8pwyKXQkKVE8XBaALzJlVFtTo8k2bOdq0dhT1S/yoCY68qJlIeDyG1/H?=
 =?us-ascii?Q?rXo+MxhyQEoR9iNxHmaVwfRe/mBzss/Cs4PQEPl+PChlQtwFeRgOzVajagNS?=
 =?us-ascii?Q?g7d1AUEGEIf/L4oajkGmgfMUcQSFLE6kMaMwR0ixseQc8LPC2Rj+psdQn42T?=
 =?us-ascii?Q?IVq7P3hnqo8rCIcu6lC36/480D237O5hoserYt8MRwmRxO/vJgDtJ4/Rd5Ss?=
 =?us-ascii?Q?nYGysd5aT6ozr/1fKK24RzIj7Gp9Ae0lZBOsVCqsOYDrZx+AtdtAQl+J3eqI?=
 =?us-ascii?Q?BLxITQHILs3W/MjJsUC1J75p4Dm9TVAXk6Wd8J6ghbqHFJoXrqzY21TYATgv?=
 =?us-ascii?Q?YToqQpRU1qvZg9IHflrtqOuSl0lx+esCwgA6Tvmz8CgzMgGD0bQhIPeSxCth?=
 =?us-ascii?Q?jQutke6X+DcVgx6dRzPHsDzRioE7to28knCmptSspnEsu0vNQF2WXpuPwpfj?=
 =?us-ascii?Q?ssAVe9PtLyM9hGF4w9lNU8DklRt2KWzBhBAUBiNYMJZuAJ6OHYubbIwMl+rS?=
 =?us-ascii?Q?zzEYlbumu+x4xA7Ur8qoUDO1uMoZxSD7NzWXkXM7OeriHu928Kj13y9Dpbj0?=
 =?us-ascii?Q?6U2on4umWSLpPeAdcK3vcSQz9V436V1rqBEAapJakJWIPDVX2yIAfhfxA7SI?=
 =?us-ascii?Q?LXdObFadaqUjEfFnHb4NC0FlSP+dcU8GgOmwkt4C82x0ZtYRdRZBJjHFAqYz?=
 =?us-ascii?Q?MMnDxbbGbTgvZlajgAUoriyhASwn0J2xIs0A83ZpsqrzvcSnp5Vv7RatNpuk?=
 =?us-ascii?Q?tGjyfKM7YFdeG/+lzGllHslZ5Xo01txsehxDTdVlNcm1G7C7DIKPPNvrhhmL?=
 =?us-ascii?Q?sogiHQiECTDbbtS6PXc152HHBWnjx+fDgd1Xa7I3aaZ0V6eKIDMJrszCP/uF?=
 =?us-ascii?Q?G0c0t95Id5WVeD9YgizNenV05meCqkXCZUwC3ce2MwX9GbDExO1QVDbzUOr0?=
 =?us-ascii?Q?tu+CxewWpZhgI8kLPxO/uqUXvExA791/psw8icYvPqC4NP6FsdRmJuhKlSGW?=
 =?us-ascii?Q?IA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 772f0c19-7c49-479c-13c7-08db89dabde0
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 11:07:58.7283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SXn6gPzFCOz/xCquHmtPgzwJYSKdSzz643PC0KMZVR5fKjUPFKvbxhkduRG4+BnnQUvKCowlhjHiwXusHDMrgvSmYOAf8o478bXv7FcIITc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4496
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Tue, Jul 18, 2023 at 02:58:45PM +0200, Ard Biesheuvel wrote:

...

> diff --git a/crypto/crypto_user_stat.c b/crypto/crypto_user_stat.c
> index d4f3d39b51376973..d3133eda2f528d17 100644
> --- a/crypto/crypto_user_stat.c
> +++ b/crypto/crypto_user_stat.c
> @@ -86,10 +86,6 @@ static int crypto_reportstat_one(struct crypto_alg *alg,
>  		if (crypto_report_cipher(skb, alg))
>  			goto nla_put_failure;
>  		break;
> -	case CRYPTO_ALG_TYPE_COMPRESS:
> -		if (crypto_report_comp(skb, alg))
> -			goto nla_put_failure;
> -		break;

Hi Ard,

It seems that there is an implementation of crypto_report_comp() in this file
which is now unused and can be removed.

>  	default:
>  		pr_err("ERROR: Unhandled alg %d in %s\n",
>  		       alg->cra_flags & (CRYPTO_ALG_TYPE_MASK | CRYPTO_ALG_LARVAL),

...