Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp646312rwo; Fri, 21 Jul 2023 19:23:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlEqtXBbD/vhFK/DAqSZlR6YFTxPOLTGceSWeN1bEG+iqHu13/bgDvZw8XmT033gjDWPmQYz X-Received: by 2002:a05:6871:68e:b0:1b7:4521:14b6 with SMTP id l14-20020a056871068e00b001b7452114b6mr3653222oao.5.1689992639722; Fri, 21 Jul 2023 19:23:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689992639; cv=none; d=google.com; s=arc-20160816; b=l9cwO2Lz8+4tTiZZgVM3TSKz5oN44R6L7dNllxEWoOoLRz/tYjV+MqWOmNbwTwl5KG K4JVGFuMMASnhXpcDD3KRLRyFQMnLf76067Iz+mbHL55iCBPnotHWjMYkJkoSvPBi6RH lDr2fobP3xGEYR1Dgqnnxi9mcIg0lXbXGQ9WqdpNRBe7z8XOO9P59F1PFXs/hkT8Okur +5qfSp9zNIbhl6jp6wFRKH8r5pr5Yw3sXr80OjjGeVH0kEC2Is0+e4a6zQObc59Kvng/ rR7RzV7ZyDvbSiLFPOHEy3nmlhhPSXHVUIOsDX0AY5fJ3MyKICJeTN2/YlEt7Ylc6vCw dU+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=q+ZXiJ2MDGfUTpbwP6/dVxyMOjzp24+WQzbqxRZGoCs=; fh=BUPY0wDIEjNKdsQsPPtyXSRGBxEsMhXm+YHNVZo6C5E=; b=hbzHiHiBUBjnLVeyMOqKZdJlUqBxmvQw1nrymMkhXLuMjAfazpGhdvlJmKealHa2uZ O3bILSqWbkvxlgF55cBtyVnYOLLsDUY5Dceh9mHlj1h1r6ji+7W6o8W2eqG+V88ddnBB 2moEMP/4TpHwgiXHeA76NRypzExl+lkmKDE+nSBpSJpMWrkmwAOILjNjUO35YOdIrsjL /IYfVLTnOzNzxV1D0eX4er0kdGJ1VZM7BgvAr1AOLCk0GEhRSO8FnXTgaRqx8Cd6QS9s DtMR1OmvAlwa5M1dh2AdOrLC6knVcVsKMEeYOBAmSCLqN+Nrl/0aYh21VGc64dCFhPQz AUjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g128-20020a636b86000000b0055781b11927si4129617pgc.437.2023.07.21.19.23.35; Fri, 21 Jul 2023 19:23:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229597AbjGVCN5 (ORCPT + 99 others); Fri, 21 Jul 2023 22:13:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbjGVCN4 (ORCPT ); Fri, 21 Jul 2023 22:13:56 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BF5430F0; Fri, 21 Jul 2023 19:13:54 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qN27f-002D80-OH; Sat, 22 Jul 2023 12:13:32 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sat, 22 Jul 2023 14:13:24 +1200 Date: Sat, 22 Jul 2023 14:13:24 +1200 From: Herbert Xu To: Martin Kaiser Cc: aric.pzqi@ingenic.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: hwrng: ingenic: simplify the code Message-ID: References: <20230710202733.116133-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710202733.116133-1-martin@kaiser.cx> X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_00,HELO_DYNAMIC_IPADDR2, RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS,TVD_RCVD_IP,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Jul 10, 2023 at 10:27:26PM +0200, Martin Kaiser wrote: > Simplify the ingenic-trng driver a bit. Switch to devm_clk_get_enabled and > devm_hwrng_register. Remove some unused code. > > The changes were compile-tested only (I don't have this hardware). > > Martin Kaiser (7): > hwrng: ingenic - enable compile testing > hwrng: ingenic - remove two unused defines > hwrng: ingenic - remove dead assignments > hwrng: ingenic - use devm_clk_get_enabled > hwrng: ingenic - use dev_err_probe in error paths > hwrng: ingenic - don't disable the rng in ingenic_trng_remove > hwrng: ingenic - switch to device managed registration > > drivers/char/hw_random/Kconfig | 3 +- > drivers/char/hw_random/ingenic-trng.c | 57 ++++++--------------------- > 2 files changed, 12 insertions(+), 48 deletions(-) > > -- > 2.30.2 All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt