Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Gaurav Jain <gaurav.jain@nxp.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Horia Geanta <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Varun Sethi <V.Sethi@nxp.com>,
        Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Subject: RE: [EXT] [PATCH 2/2] crypto: caam - Remove messages related to
 memory allocation failure
Thread-Topic: [EXT] [PATCH 2/2] crypto: caam - Remove messages related to
 memory allocation failure
Thread-Index: AQHZvKxjNhox0V1lRkKXpMFNJ3jt0q/LqZMQ
Date:   Wed, 26 Jul 2023 07:19:22 +0000
Message-ID: <AM0PR04MB600469044CFEBDB31D730859E700A@AM0PR04MB6004.eurprd04.prod.outlook.com>
References: <0fc02b533bd3c3422bec5856bc65bbb66ebf7b58.1690037578.git.christophe.jaillet@wanadoo.fr>
 <b8859de12248852f661cb051ffad79166e8dfa47.1690037578.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <b8859de12248852f661cb051ffad79166e8dfa47.1690037578.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OZRUPaQytISCDZyZMfhjW8SRjjbgmddCLjBvpQk4jhkq+I8kP6yOh7ynyAL4?=
 =?us-ascii?Q?caV9a1X+uXcgylAWYeDk1w9AfBXvUqeO6rKOw7fqgBr2wE/Cc8wUxIYCBCkF?=
 =?us-ascii?Q?LRxOSKxd2t1/6QkaY6COBimbGvuK0cdeuL/335h8EzStu+xngB3GX1LtLMWO?=
 =?us-ascii?Q?/EtMBvh/ZnGe7cZNY4ZTYOr2JsTaL/QLMeNzFqu5eBrjGn0bej7nlZHz4qwC?=
 =?us-ascii?Q?7IqahIiHeEIXOW5+pTSsGxZKp9HIIx56k2z3q4O7eC79vb4A+ova8Kfj4Mbw?=
 =?us-ascii?Q?jWFLOEhtjAmTB+L2mLUBHbGOTs9dH8F999bJyW0hgFuqoZgK0ZxQ5vXVGwEN?=
 =?us-ascii?Q?jhs5LfC8df3jK2RQZFMH17a29prYoybM/xPGQXZz3Yx/+9zCVnHnpHBKWdDN?=
 =?us-ascii?Q?QChEPCqmEIdTbZK08hWTGdFe7h4v+QJMO7zkagyUYjSLAio6+t4nKj6Thwdr?=
 =?us-ascii?Q?xyDc0wbE3VWllZhYxIwpNSi+jozr6xOnfvW9YZUOohfkn5DCMKTF7OUMxnQa?=
 =?us-ascii?Q?HTKRjdT9IuF9tgdQUup6P5t8dvi3X1f+oUx/kKJvY3PeTjmH2tVZVdWHIOf9?=
 =?us-ascii?Q?hWXMdGLR4fsNH1yZNWTvTsKlDhvBjYi2NJajq0g+bEvQjdS/loIacIO2JM8+?=
 =?us-ascii?Q?eVPxNYCFh5xFh7F8XoHe4yKiJfa76p9VYYTO77dDoTkPcqcpWN4a80GK/6Sk?=
 =?us-ascii?Q?s61+sA+zklJaHw9Ftn/SSs/ELiZlCbXKhJiSJ9AfIbU5/Z0ci6DjFNgekb3D?=
 =?us-ascii?Q?TFkfSbkAwzthAtYBLsRNCqHdgaxzxiHXueqJi0Qsqd9HjVPzRf/N/TBMp72u?=
 =?us-ascii?Q?n5CY32upsXrBvtqRnB5y4RVBAUfscrYKgX8aEmLjc4Xid8xu4j3urIGDrqP7?=
 =?us-ascii?Q?An5sVlvfX++K4zccyAtrNeelj3dkBiDQ9qcbz7qy65o3Pr01iPGJcoeudHWc?=
 =?us-ascii?Q?MyueW4Cj7WXV2wqQ0NErPg8Wd6yjVLuKy2GJfGsD6mOLB3RwLXNr/O5hgZe/?=
 =?us-ascii?Q?GISlOko9bdwimyjYvPgHlBXlNsUBbXzFO3rZv+pAI+D9DjovQXDOV9ljTeNn?=
 =?us-ascii?Q?0yKwRLPibF+4U0vx8o4e1kQQttRAiAcDaJ7LJ56PblAPVF6SVngQiMFviKUV?=
 =?us-ascii?Q?ezpkJGR0LBB6dqqP4gnh5CNi8/BrjybDkfexAN7bi5YjlEXxhI3gyz8jCOxi?=
 =?us-ascii?Q?+qLRCqPUbJaFC98FeENEjVgDJeGBd4RL3YDN9rQqrjljg9EeNTbQS85+o2gG?=
 =?us-ascii?Q?yYQOMF8FUMuEkbHcaJFfuzj5xG5bmEEgY4TxZ2hVx6A8N2PSLyyB726X0pNh?=
 =?us-ascii?Q?X642LGZSJPsRdERA3rZu05+OJGlxXRLAKY+uZXKI1roVX2JqmKYWSIutRYvz?=
 =?us-ascii?Q?bLs2bnce5giDdL7e4by9PXN270Ng47lnCw0AiG3ITn3AGw4WAq8Fjf8vsGYI?=
 =?us-ascii?Q?Ue/t74WJipBMdg2QlWWILfhhBMdO5VNJdofjT7JSvs8uCq7u+fVRihqeQz2z?=
 =?us-ascii?Q?EDyDBg/WCGu2fwXXu0/m+81jHuE5UR90RaLvQLykmiK2K9BP6+6W+cPFpT5T?=
 =?us-ascii?Q?kFrDl1Sn20aokml9tAIlWUH724xYcDafRCZU707L?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6004.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95d8b480-20ef-4e1c-ead5-08db8da8a265
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2023 07:19:22.1526
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: M8JA7TIt8PQRbei75fUWy9RP7GGTrciNGFX8KVUs1xdqYd+3OeX9p9rjUeO+Yko9p1cTj/vUJzZnt/3tc0+u/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9332
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Reviewed-by: Gaurav Jain <gaurav.jain@nxp.com>

> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Saturday, July 22, 2023 8:24 PM
> To: Horia Geanta <horia.geanta@nxp.com>; Pankaj Gupta
> <pankaj.gupta@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>; Herbert Xu
> <herbert@gondor.apana.org.au>; David S. Miller <davem@davemloft.net>
> Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christ=
ophe
> JAILLET <christophe.jaillet@wanadoo.fr>; linux-crypto@vger.kernel.org
> Subject: [EXT] [PATCH 2/2] crypto: caam - Remove messages related to memo=
ry
> allocation failure
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report =
this
> email' button
>=20
>=20
> On memory allocation failure, the function calling stack is already logge=
d.
> So there is no need to explicitly log an extra message.
>=20
> Remove them, ans simplify some code accordingly.
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/crypto/caam/caamhash.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
>=20
> diff --git a/drivers/crypto/caam/caamhash.c b/drivers/crypto/caam/caamhas=
h.c
> index 9e5924e24f2e..641c3afd59ca 100644
> --- a/drivers/crypto/caam/caamhash.c
> +++ b/drivers/crypto/caam/caamhash.c
> @@ -368,10 +368,8 @@ static int hash_digest_key(struct caam_hash_ctx *ctx=
,
> u32 *keylen, u8 *key,
>         int ret;
>=20
>         desc =3D kmalloc(CAAM_CMD_SZ * 8 + CAAM_PTR_SZ * 2, GFP_KERNEL);
> -       if (!desc) {
> -               dev_err(jrdev, "unable to allocate key input memory\n");
> +       if (!desc)
>                 return -ENOMEM;
> -       }
>=20
>         init_job_desc(desc, 0);
>=20
> @@ -702,18 +700,14 @@ static struct ahash_edesc *ahash_edesc_alloc(struct
> ahash_request *req,
>                                              int sg_num, u32 *sh_desc,
>                                              dma_addr_t sh_desc_dma)  {
> -       struct crypto_ahash *ahash =3D crypto_ahash_reqtfm(req);
> -       struct caam_hash_ctx *ctx =3D crypto_ahash_ctx_dma(ahash);
>         struct caam_hash_state *state =3D ahash_request_ctx_dma(req);
>         gfp_t flags =3D (req->base.flags & CRYPTO_TFM_REQ_MAY_SLEEP) ?
>                        GFP_KERNEL : GFP_ATOMIC;
>         struct ahash_edesc *edesc;
>=20
>         edesc =3D kzalloc(struct_size(edesc, sec4_sg, sg_num), flags);
> -       if (!edesc) {
> -               dev_err(ctx->jrdev, "could not allocate extended descript=
or\n");
> +       if (!edesc)
>                 return NULL;
> -       }
>=20
>         state->edesc =3D edesc;
>=20
> @@ -1908,10 +1902,8 @@ caam_hash_alloc(struct caam_hash_template
> *template,
>         struct crypto_alg *alg;
>=20
>         t_alg =3D kzalloc(sizeof(*t_alg), GFP_KERNEL);
> -       if (!t_alg) {
> -               pr_err("failed to allocate t_alg\n");
> +       if (!t_alg)
>                 return ERR_PTR(-ENOMEM);
> -       }
>=20
>         t_alg->ahash_alg =3D template->template_ahash;
>         halg =3D &t_alg->ahash_alg;
> --
> 2.34.1