Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 12:22:12 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Gatien Chevallier <gatien.chevallier@foss.st.com>
Cc:     Oleksii_Moisieiev@epam.com, gregkh@linuxfoundation.org,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, alexandre.torgue@foss.st.com,
        vkoul@kernel.org, jic23@kernel.org, olivier.moysan@foss.st.com,
        arnaud.pouliquen@foss.st.com, mchehab@kernel.org,
        fabrice.gasnier@foss.st.com, andi.shyti@kernel.org,
        ulf.hansson@linaro.org, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, hugues.fruchet@foss.st.com, lee@kernel.org,
        will@kernel.org, catalin.marinas@arm.com, arnd@kernel.org,
        richardcochran@gmail.com, Frank Rowand <frowand.list@gmail.com>,
        linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        dmaengine@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-iio@vger.kernel.org, alsa-devel@alsa-project.org,
        linux-media@vger.kernel.org, linux-mmc@vger.kernel.org,
        netdev@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-serial@vger.kernel.org, linux-spi@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 05/11] firewall: introduce stm32_firewall framework
Message-ID: <ZMDz1AhlEeZTM/vi@corigine.com>
References: <20230725164104.273965-1-gatien.chevallier@foss.st.com>
 <20230725164104.273965-6-gatien.chevallier@foss.st.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230725164104.273965-6-gatien.chevallier@foss.st.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p4dhcp7ceHRMf9PxLP7UKVmzkTGc43zOFzIfwC2eB0YKk2CBEclCXiiYx7wc?=
 =?us-ascii?Q?oSP6k0m3zGOuAfpBms/D7bcEuyKA8HdAAdHPXEnWG09oLmqpcal/93EA7edR?=
 =?us-ascii?Q?T4LjL70cjR83snnbD++RSu+fDwJMHQNdf38o+0ThFDILhjkq8wZeM7cBOZ0G?=
 =?us-ascii?Q?5SgHA1XLozcDgQhBFvSw7bE/v9HcoOp45xzXAcnaoxb4JHDvzrMHZD5jcz9Q?=
 =?us-ascii?Q?QrqKKKipPVI9gSzR9yjvFgWNpOSHcqbyA9KhwEACVA5u9Sm/3OK3hEY7tGY2?=
 =?us-ascii?Q?htWoOGeUxfeX5KXlR/FXI4+aaq6TEbvGu8FqVCvaLDdtRJNs3Udc8SVMgZZR?=
 =?us-ascii?Q?JCRwR+cCQxAiGE9Vd76YYHwZ8+zOW9P+9vRrB6fPPToVS8z+u+46puXgAoTk?=
 =?us-ascii?Q?cbuksAIqkZA0EbkTF7CClyIa7Bmikl8WfQ2vUe4EX3GI+ROGJNtrKEc3VEiT?=
 =?us-ascii?Q?TBz9IV/MJ0ULLYxuLwyDL9Qs4hyxMg93/NhYXwcmcuaUQVx/OHcC2cVt66dD?=
 =?us-ascii?Q?pJmKmUQj/pzpl3zVCI25zF6QCYHgIXgj38mq7PSJcq5UvNNPn/CHiYPacDQW?=
 =?us-ascii?Q?+SXWpMZIoRU9Wk2OtDg2IOnOOgDqglFBFnZRci9EF9IMprpHgZWu4EWPBb0N?=
 =?us-ascii?Q?YZidnovZcqO6SML+djrs+o/PxRMdNEa1WXvsq5CBg3DauBG34HlguJ+i4pNm?=
 =?us-ascii?Q?dYz/CPQrbkdlLfa/8KQHhu5lAb/WFVUSeQWfkhW3vvh8mH+Fwv9Pa4VYEalI?=
 =?us-ascii?Q?3ua2NmFD+umxSDu0z4ZgVGP0vrtQFdyyZNENaKQDRLRYv8BcDlPicaKgS/pR?=
 =?us-ascii?Q?xzJrxnGh48Al0UThh5zTSyjq4XAl36vXYlU/YfKZ69OXLBBf40BPhwRJ8oms?=
 =?us-ascii?Q?eL2UDbtN8a3Zv7KL+TCYiTLVDfJdv5WCb/bzSO7Tkf2wjmJP4Zh+w6nkHl2Z?=
 =?us-ascii?Q?aT15CjkowaP3CbfHAQRlKBGNcq7xg31x8os//IfSYZmlCSzduUmW9Z7mDRjm?=
 =?us-ascii?Q?z/mZ/3TYOprMDcSn1exqjYq5ggW50NrKAELXcafUAftxcujUvuAjSANNE9Lv?=
 =?us-ascii?Q?RxY2jm/ERQrct0iVFKPlLdT5xX/fvd2lyi9wbAq3t1fwIOHBduuEKy4rtKMn?=
 =?us-ascii?Q?GPYoNwyZ9G0j6oX9Uepg1aWPXn3OKg+J4CXZc3goFclbaN/+3S5NFtrq0PB4?=
 =?us-ascii?Q?1SWGnemlv14IxQgAs0W0mmhn5mtzTn6G51BFRXTD3fiWYI4iaqdZu2rNExBU?=
 =?us-ascii?Q?WAf8KdZoDiOS7lS1W4sfjgYtr5fixj/egOb8lnSsMr8ImRfq+sQrnYC6oXqv?=
 =?us-ascii?Q?oPV6+FtuVoRxqkcpCfOFDi+rdBmgatQvDU4PiwNLPBi1girWkmBMtLCAraO/?=
 =?us-ascii?Q?BSsm+q9ycQOKUNZaCfi6j7dqkrv0asixPmQ+4xm+9gX1cfEAIOq+ugNDR1UH?=
 =?us-ascii?Q?ScGObKZjHwZPHEVxqX3EnVpCKUjKH3ruoK8BdhxurUs3UQeAoyqBQe2iFQ7A?=
 =?us-ascii?Q?k21ifWfKlM+dnu15PIYUiyE3GdQqGtD7h25jidYDyY+7cRKfXz2gpuUecx49?=
 =?us-ascii?Q?fNAzaGQjuOOxQAEQvIDj7weMoX9aDQs+L2xBWZM12HRySHiTHRwRAyWZ6q2t?=
 =?us-ascii?Q?rz4kCfoP6FGCARnCXwcwTfnSx7GNO2zsU/xjQtIthyu1DednUOIIcBe+YRSa?=
 =?us-ascii?Q?dO9W7g=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6bc01507-a6b8-42b4-4e80-08db8dc233c9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 10:22:23.6707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 85f4MKcsU35zyTU6yCfRjheQIZ5KfV20YFbpawl8e9rEALD1U4SpjwR/z8XrM4BTMc8GG68BHYFnVXxyjzuNNIrIsJxxDpfGfQmdRv4Qw0c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4840
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Tue, Jul 25, 2023 at 06:40:58PM +0200, Gatien Chevallier wrote:

...

> diff --git a/drivers/bus/stm32_firewall.c b/drivers/bus/stm32_firewall.c

...

> +int stm32_firewall_controller_register(struct stm32_firewall_controller *firewall_controller)
> +{
> +	struct stm32_firewall_controller *ctrl;
> +
> +	pr_info("Registering %s firewall controller\n", firewall_controller->name);
> +
> +	if (!firewall_controller)
> +		return -ENODEV;

HI Gatien,

Sorry, one more on this patch, that I missed before sending my previous
email.

firewall_controller is checked for NULL here.
But it is already dereferenced on the line above the check.

Flagged by Smatch.

...