Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v2] crypto: atmel: Use dev_err_probe instead of dev_err
Date:   Wed, 26 Jul 2023 20:04:41 +0800
Message-Id: <20230726120451.6099-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HVj4Y/5IdqbYd12IL0dspUApot3Swo6KKj5mPmGjU9Usxg+rX2cNkflLaieS?=
 =?us-ascii?Q?j7QpVeg6zyLcbEuLLlcYqNRaZNcQM/CleJiOEOp6ryOSNK+5gQP7qt2Xa7/3?=
 =?us-ascii?Q?MzFQXUfn7SKkRnJ8zT+xBD/PPGo1ll879rsfmbWesnTxq+lPCoo09O+ddiej?=
 =?us-ascii?Q?yGA1bYJp/Aii0iQqaoq6kyIL7iUtVv5xYMcdBkLeiozanmvaa9dVE+TlcqNX?=
 =?us-ascii?Q?QWtzyIJ0RrsTuTOBzL84PL5sORftoipfRZmU7pw9iH2m1hR+nu6Uu44+20pJ?=
 =?us-ascii?Q?eF5xP7HmoVOE9O90h+ksIjCoeG76IkCQyI6JlLFL/ZTZYsezWzDn68lL+Mty?=
 =?us-ascii?Q?KvO+up44T/19xXo0bZTNFArbUpzX6Ce+A3gZjfrGayA+rIes1BQKWrXOcwti?=
 =?us-ascii?Q?lSIv0SNHHypH2yZuDH0RT8GZVPqelPRanjXg+tVYrOviCeTqijAr+E8UZnXC?=
 =?us-ascii?Q?QgjDPRD5/yXqmJVGThL0CGT7SN136IPzdQPHKhXwa1doBmQ6q8t6SyydA5mk?=
 =?us-ascii?Q?qOBw54euoIHIEKDToSlGC0sypIjZ87BHgVZA3pUC+X7lkcOC7uTduQw5saZ5?=
 =?us-ascii?Q?fFVB65gtVTsvqoPeutO9Gq9qhLy1N75w4R8JIa1no+5gvVzWlcGUILU4wAjV?=
 =?us-ascii?Q?cHEn2R78FYSb9U5YPpfCu+DgzGZ6S4Uf2cacGlA78faqROdXD6KRW+UJVs5q?=
 =?us-ascii?Q?npBVb9Yw/yGJXDJ+VSEdXLpCEb2j3z+32VvNpqdclftfML7OgiMRzmAG88eG?=
 =?us-ascii?Q?Z1Gi7twtGjBe1KUUOU4zS5tAl15uqorhKWIh5f/K5f/hoNF/hDl+mYn6dIiH?=
 =?us-ascii?Q?AEtWdrWAnAcixM1tgJwFmh0HHOUEwaOSPBEuHLwGMj/666PO2vs82cIqxHLf?=
 =?us-ascii?Q?T4U688JcUinDDAoQf89fhd7f6jmy23BJLDdddst3VrwSj09ik2y9B3jeDBWU?=
 =?us-ascii?Q?N0UVjMgPAbdV3eWMAiqtXufErdJlLIVR9j++buIbz03d60KmVwnZ4kEZXSPI?=
 =?us-ascii?Q?aAGvxuF4UfzWRQyykvTG9uIqpiR3Nnu7UY5YgX1ht+iaCRMM8WN9QR7pEPzW?=
 =?us-ascii?Q?o/tGYMIo8TQT1+gdlHBSlVM2no1mSpzsS/v/gnIHLExwvEv0/V1j94bcDkzU?=
 =?us-ascii?Q?8jRojHJBuwYCtQj3AZ4OvBrau7QD45w6KB7vDHIC4BeivYakGUixbUEZ+wFW?=
 =?us-ascii?Q?vSZADwstlOXSTrNcDDv/wPoAH/zZ4G7kZS0mIpa9XXWwaWbOJhjQfoXLh//A?=
 =?us-ascii?Q?LZRW1rczP069bEBckkgNYjBh29e+tIzbpmPcCErC9Agr2Tuj2MMwf15vehm7?=
 =?us-ascii?Q?tAjswyniN97EcCgF4Eno9ho7O9eV2kHPeZpOzikymM7vM1bCpb3GjJDlLphE?=
 =?us-ascii?Q?DFILKTuDRnSInQfrAelsxKnPsxHLMIMUDeT602P83fq0PWv1EQQorMaJsajU?=
 =?us-ascii?Q?wwlkQrmR8lSVCOcnFB7TEHPFNzzN14SdR0pBki2yDrLSrDyhls2q5t41OaNy?=
 =?us-ascii?Q?XEnpHugxjhn+4RdjDvyBvJEuXPyeJLlsAoRiHPJid1I99Fo7Itdbk82ZK2n7?=
 =?us-ascii?Q?kA3zFLhqwhSdO2Bu9p/gBP9XSALpvzOUErazJn4C?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49e6d24f-946c-4d46-5800-08db8dd09aa1
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 12:05:29.3257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OBXofq+g0wz9yNqALxkzrL/CHt3WS1OZZMeUnH6Q6LtoEpRzwKmvct4RE78yYLF9l16SMrAfu7LkL9dR+ClaUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6580
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

It is possible that dma_request_chan will return EPROBE_DEFER,
which means that dd->dev is not ready yet. In this case,
dev_err(dd->dev), there will be no output. This patch fixes the bug.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/crypto/atmel-sha.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 6bef634d3c86..5682957f805d 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -2499,8 +2499,8 @@ static int atmel_sha_dma_init(struct atmel_sha_dev *dd)
 {
 	dd->dma_lch_in.chan = dma_request_chan(dd->dev, "tx");
 	if (IS_ERR(dd->dma_lch_in.chan)) {
-		dev_err(dd->dev, "DMA channel is not available\n");
-		return PTR_ERR(dd->dma_lch_in.chan);
+		return dev_err_probe(dd->dev, PTR_ERR(dd->dma_lch_in.chan),
+			"DMA channel is not available\n");
 	}
 
 	dd->dma_lch_in.dma_conf.dst_addr = dd->phys_base +
-- 
2.25.1