Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Jul 2023 16:07:50 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Zhang Yiqun <zhangyiqun@phytium.com.cn>
Cc:     davem@davemloft.net, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: all - alloc and init all req alloc as zero
Message-ID: <ZMIl1vSitJBU3UJS@gondor.apana.org.au>
References: <20230727080548.8666-1-zhangyiqun@phytium.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230727080548.8666-1-zhangyiqun@phytium.com.cn>
Precedence: bulk

On Thu, Jul 27, 2023 at 04:05:48PM +0800, Zhang Yiqun wrote:
> This patch is to change all req struct alloc function from kmalloc
> to kzalloc. Sometimes, it will incur some errors without initialized
> zero.
> 
> Signed-off-by: Zhang Yiqun <zhangyiqun@phytium.com.cn>
> ---
>  include/crypto/akcipher.h | 2 +-
>  include/crypto/hash.h     | 2 +-
>  include/crypto/kpp.h      | 2 +-
>  include/crypto/skcipher.h | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

Nack.  Unless you have a specific issue please don't submit vague
patches like this.  You should always state what issue led you to
make a change like this.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt