Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yang Yingliang <yangyingliang@huawei.com>
To:     <linux-crypto@vger.kernel.org>
CC:     <jiajie.ho@starfivetech.com>, <william.qiu@starfivetech.com>,
        <herbert@gondor.apana.org.au>, <huan.feng@starfivetech.com>,
        <davem@davemloft.net>, <yangyingliang@huawei.com>
Subject: [PATCH -next] crypto: starfive - fix return value check in starfive_aes_prepare_req()
Date:   Mon, 31 Jul 2023 22:02:49 +0800
Message-ID: <20230731140249.2691001-1-yangyingliang@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type:   text/plain; charset=US-ASCII
Precedence: bulk

kzalloc() returns NULL pointer not PTR_ERR() when it fails,
so replace the IS_ERR() check with NULL pointer check.

Fixes: e22471c2331c ("crypto: starfive - Add AES skcipher and aead support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/crypto/starfive/jh7110-aes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/starfive/jh7110-aes.c b/drivers/crypto/starfive/jh7110-aes.c
index 04dd7958054f..278dfa4aa743 100644
--- a/drivers/crypto/starfive/jh7110-aes.c
+++ b/drivers/crypto/starfive/jh7110-aes.c
@@ -496,8 +496,8 @@ static int starfive_aes_prepare_req(struct skcipher_request *req,
 
 	if (cryp->assoclen) {
 		rctx->adata = kzalloc(ALIGN(cryp->assoclen, AES_BLOCK_SIZE), GFP_KERNEL);
-		if (IS_ERR(rctx->adata))
-			return dev_err_probe(cryp->dev, PTR_ERR(rctx->adata),
+		if (!rctx->adata)
+			return dev_err_probe(cryp->dev, -ENOMEM,
 					     "Failed to alloc memory for adata");
 
 		scatterwalk_copychunks(rctx->adata, &cryp->in_walk, cryp->assoclen, 0);
-- 
2.25.1