Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Aug 2023 10:51:26 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Ard Biesheuvel <ardb@kernel.org>
CC:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Eric Biggers <ebiggers@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Haren Myneni <haren@us.ibm.com>,
        Nick Terrell <terrelln@fb.com>,
        Minchan Kim <minchan@kernel.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Jens Axboe <axboe@kernel.dk>,
        Richard Weinberger <richard@nod.at>,
        David Ahern <dsahern@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Steffen Klassert <steffen.klassert@secunet.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        qat-linux <qat-linux@intel.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH 01/21] crypto: scomp - Revert "add support for
 deflate rfc1950 (zlib)"
Message-ID: <ZMt4nkfpdCXxAkr5@gcabiddu-mobl1.ger.corp.intel.com>
References: <20230718125847.3869700-1-ardb@kernel.org>
 <20230718125847.3869700-2-ardb@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230718125847.3869700-2-ardb@kernel.org>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Lga4pFFs7leZF9HX5L4F6WkIevbbgsCCXMKaTRj49zNbwQCcbEFGVXpikffX?=
 =?us-ascii?Q?GIdzTR5MJXCzZNhPKwKoG/zFCr/EyNRvxU86iJpfV6u9ow/Q6dCwjcDfAAr/?=
 =?us-ascii?Q?etXX29Zr8WU+s0Mkm2ikuGyDZC0RE2+mV+98EFHNE2piyI85xv1xm3bLoFWs?=
 =?us-ascii?Q?NkUPIR/d3qC3gGDy/tScKQd9Gc5dROhuOs3g8mtapD1HkHlpy7ibgZEh2VsC?=
 =?us-ascii?Q?Pc5K5SyoLqfEjXEtklQjwZCshsBd2VIpMm9EH8OGgh8dSUytuvV2/6U/NUCi?=
 =?us-ascii?Q?kR6IqyThgNayxLBmxzdJTkVhMpLn0tBRhXWajiPAkqEXFOG3Cr+upSBiZCiP?=
 =?us-ascii?Q?N3bpEu6XhAQhEvdwMon9h4lEbU5MWAllj8JeZu4dDp4/trKGsEuWNyorI2qS?=
 =?us-ascii?Q?6tVEdYpn0VAmycHAaG2YylmzDumlVcLx7oQCzOhfiF8cPqxKqTttJb/7YRNg?=
 =?us-ascii?Q?6SMBm+aEqcl7c37Mi9D0e3CsV2E7qAys23bJvcdJ6/BjCSLdZY0ja9VoGKPF?=
 =?us-ascii?Q?qIlucEzkH4R9j0sS5ZC0gpSpNyyhJoCPo4sg8jLt8TJYX5IGAwrErrZK1E1r?=
 =?us-ascii?Q?Tkq5awRSvuUz3Kt4gmArjQja6aci8Xr5gv7+9CZ+PzDOrj1FJYMhikweCr9e?=
 =?us-ascii?Q?eRBT/QPdsO/SCHxqHZKfRYbjIOA5/SvOnJs310n8921i2oM+/XSgOOpmtdHm?=
 =?us-ascii?Q?R/kN/YguC4c1NdqFflBtWLFpyTojf08kW+GL1x+aNq+qHqmW+aUNJF8e+ov2?=
 =?us-ascii?Q?BJYWvukW+03HM7L7dvhaHXvPWioqcRtebSilJN3fQuaDMQxXuqltti/gRiD/?=
 =?us-ascii?Q?yKfLn3/gU0f+7MArIXU1tcLHuY9W9gj3o6PkwNHo94BgM1Wes+vvnWTP8l9m?=
 =?us-ascii?Q?WxrkW4+Cj0In8c+vwW+DM/ld1XzOHgpYh0mWETtaILUL45K5zxwY6pODaV8R?=
 =?us-ascii?Q?HEY8dMQnURimtR5jji8diY0A6LoDqA3GEoiMNTr2/rZVWSrxwtG+qys+50Fr?=
 =?us-ascii?Q?B8OyIlOOa4OYf+OlEvhZe4DH1iGrEV0TAcw18ep8akGj9+yOTUlOwguyV7Co?=
 =?us-ascii?Q?pQYIGmufoWVs0IOkYyDj+9F0sVLQu5nzknnKRA08DzVRefFnornQBKEh7rIP?=
 =?us-ascii?Q?rJ/W1TgUyIxNxy0RSKOhWv9a0QbBAmUyQX54FRTXMZIqU95H8vOBU6ZEF2sz?=
 =?us-ascii?Q?duWQXDhYyO9YCz3QX1VkJyoKegrkIvTWMmvLoF044UW/h10dPSzDs6qLZzjy?=
 =?us-ascii?Q?xL5W5PDk7A4KAxGrPGVCyVviKUV0f0anTKYLH5FhBiCnIk3+/lg2HIihJlCS?=
 =?us-ascii?Q?iJjuy6r+IRXP9cpYEtV5jTQ1G7i8FlMCzjXspzb0xrwHxSywPv3eEzzKIvCg?=
 =?us-ascii?Q?AFGY71HgC37Zm3HLm4t5bLUtIB5uBBsZte6MQxGqhM4mIpC/W6WmYFWO67TG?=
 =?us-ascii?Q?9/fC8pV3A/YwkxQemNRRAM/Z+2+0Th+pCJZ1lJKDJq9L9IH+/NtteERcH3Rn?=
 =?us-ascii?Q?92liXbfXKqbJWFG9XDuGcWIbPmWJodjcE1TP88l3tRyFa03kE7v/LkmeN0gP?=
 =?us-ascii?Q?BLAxPLzJAmA+Rs9lK9it02pKWOTIklSmH/JAjwNs8KjQdt5OgcC9CG7eQjbt?=
 =?us-ascii?Q?oQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1028c133-db60-4560-f441-08db94073bd1
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 09:51:39.8469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nBfUJuNll9ZGLMZYQHRtdAS+rk2qNTLE9GJvBuE+weca+edJG4bbe1U6e2PCh9+MtLzJXEKJne6S2obnsGQLoiOQBryVbidnak+p+eGynaA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5820
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi Ard,

On Tue, Jul 18, 2023 at 01:58:27PM +0100, Ard Biesheuvel wrote:
> This reverts commit a368f43d6e3a001e684e9191a27df384fbff12f5.
> 
> "zlib-deflate" was introduced 6 years ago, but it does not have any
> users. So let's remove the generic implementation and the test vectors,
> but retain the "zlib-deflate" entry in the testmgr code to avoid
> introducing warning messages on systems that implement zlib-deflate in
> hardware.
> 
> Note that RFC 1950 which forms the basis of this algorithm dates back to
> 1996, and predates RFC 1951, on which the existing IPcomp is based and
> which we have supported in the kernel since 2003. So it seems rather
> unlikely that we will ever grow the need to support zlib-deflate.
> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Support for zlib-deflate was added for [1] but that work was not
completed.

Based on [2], either we leave this SW implementation or we remove the HW
implementations in the QAT [3] and in the Hisilicon Zip [4] drivers.

[1] https://patchwork.kernel.org/project/linux-btrfs/patch/1467083180-111750-1-git-send-email-weigang.li@intel.com/
[2] https://lore.kernel.org/lkml/ZIw%2Fjtxdg6O1O0j3@gondor.apana.org.au/
[3] https://elixir.bootlin.com/linux/latest/source/drivers/crypto/intel/qat/qat_common/qat_comp_algs.c#L457
[4] https://elixir.bootlin.com/linux/latest/source/drivers/crypto/hisilicon/zip/zip_crypto.c#L754

Regards,

-- 
Giovanni