Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Aug 2023 18:49:50 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Tom Zanussi <tom.zanussi@linux.intel.com>
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net,
        fenghua.yu@intel.com, dave.jiang@intel.com, tony.luck@intel.com,
        wajdi.k.feghali@intel.com, james.guilford@intel.com,
        kanchana.p.sridhar@intel.com, vinodh.gopal@intel.com,
        giovanni.cabiddu@intel.com, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v8 07/14] dmaengine: idxd: add callback support for iaa
 crypto
Message-ID: <ZMupdvn8J+mM2Kak@matsya>
References: <20230731212939.1391453-1-tom.zanussi@linux.intel.com>
 <20230731212939.1391453-8-tom.zanussi@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230731212939.1391453-8-tom.zanussi@linux.intel.com>
Precedence: bulk

On 31-07-23, 16:29, Tom Zanussi wrote:
> Create a lightweight callback interface to allow idxd sub-drivers to
> be notified when work sent to idxd wqs has completed.
> 
> For a sub-driver to be notified of work completion, it needs to:
> 
>   - Set the descriptor's 'Request Completion Interrupt'
>     (IDXD_OP_FLAG_RCI)
> 
>   - Set the sub-driver desc_complete() callback when registering the
>     sub-driver e.g.:
> 
>       struct idxd_device_driver my_drv = {
>             .probe = my_probe,
>             .desc_complete = my_complete,
>       }
> 
>   - Set the sub-driver-specific context in the sub-driver's descriptor
>     e.g:
> 
>       idxd_desc->crypto.req = req;
>       idxd_desc->crypto.tfm = tfm;
>       idxd_desc->crypto.src_addr = src_addr;
>       idxd_desc->crypto.dst_addr = dst_addr;
> 
> When the work completes and the completion irq fires, idxd will invoke
> the desc_complete() callback with pointers to the descriptor, context,
> and completion_type.

Acked-by: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod