Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <89596072f7fee8a877e08e01cf937136c4a39003.camel@linux.intel.com>
Subject: Re: [PATCH v8 03/14] dmaengine: idxd: Export drv_enable/disable and
 related functions
From:   Tom Zanussi <tom.zanussi@linux.intel.com>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net,
        fenghua.yu@intel.com, dave.jiang@intel.com, tony.luck@intel.com,
        wajdi.k.feghali@intel.com, james.guilford@intel.com,
        kanchana.p.sridhar@intel.com, vinodh.gopal@intel.com,
        giovanni.cabiddu@intel.com, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org
Date:   Thu, 03 Aug 2023 09:24:07 -0500
In-Reply-To: <ZMuoi8FycD28v084@matsya>
References: <20230731212939.1391453-1-tom.zanussi@linux.intel.com>
         <20230731212939.1391453-4-tom.zanussi@linux.intel.com>
         <ZMuoi8FycD28v084@matsya>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

Hi Vinod,

On Thu, 2023-08-03 at 18:45 +0530, Vinod Koul wrote:
> On 31-07-23, 16:29, Tom Zanussi wrote:
> > To allow idxd sub-drivers to enable and disable wqs, export them.
> >=20
> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> > Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> > Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> > ---
> > =C2=A0drivers/dma/idxd/device.c | 2 ++
> > =C2=A01 file changed, 2 insertions(+)
> >=20
> > diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> > index 5abbcc61c528..87ad95fa3f98 100644
> > --- a/drivers/dma/idxd/device.c
> > +++ b/drivers/dma/idxd/device.c
> > @@ -1505,6 +1505,7 @@ int drv_enable_wq(struct idxd_wq *wq)
> > =C2=A0err:
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return rc;
> > =C2=A0}
> > +EXPORT_SYMBOL_NS_GPL(drv_enable_wq, IDXD);
>=20
> Sorry this is a very generic symbol, pls dont export it. I would make
> it
> idxd_drv_enable_wq()

Yeah, good point, I'll do that for the next version.  And thanks for
all your Acks!

Tom

>=20
> > =C2=A0
> > =C2=A0void drv_disable_wq(struct idxd_wq *wq)
> > =C2=A0{
> > @@ -1526,6 +1527,7 @@ void drv_disable_wq(struct idxd_wq *wq)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0wq->type =3D IDXD_WQT_N=
ONE;
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0wq->client_count =3D 0;
> > =C2=A0}
> > +EXPORT_SYMBOL_NS_GPL(drv_disable_wq, IDXD);
> > =C2=A0
> > =C2=A0int idxd_device_drv_probe(struct idxd_dev *idxd_dev)
> > =C2=A0{
> > --=20
> > 2.34.1
>=20