Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52b44427-4670-15c1-ef96-8344413e76cc@intel.com>
Date:   Thu, 3 Aug 2023 08:24:15 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH v8 03/14] dmaengine: idxd: Export drv_enable/disable and
 related functions
To:     Vinod Koul <vkoul@kernel.org>,
        Tom Zanussi <tom.zanussi@linux.intel.com>
CC:     <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
        <fenghua.yu@intel.com>, <tony.luck@intel.com>,
        <wajdi.k.feghali@intel.com>, <james.guilford@intel.com>,
        <kanchana.p.sridhar@intel.com>, <vinodh.gopal@intel.com>,
        <giovanni.cabiddu@intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>, <dmaengine@vger.kernel.org>
References: <20230731212939.1391453-1-tom.zanussi@linux.intel.com>
 <20230731212939.1391453-4-tom.zanussi@linux.intel.com>
 <ZMuoi8FycD28v084@matsya>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <ZMuoi8FycD28v084@matsya>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R09lNHFYdXp4TUgyVlJTM1Fhbm5FcnNESWhoYXYyYTNudGkwMzlVak5yUTFY?=
 =?utf-8?B?dENiLzRsa3V6bVZEREhzTldJNy8rU24zRWt0T0N3dEhoaUk4U1BnT083OHJl?=
 =?utf-8?B?ZmtqbmwxekxFeXZWbXNmSy9vWmlTZmZaY0Z5S3BnalJRa3pFVTJWVWJjZnlM?=
 =?utf-8?B?RDlJd1RnSmZQY1ROMHlTQzRCMXMrM2s2MmE1VkttRFZhNm5WNDdIR3ZSY0dr?=
 =?utf-8?B?RGpHME5tTXFBb0ZsaGE3Z2NXbENQbzFEVHZGRjcrWExHNm5XV0JJaXFScDBS?=
 =?utf-8?B?UHkrZzRTWnJSMkFOb2Q0YVNxY2tVODB5eWVEMStQSjJ2UDFOaXk1ajZhT3R5?=
 =?utf-8?B?ZDRTaHBrbW1oM2JMenVsSDJNUkkyb1FFM1NjbWgzejBYNUhXTVZtYjg0WnpK?=
 =?utf-8?B?SG1wN3NyMWJDbFJLUFdhZ0Niek9jdk13cEN5QjhjVDRNT0VkUkZ1RThnMnRT?=
 =?utf-8?B?L0psb01ScEs0WnVkL2pjT2lZcy82MUxOUy9Dc3Z1V2h1RW9kUHF2ZU82N2la?=
 =?utf-8?B?M1Y0WVBrcWFZQUNEb056aTVMandaWERFYm1Oc2VwbGFEMUNaVFN5NE55am5X?=
 =?utf-8?B?d2xCZGh0dUtNMFlLL2dva3dISCtZUjRIaFRKWU1yWm1VVkJIZWRvZWN2UTho?=
 =?utf-8?B?UHBTaUsyZEdsWHVYdUdyaGg4dkxRQnVhbm9kSmlKVVNVdXVBZWpyTVFpT3g5?=
 =?utf-8?B?TGtveWxZenducXBpTHJURW9UbmdkN1hHbm9PaFZOcXY0ZUxPZW53OEhKUldl?=
 =?utf-8?B?NVRaeVIyNFNhTDZJMmpIbkZOMTNLOTZZRGpuQXJsUWZpZ0t1ODE0ZStsa0JI?=
 =?utf-8?B?cFczNWo1eFRseWVuNGRjZUdUenFiTTBVU0lJSWJrOG5DdEF0QjBnZE1uUnpo?=
 =?utf-8?B?d1JieUFSMC9Kdjc5cUs5SVJvWVN0RFVtVkxwa1Y3QWV2T3lXT0hqbTE3Rlpa?=
 =?utf-8?B?RTZ6dkpacHkyWVUrMHFtd2cvRFhhV1VIaGZqVXZmUGxRS0tPWHlzWXVJSy9m?=
 =?utf-8?B?czd4ejhpbHNiRC96VW5vWjJtNGhiMGlBT2llTm9OQ0p4VTlNQy8wMmNTaHlP?=
 =?utf-8?B?YmJlOFhXd1hTRGRWbFNKaU1YQjZ1WFoxOXROaWJBMXZMOWNpZUYwbTZoUmNN?=
 =?utf-8?B?bFkwZ0sxMUZsM0NFTFo1Q1liQ2ZMeHVNOCtPOWRua0JneWRqVGxnVHg2UE8r?=
 =?utf-8?B?VjhDUXNkalZ0b3lBZVo1aEo4Q2hyaTF0LzJ4VVNwNkNkQVNnRngyK3lFaDFp?=
 =?utf-8?B?cDFReExpeGRHSkU1aFdFMERhMUZTNVBUMWdzVDJORkY3VWxjN0FwQzhtUndU?=
 =?utf-8?B?L0pJRkl1N1JDUXdoOHhoWjBDQTlQZ3hSN2N4eGM2S1R3SFE3a1RMQVpncitk?=
 =?utf-8?B?OFhYZmx6RDRXKzdRKzZzOGk1YkFwUXl3a0JXL1RvUTVDZ3o2RFQrVnZOUWJR?=
 =?utf-8?B?YWZpRG9xMVRyZnlYSGp1Uy9tTnN1aldrYnE3djVCb1Uwdmx4REJlOTRXRDhY?=
 =?utf-8?B?YnlvNkVuVWJSRVFMWmhNSFBicU9ra1ZlVkJUOE05WFhIQXdseHd6M1dLZEpQ?=
 =?utf-8?B?MUJxczhvZVVjN3Q4VDYwUnFWbGloZmFjWU03eUtRMnFZTGgxcGNmVzVUZ1JU?=
 =?utf-8?B?d3FzTGlrcEJVb2REby9MWW5JTGRaa3JvNHF4VE5qM2p1eFpaVWxjMnlrWWZk?=
 =?utf-8?B?aGhidnlFNEtsZVJxb01xVmtBVDF4V2NET0FLUnlES0xBdkpTbUpjSGQyKzBa?=
 =?utf-8?B?cW40azBUZHhKM0pSOUdSeDRYakNCSlhjMWl1em5kWUlVeXE1UHlqVENtQjd3?=
 =?utf-8?B?eXJvSk1yM1FFSFJvOXIwaGllTFdWWndhc0tRYzQ5Y1hnZlREYStUR1lwV0R2?=
 =?utf-8?B?KzVtbDBwaFVCenMwMjMyWW9keURDdHpWSnpmZ0plQWZMdEE1dGhnNWpTOWNm?=
 =?utf-8?B?VEJDR0tiWHpRQmh0Tmw2TGVVQm5weDNhdldHV0tCNnNGS0dibnU4MDFNam43?=
 =?utf-8?B?ZCtkT2VyVEdtWUlXYlpWbHU4ZHRmQTl4bS9aYVNObjZhOVJhMmdhTzBNY25h?=
 =?utf-8?B?Z1BMQWlsaXM1L1huV2x0Qk1lY2tUVk5GV2pUS0p5LzJDbUVZcFhzRi9YWTk5?=
 =?utf-8?Q?IakHxRaFL66ivCNsvjXeXkHAC?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ec253260-ca79-451d-74e1-08db9435b4f0
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 15:24:19.4750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: livrpOwKMvT3NdG4i/HwHcIWpFrVaANcpWj7vLWp/iKYLahNaJtPqV5CehkzWK04GoDmE3XNocTHIWLeapFPlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5808
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 8/3/23 06:15, Vinod Koul wrote:
> On 31-07-23, 16:29, Tom Zanussi wrote:
>> To allow idxd sub-drivers to enable and disable wqs, export them.
>>
>> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
>> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
>> ---
>>   drivers/dma/idxd/device.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
>> index 5abbcc61c528..87ad95fa3f98 100644
>> --- a/drivers/dma/idxd/device.c
>> +++ b/drivers/dma/idxd/device.c
>> @@ -1505,6 +1505,7 @@ int drv_enable_wq(struct idxd_wq *wq)
>>   err:
>>   	return rc;
>>   }
>> +EXPORT_SYMBOL_NS_GPL(drv_enable_wq, IDXD);
> 
> Sorry this is a very generic symbol, pls dont export it. I would make it
> idxd_drv_enable_wq()

That's true. Although just a note it's only exported in the IDXD 
namespace. So maybe ok?

> 
>>   
>>   void drv_disable_wq(struct idxd_wq *wq)
>>   {
>> @@ -1526,6 +1527,7 @@ void drv_disable_wq(struct idxd_wq *wq)
>>   	wq->type = IDXD_WQT_NONE;
>>   	wq->client_count = 0;
>>   }
>> +EXPORT_SYMBOL_NS_GPL(drv_disable_wq, IDXD);
>>   
>>   int idxd_device_drv_probe(struct idxd_dev *idxd_dev)
>>   {
>> -- 
>> 2.34.1
>