Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Zeng, Xin" <xin.zeng@intel.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "Wan, Siming" <siming.wan@intel.com>,
        "Pankratov, Svyatoslav" <svyatoslav.pankratov@intel.com>,
        "Zeng, Xin" <xin.zeng@intel.com>
Subject: RE: [RFC 1/5] crypto: qat - add bank save/restore and RP drain
Thread-Topic: [RFC 1/5] crypto: qat - add bank save/restore and RP drain
Thread-Index: AQHZq1V9FF//PigGpEGUWVqBePzt76/Z+HEA
Date:   Fri, 4 Aug 2023 07:51:02 +0000
Message-ID: <BN9PR11MB527649234A93384F1EB11F478C09A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230630131304.64243-1-xin.zeng@intel.com>
 <20230630131304.64243-2-xin.zeng@intel.com>
In-Reply-To: <20230630131304.64243-2-xin.zeng@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PrTWOA9/k2qqW1gxvw0J6QoUo1alr3O0l8tyADeqfugYcb+clVaXk+YdWhR6?=
 =?us-ascii?Q?oJm8HYHvmmx9nWznrMGx7djqurehGXcUNzJtNn4+GjPjnOg7XXxo7pG+esMh?=
 =?us-ascii?Q?ugRXa9TMdPJ51KazJip1JqhPXf+S68wUey3jk4WGGxf49Mu6bVAdAiobNCEE?=
 =?us-ascii?Q?r2Z7KtXv1ymzyyKLMdgrnx9Fbop7l9i1C26U+ABM6Dy1yeZwOlUWrUaaQxNT?=
 =?us-ascii?Q?VsLwCICmPii/lCR4co7KJcqYt8yLmjyMUD7/4yEFzhfw7QOwrosjyijojdh6?=
 =?us-ascii?Q?md2GHEoV28UQsRGJgzVd+4H4iOWWrpYQEH4SzAHYh34aOEmrI27w8NKgRv1E?=
 =?us-ascii?Q?6MRl7ugowHsog71AsOd2Iubbwi0OgT4Am+HX9UIQcyumeC1fl0e7RZt3y8O/?=
 =?us-ascii?Q?wGlD2edw8IBXgk2DcPnYoq4QHfR+Eq9vou1yke8XE8eUnSH6plnvKW/dQl23?=
 =?us-ascii?Q?E6elGIbfbvQEjZaiNSDyr80kJ56hhDcuaamqEt9noBS6/jS4RgBBc1+JGHdl?=
 =?us-ascii?Q?njzqahap25xs8GwCdYjhA3FaqggUERdIbr6U6EpIRfOuhgppaXh/yNfEC22w?=
 =?us-ascii?Q?JZGg7q9VsLgizaZr6PVJBs69unJMcMZqN3fOBW7IxAIjurOveLaMzT4W9tfb?=
 =?us-ascii?Q?TNhD+auYjIeE4kNooRppsnyj5GDjQSgJCGmPxOpk82FujtUamp+LIgxebctW?=
 =?us-ascii?Q?q2S8K5/QpZq/PE/8Ng9ifBq9rjxP6cn/sHIu73wk9EQpaagUkbNGuWNKSIk/?=
 =?us-ascii?Q?6mFbuV8pkn1TSNDaHZdVEref7GkS3JOSyM6r6sLikVBB+8s5ugaA/1nVYAwe?=
 =?us-ascii?Q?sqIOYJfz/NgSluhmRa2o6nX9Th2siISUKgHRCF2who+O6cXI5AbzTX8QCX1r?=
 =?us-ascii?Q?3ek+i9o10Vl8SQhp5Bb0tnuR8iK06XysaVOK6H4AihaK6S+JHNiFdBPW6DH3?=
 =?us-ascii?Q?JS1dxs8QcZs6wQNVXYa327rECWAddi3TfgkcdeJZ8oxnKDjbV5JC2WZtUjsI?=
 =?us-ascii?Q?XNT3JwCakXg7aRdwO9or77H6jYI/sAne+pgQOrjm+ZykCRIEfp2ZnxkJVW1U?=
 =?us-ascii?Q?Ut+IKt6A5GxgsJQTycfz4+jsv1jltlz3ydW4LYVoiUMUIJl0MOLxjr/CPH3f?=
 =?us-ascii?Q?H9PbwvpYv+tspcBVXzb9soNsHJWYg9xohz2itk4z6lFzp+HETfFbuPNdPyz7?=
 =?us-ascii?Q?aQlA44MS6smbxvIjd3Mh8zr8235qW2WPmxHaZ5/MVN7co+JeluHUutIRPntx?=
 =?us-ascii?Q?4+tKbNdI1iAwnjrdbl3dxmpQ6mvENBenxcyfY18/y7XS/FMctpKGk+gv3EoX?=
 =?us-ascii?Q?s3rfnc40SfVKc52c770Ihb0pt4JhUiqnIBh09zaAXLKOc+co5cipWn9J8n4T?=
 =?us-ascii?Q?JKyziU2nE5FfryYx3cPnVvVM8Mb0DSXVjRe7XIFk9A5fgFMk3pa9XTv6lZnM?=
 =?us-ascii?Q?MicETNZUizu4/AxzRQzOT0pHzIJHtiHsdQNX6HKOBetxrg+ZKwtiRVObuV49?=
 =?us-ascii?Q?S8hFYWYSUTg/TwnJ7CEH1uV869QWIjbhVZlnlRdTIajiQRZm9TH/Quo+uSx4?=
 =?us-ascii?Q?D3k4IMMbyDRAT+JwTuXp52GXUOF9wTOlEN/tvI9d?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17ed9b1f-e914-4333-8b25-08db94bf8cc5
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2023 07:51:02.4122
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b5kS8OiBVWVSu8rCx13+t3wCZTmfeD6OGnECANisHWJN3PsWqKOyFMlJ0aIlINulEnQntkvNAY0meIqQgvavnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5178
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> From: Xin Zeng <xin.zeng@intel.com>
> Sent: Friday, June 30, 2023 9:13 PM
> ---
>  .../intel/qat/qat_4xxx/adf_4xxx_hw_data.c     |   5 +-
>  .../intel/qat/qat_c3xxx/adf_c3xxx_hw_data.c   |   2 +-
>  .../qat/qat_c3xxxvf/adf_c3xxxvf_hw_data.c     |   2 +-
>  .../intel/qat/qat_c62x/adf_c62x_hw_data.c     |   2 +-
>  .../intel/qat/qat_c62xvf/adf_c62xvf_hw_data.c |   2 +-
>  .../intel/qat/qat_common/adf_accel_devices.h  |  60 ++-
>  .../intel/qat/qat_common/adf_gen2_hw_data.c   |  17 +-
>  .../intel/qat/qat_common/adf_gen2_hw_data.h   |  10 +-
>  .../intel/qat/qat_common/adf_gen4_hw_data.c   | 362 +++++++++++++++++-
>  .../intel/qat/qat_common/adf_gen4_hw_data.h   | 131 ++++++-
>  .../intel/qat/qat_common/adf_transport.c      |  11 +-
>  .../crypto/intel/qat/qat_common/adf_vf_isr.c  |   2 +-
>  .../qat/qat_dh895xcc/adf_dh895xcc_hw_data.c   |   2 +-
>  .../qat_dh895xccvf/adf_dh895xccvf_hw_data.c   |   2 +-
>  14 files changed, 584 insertions(+), 26 deletions(-)

this could be split into 3 patches.

one is moving from hw_data->csr_ops to hw_data->csr_info. apply to
all qat drivers.

the 2nd is adding new csr_ops.

the last one then covers bank save/restore.

> +
> +#define ADF_RP_INT_SRC_SEL_F_RISE_MASK BIT(2)
> +#define ADF_RP_INT_SRC_SEL_F_FALL_MASK GENMASK(2, 0)
> +static int gen4_bank_state_restore(void __iomem *csr, u32 bank_number,
> +				   struct bank_state *state, u32 num_rings,
> +				   int tx_rx_gap)
> +{

restore is the most tricky part. it's worth of some comments to help
understand the flow, e.g. what is rx/tx layout, why there are multiple
ring tails writes, etc.=20

> +	u32 val, tmp_val, i;
> +
> +	write_csr_ring_srv_arb_en(csr, bank_number, 0);
> +
> +	for (i =3D 0; i < num_rings; i++)
> +		write_csr_ring_base(csr, bank_number, i, state-
> >rings[i].base);
> +
> +	for (i =3D 0; i < num_rings; i++)
> +		write_csr_ring_config(csr, bank_number, i, state-
> >rings[i].config);
> +
> +	for (i =3D 0; i < num_rings / 2; i++) {
> +		int tx =3D i * (tx_rx_gap + 1);
> +		int rx =3D tx + tx_rx_gap;
> +		u32 tx_idx =3D tx / ADF_RINGS_PER_INT_SRCSEL;
> +		u32 rx_idx =3D rx / ADF_RINGS_PER_INT_SRCSEL;
> +
> +		write_csr_ring_head(csr, bank_number, tx, state-
> >rings[tx].head);
> +
> +		write_csr_ring_tail(csr, bank_number, tx, state->rings[tx].tail);
> +
> +		if (state->ringestat & (BIT(tx))) {
> +			val =3D read_csr_int_srcsel(csr, bank_number, tx_idx);
> +			val |=3D (ADF_RP_INT_SRC_SEL_F_RISE_MASK << (8 *
> tx));
> +			write_csr_int_srcsel(csr, bank_number, tx_idx, val);
> +			write_csr_ring_head(csr, bank_number, tx, state-
> >rings[tx].head);
> +		}
> +
> +		write_csr_ring_tail(csr, bank_number, rx, state-
> >rings[rx].tail);
> +
> +		val =3D read_csr_int_srcsel(csr, bank_number, rx_idx);
> +		val |=3D (ADF_RP_INT_SRC_SEL_F_RISE_MASK << (8 * rx));
> +		write_csr_int_srcsel(csr, bank_number, rx_idx, val);
> +
> +		write_csr_ring_head(csr, bank_number, rx, state-
> >rings[rx].head);
> +
> +		val =3D read_csr_int_srcsel(csr, bank_number, rx_idx);
> +		val |=3D (ADF_RP_INT_SRC_SEL_F_FALL_MASK << (8 * rx));
> +		write_csr_int_srcsel(csr, bank_number, rx_idx, val);
> +
> +		if (state->ringfstat & BIT(rx))
> +			write_csr_ring_tail(csr, bank_number, rx, state-
> >rings[rx].tail);
> +	}
> +
> +	write_csr_int_flag_and_col(csr, bank_number, state-
> >iaintflagandcolen);
> +	write_csr_int_en(csr, bank_number, state->iaintflagen);
> +	write_csr_int_col_en(csr, bank_number, state->iaintcolen);
> +	write_csr_int_srcsel(csr, bank_number, 0, state->iaintflagsrcsel0);
> +	write_csr_exp_int_en(csr, bank_number, state->ringexpintenable);
> +	write_csr_int_col_ctl(csr, bank_number, state->iaintcolctl);
> +
> +	/* Check that all ring statuses are restored into a saved state. */
> +	tmp_val =3D read_csr_stat(csr, bank_number);
> +	val =3D state->ringstat0;
> +	if (tmp_val !=3D val) {
> +		pr_err("Fail to restore ringstat register. Expected 0x%x, but
> actual is 0x%x\n",
> +		       tmp_val, val);
> +		return -EINVAL;
> +	}
> +
> +	tmp_val =3D read_csr_e_stat(csr, bank_number);
> +	val =3D state->ringestat;
> +	if (tmp_val !=3D val) {
> +		pr_err("Fail to restore ringestat register. Expected 0x%x, but
> actual is 0x%x\n",
> +		       tmp_val, val);
> +		return -EINVAL;
> +	}
> +
> +	tmp_val =3D read_csr_ne_stat(csr, bank_number);
> +	val =3D state->ringnestat;
> +	if (tmp_val !=3D val) {
> +		pr_err("Fail to restore ringnestat register. Expected 0x%x, but
> actual is 0x%x\n",
> +		       tmp_val, val);
> +		return -EINVAL;
> +	}
> +
> +	tmp_val =3D read_csr_nf_stat(csr, bank_number);
> +	val =3D state->ringnfstat;
> +	if (tmp_val !=3D val) {
> +		pr_err("Fail to restore ringnfstat register. Expected 0x%x, but
> actual is 0x%x\n",
> +		       tmp_val, val);
> +		return -EINVAL;
> +	}
> +
> +	tmp_val =3D read_csr_f_stat(csr, bank_number);
> +	val =3D state->ringfstat;
> +	if (tmp_val !=3D val) {
> +		pr_err("Fail to restore ringfstat register. Expected 0x%x, but
> actual is 0x%x\n",
> +		       tmp_val, val);
> +		return -EINVAL;
> +	}
> +
> +	tmp_val =3D read_csr_c_stat(csr, bank_number);
> +	val =3D state->ringcstat0;
> +	if (tmp_val !=3D val) {
> +		pr_err("Fail to restore ringcstat register. Expected 0x%x, but
> actual is 0x%x\n",
> +		       tmp_val, val);
> +		return -EINVAL;
> +	}
> +
> +	tmp_val =3D read_csr_exp_stat(csr, bank_number);
> +	val =3D state->ringexpstat;
> +	if (tmp_val && !val) {
> +		pr_err("Bank was restored with exception: 0x%x\n", val);
> +		return -EINVAL;
> +	}

above checks could be wrapped in macros.