Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Aug 2023 16:26:21 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Weili Qian <qianweili@huawei.com>
Cc:     linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        liulongfang@huawei.com
Subject: Re: [PATCH 1/7] crypto: hisilicon/qm - obtain the mailbox
 configuration at one time
Message-ID: <ZMy2LQckr/OtS1ZG@gondor.apana.org.au>
References: <20230729125239.25337-1-qianweili@huawei.com>
 <20230729125239.25337-2-qianweili@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230729125239.25337-2-qianweili@huawei.com>
Precedence: bulk

On Sat, Jul 29, 2023 at 08:52:33PM +0800, Weili Qian wrote:
> The mailbox configuration(128 bits) needs to be obtained from the
> hardware at one time. If the mailbox configuration is obtained for
> multiple times, the read value may be incorrect. Use the instruction
> to read mailbox data instead of readl().
> 
> Signed-off-by: Weili Qian <qianweili@huawei.com>

Your patch description makes no sense to me.  Please explain more
clearly why you're replacing generic IO primitives with hand-rolled
assembly.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt