Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Zeng, Xin" <xin.zeng@intel.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "Zeng, Xin" <xin.zeng@intel.com>,
        "Cao, Yahui" <yahui.cao@intel.com>
Subject: RE: [RFC 2/5] crypto: qat - add interface for live migration
Thread-Topic: [RFC 2/5] crypto: qat - add interface for live migration
Thread-Index: AQHZq1V9pdto9yweQEqSLMMZrjB62q/Z+jDQ
Date:   Fri, 4 Aug 2023 07:52:54 +0000
Message-ID: <BN9PR11MB527644B92CE171ABA202E6AE8C09A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230630131304.64243-1-xin.zeng@intel.com>
 <20230630131304.64243-3-xin.zeng@intel.com>
In-Reply-To: <20230630131304.64243-3-xin.zeng@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gxXxHprSvqMcicaUntn26t93TPGy2UbmYcRdxR2VCGh/SYbobToT9T3eOQtf?=
 =?us-ascii?Q?Bd9BD5ccOxvYXq/NzzV3tP+aFZ7gPG3mjH+7JycYhb6plRghEeGs9igtvkbw?=
 =?us-ascii?Q?qayCHKe+ASVOU8eDx4r7sIatPxYzI7suLG1XP4ZVD7PELhFejngRZcIuqV84?=
 =?us-ascii?Q?wWKIl4XRgGCQFlan+BDUafdcQE1k0KuU3GnH/RFljULWAG1kHsJXEczZPstL?=
 =?us-ascii?Q?qhjDazY0oAh+53+AIljg0YH5sbxLDVpxX/vwt4TN4zlxbRX+ZxvFDfQlo6LP?=
 =?us-ascii?Q?YkKNiFO0DQ9p/xwf4Lc6cJPfVxIfIz+oJew06240ZpKnrnW3OroNuF039fzC?=
 =?us-ascii?Q?xJvZBzzKMKTUzi8zEUMLg3LORxIT43zbeA+f3+JM/45aZksPHxjfJ+8LnTHY?=
 =?us-ascii?Q?eJghY+8cvHlraqExDd5MXP23J0H/AnyjzTQvv3ehLaQYdJl/3eF7ktqMGhFA?=
 =?us-ascii?Q?oRxzBRiNDE17mGEG1Wgyp0rWUuAq4lue12oUEbogDHRZWSx3P9SGU7dYQGXf?=
 =?us-ascii?Q?DqShvOMNi80yfezlUjuT68o75CQBw1xBHlS305E+RvYeGnTy8dmyYwGNhhgH?=
 =?us-ascii?Q?Df+GLDdtJ2fTotJzoZCHDmGxKfjhqVRlA6ofBPfuyNzyx07oMjXSXJC1T0Vl?=
 =?us-ascii?Q?ZbFFdTaH9bsc7WtXAPcakj5A5wzRjZ1LBTQwNdBbjhmCDq5kpV1HiP6hO8de?=
 =?us-ascii?Q?uUP/cOiR7f0jTpOj7d4SoH3/LyCOH4cZ0qBY9XI41aktenBut/tK9IJ0yLpa?=
 =?us-ascii?Q?p7uM4ZYEOocZcfoXHeZ7L954IJxXklzUB0AvPR8K5QwgZsjtnvsp35snKUOF?=
 =?us-ascii?Q?Cmka6R3qkcXd7uOwljwrbgz5cRCOHJyceC5XPIdkaP1EQ7uXOg+0H/QN5/bH?=
 =?us-ascii?Q?QTa2npE/39BIWOAYGf5ZU2eiEpj+VIaje5fmt3KNMD2yTK7ZzmZM2LR9PPTq?=
 =?us-ascii?Q?CpuNMlVeu8fnUuyLpieTFbVm+ohHG7yyOZh0Fkq3r5zPb6K+CZUBmN9qd2DJ?=
 =?us-ascii?Q?T1WvODn3u2w8M9yp4RmPLw0rjkT6ljbzoehtxedsVeIPPbqlnzuLt63TQUhn?=
 =?us-ascii?Q?dGtEv5cZAJMxD+YWCx2DHE3phj9E++G0I+NN9RUSVBNmYYnM10VtUe88KBJF?=
 =?us-ascii?Q?TPjA+iO2Uwdye8lHFpEPjua+U+QcuauAMBUhdZZmTrM0TyteV3vWs3hr6p3F?=
 =?us-ascii?Q?OyHce7I5Sge0RzmQWYQUoxl7H0HBnhmDtIXBvHr1wkDfvKbrhNN9pQiPb6la?=
 =?us-ascii?Q?XegDJmD6ZtmWrXZYH077DDdGgTGzpBETfEQAM/0hHGcoxf/G0eycvLD2CJ0Z?=
 =?us-ascii?Q?JjclMveZx0ReFH70mvwSd6hke1pF7NMuuEjw/yXrQzyV4sUZIoUJmy4OIIbj?=
 =?us-ascii?Q?QHFdTyoQPVZ+DVSvVvWmhiWj7dvkcj+nvKI0hVY8xqLoUbQefnrbqf9hU9F6?=
 =?us-ascii?Q?V2xvBUq8Ye3Y9rv5NeZx0bKlZOrrA72lkZbZLvy3aJQ/yGHQMozAS2FWPq5t?=
 =?us-ascii?Q?2QPPgxUaz1vLfvF14P3O/y7TRag603PUhEUfKqE9AbgKjKYRdWIizJWeXRzd?=
 =?us-ascii?Q?2v0g4/zHsPoZQTSqgXeT5WH6liujyYc8c7kUUloN?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57f4f578-7c26-44da-73f3-08db94bfcf54
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2023 07:52:54.0592
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0cgOGfyioBkohhNWhVOoklOzxoL6H4DK7qb5lbkDgONKGW7k5Gf3JtIt96NPVUq/sse7xUw2TMWSHFvS1MjhxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5178
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> From: Xin Zeng <xin.zeng@intel.com>
> Sent: Friday, June 30, 2023 9:13 PM
> +
> +int qat_vfmig_suspend_device(struct pci_dev *pdev, u32 vf_nr)
> +{
> +	struct adf_accel_dev *accel_dev =3D
> adf_devmgr_pci_to_accel_dev(pdev);
> +
> +	if (!accel_dev) {
> +		dev_err(&pdev->dev, "Failed to find accel_dev\n");
> +		return -ENODEV;
> +	}
> +
> +	if (WARN_ON(!GET_VFMIG_OPS(accel_dev)->suspend_device))
> +		return -EINVAL;

this and other warns should be done one-off at device registration point
instead of letting it triggerable by every user ioctl.