Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   meenakshi.aggarwal@nxp.com
To:     horia.geanta@nxp.com, V.sethi@nxp.com, pankaj.gupta@nxp.com,
        gaurav.jain@nxp.com, herbert@gondor.apana.org.au,
        davem@davemloft.net, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Subject: [PATCH] crypto: caam - increase the domain of write memory barrier to full system
Date:   Tue,  8 Aug 2023 12:55:26 +0200
Message-Id: <20230808105527.1707039-2-meenakshi.aggarwal@nxp.com>
In-Reply-To: <20230808105527.1707039-1-meenakshi.aggarwal@nxp.com>
References: <20230808105527.1707039-1-meenakshi.aggarwal@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fNgbRVAMey+0joEdtvaERxtY72ZanYIVlO1fuvDzarZl/CaoZ7m3crVVUXdL?=
 =?us-ascii?Q?T9/3qGemHuMrzfOVKr/PNJdgAh03jDqH6Xk7LIjwnDIA8H1fZDElWaPezmtU?=
 =?us-ascii?Q?CMWY53u8CFqLfHstRXaDWcAJyDqdTy3KohiS/fU+BW0Olf+0I2osphFZ6DKW?=
 =?us-ascii?Q?4m1o8A8sUqTvBacwqt0lAzXQl5RZ2cL0GCC2gli9rIdV9wGlFIytZwwLXoGr?=
 =?us-ascii?Q?GB8Gpt/GfoLqBXEr7Lepm8VEsTw7gcZdGEk+73KrzlZXD32uTR7VyOtyyYeA?=
 =?us-ascii?Q?kOTpM58yPFikm+xViRR/nfXQ0TiPfhSRPP3YVJaPmgzlLQOEUDIcz0YHmloW?=
 =?us-ascii?Q?3mStY2TUZH8U0+tCak80pkiRk83IJ2qKN9Pw8pnRnsHsctD5GShHwFWHuzAm?=
 =?us-ascii?Q?DJ1m9Y25XHDW6ctbN8iE1mxZLylsiT60fgVMIOx/J9E7nFPUjxCB6g1m3rgS?=
 =?us-ascii?Q?r5CMYHGgBTVdk4iaZJiA8sLUNYU8IGyjCGBv6J3NkK0ZuCgpWvC0GTe/uOr+?=
 =?us-ascii?Q?RyTw+oRWqyx1DMrgyCPya1QBH0rPBPoyr5Ro7hvlHYxt0kyr1tQZhNKQ0L7E?=
 =?us-ascii?Q?DBD15/s8HOsVpFBNOYWv4G+q5DDe054LeEHiSKHHsey88+N7WGwvJTAzHiqq?=
 =?us-ascii?Q?1RHefWeT8iu6U6BrlGf/+7IgGykzm+1bjIbG3mvSKh4lAAvyJoRkJfgsLed2?=
 =?us-ascii?Q?PLQSnEEMqyE7ZIAAwnFUV6lPCBrctUdBAmL0vjzFXFutoNHhGdHGrGmYcb4k?=
 =?us-ascii?Q?CVcdngHOUSpm+a158bBFmN4I9scwYqY4ybvZhK0PQepgM1PLQUNjjCwF/P7x?=
 =?us-ascii?Q?fPu20akcyHnv0WENFhe74cAp8ggpSqn8y+C70brzY5IaDBNdVzlSuGVUgRLF?=
 =?us-ascii?Q?Ps0Kbxd3Ws2SXSf44kmqHGYkLf1uGFqJ2AcZLPaUJ4KXc7Zh10RJrlZ3TsL5?=
 =?us-ascii?Q?3u9j1v1Tv1VCigITRDdt0yXmF2lEWya4HyhJFR80Gq1iSF6fxd85vnUPTWC2?=
 =?us-ascii?Q?IJbW6hfVO6puQ9Xt7bxxXF33KrvgEnJwNrE4iAWgiSS6WXv/m1NFd/L7I1y5?=
 =?us-ascii?Q?gh9f0lkAeaX8Ez8ZNzFPv6ebGEUwJemT+ZTKuoc/H7t+6m2g+T1Qwbs/lO42?=
 =?us-ascii?Q?hayjGe5UlZS1gB8wg0zViKYyYyxx/AIJsdiSNfwk3UJwQwPG33VxNag/XKx+?=
 =?us-ascii?Q?8+ZfG4NufQmLDPB0/oqkEJSef276IsA8tMQJGDJ9m39wqirYqg4yYxipeaKl?=
 =?us-ascii?Q?kJ5tSajUaFKPOAlnDmjh7ZqRXPr9C3+S5YLIYZWWCgFF5pXqqPjny3hjiD+E?=
 =?us-ascii?Q?5X7Vh9IsujywvPikK3ykkMt7hWt/UobHTrJZfAXCRHMKkkbltglNuF1cI9BV?=
 =?us-ascii?Q?QmF4RWMCh6Lo1GYMbNdWjc2sVkMfc0fB/fq0NiVS200oVr+ta9RtqDDtuDKi?=
 =?us-ascii?Q?IcVVvVtOoxuynGDEMZjCawVduSWghcEVDeYgyVdFgGT+rjruCUB5vMmc3Nkb?=
 =?us-ascii?Q?Jhmq0vtjXkV52FC8aHUCSchIhk/gzAVzWmETrEPkVqAGQGCvFq+83HBdya/e?=
 =?us-ascii?Q?P4qbj/jyp24pB6Y1NnkUi4EOelXFYRWs4c6pDCFMhHP7BaiH6SSbOrXV36Wg?=
 =?us-ascii?Q?7g=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd421307-2c54-404a-dcb1-08db97fe04d7
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9563.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:55:46.3956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BXRQ7WTFOZ3U3QzdldYZ+NpZMfO/4oru/RuQvTPyoAiqhMMgMK3QFg5yaCHmyC3SW/LcD+zumkv8ESCdOykDvW2+cddp/TUQ2zyNA5n6dNQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8101
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

From: Iuliana Prodan <iuliana.prodan@nxp.com>

In caam_jr_enqueue, under heavy DDR load, smp_wmb() or dma_wmb()
fail to make the input ring be updated before the CAAM starts
reading it. So, CAAM will process, again, an old descriptor address
and will put it in the output ring. This will make caam_jr_dequeue()
to fail, since this old descriptor is not in the software ring.
To fix this, use wmb() which works on the full system instead of
inner/outer shareable domains.

Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
---
 drivers/crypto/caam/jr.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 767fbf052536..5507d5d34a4c 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -464,8 +464,16 @@ int caam_jr_enqueue(struct device *dev, u32 *desc,
 	 * Guarantee that the descriptor's DMA address has been written to
 	 * the next slot in the ring before the write index is updated, since
 	 * other cores may update this index independently.
+	 *
+	 * Under heavy DDR load, smp_wmb() or dma_wmb() fail to make the input
+	 * ring be updated before the CAAM starts reading it. So, CAAM will
+	 * process, again, an old descriptor address and will put it in the
+	 * output ring. This will make caam_jr_dequeue() to fail, since this
+	 * old descriptor is not in the software ring.
+	 * To fix this, use wmb() which works on the full system instead of
+	 * inner/outer shareable domains.
 	 */
-	smp_wmb();
+	wmb();
 
 	jrp->head = (head + 1) & (JOBR_DEPTH - 1);
 
-- 
2.25.1