Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   meenakshi.aggarwal@nxp.com
To:     horia.geanta@nxp.com, V.sethi@nxp.com, pankaj.gupta@nxp.com,
        gaurav.jain@nxp.com, herbert@gondor.apana.org.au,
        davem@davemloft.net, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Subject: [PATCH] crypto: caam: fix unchecked return value error
Date:   Tue,  8 Aug 2023 12:55:25 +0200
Message-Id: <20230808105527.1707039-1-meenakshi.aggarwal@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bCey8oItM4z5Sh5ReMRC0VECbIjfA4Z+bc9jY7mfqXPNc7okkJfY95LbyND6?=
 =?us-ascii?Q?pKUyDpI9Rk8BMia45n24hByP1m+GvZrsZeUToRQ2duIM0KA2hxq+wlP6up/8?=
 =?us-ascii?Q?C+fcUsWlsOpVlnBqqQgAH4XlyNdyJPvje85SX5mOYbvmSQ95ku/c/eHA1CFa?=
 =?us-ascii?Q?4P/yWTxUI60nTSOh0QipbMP1kAhwMy2ze1Js5PRMbW+crDLUsD0plhGQ94ZV?=
 =?us-ascii?Q?BN6BqTz7sYn9+kjxeR9MeHt0BzZpfMn5h3FfUwm80HD/GM3m454bjIGO386c?=
 =?us-ascii?Q?UxnfqfnGjoZRZwAHCutxPHPxjxRpHIgTwYYknex36iYaoJu+FL0NqNzrv475?=
 =?us-ascii?Q?PrpDWfUTSuHl8RPnDvrYNXXVQ3os4ggd+btMsXbCm7Yt6wVRQRlM0QCpMMnM?=
 =?us-ascii?Q?8NFNmfbr9Rcx5UkxYz65LtOiICljXXY4zrRtEBXFT08KpwVfSK7epFWYkZ7z?=
 =?us-ascii?Q?JXQL29N5Z9vEfN81a0yyHz/FBEh9ypYuiq0fF2atCvpGxzD2Xu/t8epyggaI?=
 =?us-ascii?Q?kYMRwKiYrRgoDZGS1VFXTCee1GEg28BZPhVI7dhB66RXMYjAVpgyZ+cxfx0Y?=
 =?us-ascii?Q?StGOfZ2yVwOuODOwbZKrl1QZ1qgz4HFjJf5U0bid5qFGVaKoDuXnB2TLBgMf?=
 =?us-ascii?Q?VCWz1F6GUIQeSNDrBycHz7Jn0XWtPBtY/AOoLF2Gv8JeP8ThSjiMeZvP2rjp?=
 =?us-ascii?Q?413ozfk9CBo+B72pa7DU3D5gwOo0WTY8Ck5mVBHKxCTEiDekpa3tAncuDH0L?=
 =?us-ascii?Q?5VCSIOd5/Xuac/amxsaGCHCe4P5vK6niyG+ryXTA830lm6hcnpF1o6YMRmY1?=
 =?us-ascii?Q?ZoZA6oLV+ITVbj0tuNSxRKBH4Bww2oXpOwUfWhDvOGSerQEAn51p066xl41S?=
 =?us-ascii?Q?JJBpO9pqnqkf0vzAMhMW0gDmRx5euwJYoKvcnKxiIZZ6fb9xI+rk4d0gVYfx?=
 =?us-ascii?Q?aIAH7YK1JsdrD3P56TU7WpWoKxK0H4He8ZVEkpYeK0XpO8P1aaTWJTxZEjZI?=
 =?us-ascii?Q?Q+ZP0FmRQj9WlHNolqSYyIBSlcyIGpvf+U0P0UXK4p2mEe+tDN6Q0vFyBjGc?=
 =?us-ascii?Q?kRHL4XlVyxLdbUCuIprw48pUavZpSNj7dFGsfT5SAldG0BOaNR6eyXW3gDxP?=
 =?us-ascii?Q?7BaEB4GbvlBq9rZ3q4Id/nEUbskatX1kelpsqclCn42okniShhv8sucvbiJR?=
 =?us-ascii?Q?3rj9K68FusC8JTcgBNbOqF5TZw/Od5rSlisVcfsfKO0oVzw5mm7icOqp4Q5p?=
 =?us-ascii?Q?UajIcY9oAXb53M/ErMOcHzufQ+toMSP3vQ1f/J1dSOqtqeqQPx9RgdnXheZS?=
 =?us-ascii?Q?uZYAm2NWDiLTT4pMsTgQUnkZvu7XjBLicG1IIk/D80RgnfW/2nd+Y7aBfLNy?=
 =?us-ascii?Q?omkF2ncIXhc9AV89NNoD8X+GGKkJXXtGPRBFSK7xat0Q0/PYOnwABJCEsIBx?=
 =?us-ascii?Q?sBN6QqPRXQUQ76vCFnrTKzLLenJEafaB+13Sh0EcgFsSp2g25Dbt4EL5vWR6?=
 =?us-ascii?Q?7A7JYYOcy/OXfgjsj3/e5Hp70IXQUscBjGc08lmFqAmqSn8QX4qE+6f/EBES?=
 =?us-ascii?Q?PK1BTbzKEaDRAZqYg3h1B6s0nNWWxByLMP2ZAyrfKyjcwMXLhRR7O3MK1Nt5?=
 =?us-ascii?Q?wg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6171de5a-3049-425e-3157-08db97fe0489
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9563.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:55:45.8715
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bi1+b2BPp3xRMkepDeODwPMhksQwGaA7Bt4DMtcDdpm020XTwMfEdMgdDQT62Ax06cor6j91jg9RRRUBe7hvhSTjOOIAveTKEgU8bOChxT0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8101
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

From: Gaurav Jain <gaurav.jain@nxp.com>

error:
Unchecked return value (CHECKED_RETURN)
check_return: Calling sg_miter_next without checking return value

fix:
added check if(!sg_miter_next)

Fixes: 8a2a0dd35f2e ("crypto: caam - strip input zeros from RSA input buffer")
Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
---
 drivers/crypto/caam/caampkc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c
index 72afc249d42f..7e08af751e4e 100644
--- a/drivers/crypto/caam/caampkc.c
+++ b/drivers/crypto/caam/caampkc.c
@@ -225,7 +225,9 @@ static int caam_rsa_count_leading_zeros(struct scatterlist *sgl,
 		if (len && *buff)
 			break;
 
-		sg_miter_next(&miter);
+		if (!sg_miter_next(&miter))
+			break;
+
 		buff = miter.addr;
 		len = miter.length;
 
-- 
2.25.1