Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Gaurav Jain <gaurav.jain@nxp.com>
To:     Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
        Horia Geanta <horia.geanta@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] crypto: caam: fix unchecked return value error
Thread-Topic: [PATCH] crypto: caam: fix unchecked return value error
Thread-Index: AQHZyebilpxXMyMRNkuEfBm3sxlVsa/pX3eQ
Date:   Mon, 14 Aug 2023 06:36:31 +0000
Message-ID: <AM0PR04MB6004181BD078ABD918D4D008E717A@AM0PR04MB6004.eurprd04.prod.outlook.com>
References: <20230808105527.1707039-1-meenakshi.aggarwal@nxp.com>
In-Reply-To: <20230808105527.1707039-1-meenakshi.aggarwal@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0iJTVFbrMPvgjKcWM3LUpp5GZRuwF8BXM2XDQzm/A5dPF8Dd89EYYVJb0o1Q?=
 =?us-ascii?Q?19pjBn//W8C7DotLzNurDVa+c27OucuXj2cjTRrID58QQ+NrbSxOckCiJ7YN?=
 =?us-ascii?Q?8+r+lBHrTj+c058ZKowkfEXnDNW8K66GyMtmGbwWWWlGDDHB5aCXPVLt0p+U?=
 =?us-ascii?Q?v3HbCp9qF1IvFHAfhToFOX4ffvoTP8yKwpNK2tqPElSSdcTdkBp1SES91mLF?=
 =?us-ascii?Q?q8SDw8WNtQAtAvFAtR4/QTdEpr4O/s7J/JrWeThbOkl7wXe6L28vS/XrVXyT?=
 =?us-ascii?Q?zQfaCsDlqzk+dxHleTaXnZVz9KbBvdNYa20312NKdIyzbAazYF/PMrFyqBaq?=
 =?us-ascii?Q?nsjXlNUk7HN7LMcQLYO13gm+n7t4WH+3j+5lfEKeg1FEi9Os+6tq/+KOFSyV?=
 =?us-ascii?Q?dWh2rgZYDDCz/+y/4BSJhhOgQm/iytx17Uykx5Kheo79LKNR1yJ6ClKX0TAx?=
 =?us-ascii?Q?/tkIqB3am+LJfLK+4wTN4rInFoYBF+REPvrrI8YEr5FwzsK3wsfZpRlejVWw?=
 =?us-ascii?Q?Q/T4SFUhOK2RvAHfFm0Af7lk3EK9W+O/SkynTExEXBVHgjx0vmxmC8n3Prjl?=
 =?us-ascii?Q?TMNythuIqJWQWEUmLBQbySHEeSbO/3/ITfJCtjlIXTnc292S824MSKrtwqIN?=
 =?us-ascii?Q?b+3f843p1iCEgGsMBS+3mqFSwtwFKrMSrLXSgW9diWOD0kHnwVWdWN8k2GUo?=
 =?us-ascii?Q?ntRvKJsM5U4ei1+HZyIIHMwoCmIRXqWKSidqibhwSW1FBw8AqD/zG/suUIs9?=
 =?us-ascii?Q?bRpvwC9Vz36z3DAZw1SU3MWl55Y5W7SRwxh33RZse8JSW6ussJp44dBfRAjY?=
 =?us-ascii?Q?Z/xUKflcGxsru/Ev2AzqCGrpfHy5iByNIngtfO3NMnJmeNzwBeTnGuvmZu3V?=
 =?us-ascii?Q?nBGQqy85oArsZRwMUv2m7LtfflIbUqAKs1Z91BO/usL+gfsmShM7bnqJiTSO?=
 =?us-ascii?Q?TsziPKAVrwS7X+Ue9ZPwn7Ew2d9EGr/5AhphR1os/K1GuEqsABnpHeTXTCC9?=
 =?us-ascii?Q?WZDNctzshqTLZoIT4VwMsFUPVLmspb/5IRGqLDdEOsdahSc9YeySqjFzJyDv?=
 =?us-ascii?Q?SQSThb2kdjv42HAFrJn6gfU7xcoLbOxJeudN3AXYWUg2Ck3BXGsSWUPUqbrD?=
 =?us-ascii?Q?rvMtfex22c3Qo9/OymeGEUicWDbMji4YJorTIzAKKA6uXMEthqfZS8md8mUg?=
 =?us-ascii?Q?//DMAW4WuYnkS0/z05R77lk23qhxpoz9gUKxqJZstkfvGBL0OWboPeNCCCFI?=
 =?us-ascii?Q?B5oxtmVwa0x7PQj5br/Wox1p5qIkciXFY9o6QdhS+Ah7VxwuMNEPNsQdIjSf?=
 =?us-ascii?Q?nMnSmTFpfYAv8KpC6BDH1ml3yiiyoIWVABmxFaG16I2MzR1tKV0KlaDQd76g?=
 =?us-ascii?Q?RnMtesGkigZjCPbhdR+qrshhP1FcsJkG7UZB79qXi+QazqJgoF3XgWNiC3Qk?=
 =?us-ascii?Q?h4jiG15EUhQKjOQYGJvMy9VaFZXmi8c3h8FvXlmvu/+86brUlYpqCLC1UgZX?=
 =?us-ascii?Q?X+jbVsnNZ3AVjf25TN0RFrPET2nkiaJkB4A5ugoPqQtkj4cfI/iX/MgUAZFA?=
 =?us-ascii?Q?X5KAiJ5yibM9VY1a1VAd4uy6DGTJACvgZa+XRNf2?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6004.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e85866f-be15-448a-7a91-08db9c90cbe9
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2023 06:36:31.2753
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2G6nNt9fIFkc5JGQIlAfn5aZ7wfCZINHZl2pIrn8slfcRnHZ4VszQjA5C1QltBrOXRY2S9PmdETh0ltR4DqahA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9566
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Reviewed-by: Gaurav Jain <gaurav.jain@nxp.com>

> -----Original Message-----
> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Sent: Tuesday, August 8, 2023 4:25 PM
> To: Horia Geanta <horia.geanta@nxp.com>; Varun Sethi <V.Sethi@nxp.com>;
> Pankaj Gupta <pankaj.gupta@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>;
> herbert@gondor.apana.org.au; davem@davemloft.net; linux-
> crypto@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Subject: [PATCH] crypto: caam: fix unchecked return value error
>=20
> From: Gaurav Jain <gaurav.jain@nxp.com>
>=20
> error:
> Unchecked return value (CHECKED_RETURN)
> check_return: Calling sg_miter_next without checking return value
>=20
> fix:
> added check if(!sg_miter_next)
>=20
> Fixes: 8a2a0dd35f2e ("crypto: caam - strip input zeros from RSA input buf=
fer")
> Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
>  drivers/crypto/caam/caampkc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.=
c
> index 72afc249d42f..7e08af751e4e 100644
> --- a/drivers/crypto/caam/caampkc.c
> +++ b/drivers/crypto/caam/caampkc.c
> @@ -225,7 +225,9 @@ static int caam_rsa_count_leading_zeros(struct
> scatterlist *sgl,
>  		if (len && *buff)
>  			break;
>=20
> -		sg_miter_next(&miter);
> +		if (!sg_miter_next(&miter))
> +			break;
> +
>  		buff =3D miter.addr;
>  		len =3D miter.length;
>=20
> --
> 2.25.1