Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <57a30a95-b63c-7ad4-070f-db70262b6b7c@kernel.org>
Date:   Fri, 18 Aug 2023 00:03:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.1
Subject: Re: [PATCH 2/4] linux/array_size.h: Add ARRAY_SIZE_OF_FIELD()
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Lucas Segarra Fernandez <lucas.segarra.fernandez@intel.com>,
        herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, qat-linux@intel.com,
        andriy.shevchenko@intel.com,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
        Kees Cook <keescook@chromium.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>
References: <20230817143352.132583-1-lucas.segarra.fernandez@intel.com>
 <20230817143352.132583-3-lucas.segarra.fernandez@intel.com>
 <574d3a14-6b6e-3ad2-2ce3-48c9d76e205c@kernel.org>
 <CAHp75VdZiLbE07h3Ei6OmTNFKJ69ksKMRk1EYOjSCxveR+JFCA@mail.gmail.com>
Content-Language: en-US
From:   Alejandro Colomar <alx@kernel.org>
Organization: Linux
In-Reply-To: <CAHp75VdZiLbE07h3Ei6OmTNFKJ69ksKMRk1EYOjSCxveR+JFCA@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------v1TPGZhYG4YP9d3lZYzONNH9"
Precedence: bulk

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------v1TPGZhYG4YP9d3lZYzONNH9
Content-Type: multipart/mixed; boundary="------------Z1QprukeyGf3CrJaicsPR0CK";
 protected-headers="v1"
From: Alejandro Colomar <alx@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Lucas Segarra Fernandez <lucas.segarra.fernandez@intel.com>,
 herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
 linux-crypto@vger.kernel.org, qat-linux@intel.com,
 andriy.shevchenko@intel.com, Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
 Kees Cook <keescook@chromium.org>,
 "Gustavo A. R. Silva" <gustavoars@kernel.org>
Message-ID: <57a30a95-b63c-7ad4-070f-db70262b6b7c@kernel.org>
Subject: Re: [PATCH 2/4] linux/array_size.h: Add ARRAY_SIZE_OF_FIELD()
References: <20230817143352.132583-1-lucas.segarra.fernandez@intel.com>
 <20230817143352.132583-3-lucas.segarra.fernandez@intel.com>
 <574d3a14-6b6e-3ad2-2ce3-48c9d76e205c@kernel.org>
 <CAHp75VdZiLbE07h3Ei6OmTNFKJ69ksKMRk1EYOjSCxveR+JFCA@mail.gmail.com>
In-Reply-To: <CAHp75VdZiLbE07h3Ei6OmTNFKJ69ksKMRk1EYOjSCxveR+JFCA@mail.gmail.com>

--------------Z1QprukeyGf3CrJaicsPR0CK
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Andy,

On 2023-08-17 23:30, Andy Shevchenko wrote:
> On Thu, Aug 17, 2023 at 11:34=E2=80=AFPM Alejandro Colomar <alx@kernel.=
org> wrote:
>> On 2023-08-17 16:33, Lucas Segarra Fernandez wrote:
>=20
> ...
>=20
>> Some comment about the name:
>>
>> ARRAY_SIZE() is rather ambiguous, as there's array_size()[1], which me=
ans the
>> number of bytes needed to represent the array.  I suggest a name based=
 on
>>
>> -  _Lengthof()  It has been proposed to ISO C to get the number of ele=
ments
>>                 of an array:
>>                 <https://www.open-std.org/jtc1/sc22/wg14/www/docs/n252=
9.pdf>.
>>
>> -  sizeof_field()  The kernel macro for the size of a struct member
>>
>> So, how about lengthof_field()?
>=20
> TBH I do not understand the motivation of making this kind of
> confusion and inconsistency.


> Are you suggesting renaming ARRAY_SIZE()
> to begin with?

No.  ARRAY_SIZE is a very old and known API.  It is array_size() that is
to be blamed, due to having a confusing name.

What I suggest is not reusing the root of the name of ARRAY_SIZE(), which=

since the addition of array_size() may be less unambiguous (IMHO).

So, instead of ARRAY_SIZE_*(), which is derived from ARRAY_SIZE(), maybe
it would be more unambiguous to use the _Lengthof() name as a root, since=

nobody has messed with it so far.

My suggestion is to keep ARRAY_SIZE() with its old name, but use
lengthof_field() for this struct variant of it.  It's also a shorter name=
,
which will make for shorter lines.

b19d57d0f3cc ("overflow.h: Add flex_array_size() helper")
	- (Mon Jun 8 20:22:33 2020 -0500)
610b15c50e86 ("overflow.h: Add allocation size calculation helpers")
	- (Mon May 7 16:47:02 2018 -0700)

Nevertheless, it was just a minor suggestion, and if array_size() was
seen as a good enough name, it wouldn't be as confusing as it seems to
me.  If you find them to be fine, go ahead.

Cheers,
Alex

> If so, it's definitely out of the scope of this series.
>=20

--=20
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5


--------------Z1QprukeyGf3CrJaicsPR0CK--

--------------v1TPGZhYG4YP9d3lZYzONNH9
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmTemR4ACgkQnowa+77/
2zIvHxAAi/nyYuGEWGa4tuQcfHGDBKFkHEIRM+rEWcoXY0mmRFdC3lu0RAQxTCQP
El83M3eXYO5iCHjeh6k0dGFTaIBUwUUj0rrbSYH65MdmwHuR3O6GhE9uijHKjzm3
pBDdunpdeDVEP1Ln7EmP7K/WY5PPcT78iaL1jeveDtpIGDEA8O+N5kuN3TvwusYE
ztXksro67OCUjP8TA7Mp/n1GorMxQFKTF9KYJ/Q7f+o612+PJ9K3God6m0XcAuUo
jUd3CH9BEgg5rZTx+BTT67iqPqzIcJ7trq9F+qIX18lHDD+qyVDLjzzCkxtWE1xC
vXDlUe2KMI1+acrSR8qTUOYiSWQq1zrNrVbS0jwaju2YCzODnTOdyz2g9iJickiS
1NUBhPWJ3zefivmZB/oBQPApMPpcqIQ72bQYveiTzWYVdZrzbU6dL1tQG9CBZJyA
/0zQuTROfioxyKezAW9JqXmkOiDNbQO+MibAj933YMEMnxTWlh/U0VNSY2Tv2cEh
Zuv0E+Bucv7LzTcXP88VhJAaj733OaizKkanT/YGC5rn6FxN5njHHxY6flhb+bMc
DjfJfxFh5Ft4M7EJGAfZrmg/n9dNAt5AKtAfM/g1Z5sV/1/bZWf4NsCVP/krX7ge
LOrnqHiupIfx2i8CB2nIWrsy1TIL840Iv0eSbkKnRbTq0BJfCSc=
=22fs
-----END PGP SIGNATURE-----

--------------v1TPGZhYG4YP9d3lZYzONNH9--