Received: by 2002:a05:7412:bc1a:b0:d7:7d3a:4fe2 with SMTP id ki26csp879112rdb; Sun, 20 Aug 2023 07:02:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjhKhED+h6fGSiQWQr+hj0e1cRhQgc0E4zpydy3XqOvypYKHGhfmAZCmkD28yW0N82k1/0 X-Received: by 2002:a9d:7dc4:0:b0:6b8:807b:b50 with SMTP id k4-20020a9d7dc4000000b006b8807b0b50mr5292225otn.22.1692540157124; Sun, 20 Aug 2023 07:02:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692540157; cv=none; d=google.com; s=arc-20160816; b=AcHo+KXDZrwjJeN2OCGdd+VAiCVQkbypF4nAFPQaso7bWjxvirwDsawK4+eF3S1CLi mdkB9No3ieFlGEWXM3aI4mSWahI6RnN4rhnLKQfC4AznA85y7Xy7fzu3rAiwMMvlYIOQ kiMTOuj+v3/hmkypObB2dqrvHTgufqNrdkXvYa0NH+OYr3L/Ns47Mr5N9Z5StLEGjRlZ PgvCyGMmEF1tSn437xJt41KZPfPaQnGRSn3de+irYfCpzdYCONpXv3f1FkGdpV3lb6Wo AzIsnU9mes9u78RN+qCB/qQ8QP9DlJtgrJ/t4ayY7QSOt/PAd5MyqECOub+UxRfVjSyI kNCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=+tgirxGsnEzFqvQyVRK6OSLC5JSYHAUI6bz6J3mG2/8=; fh=Yhalc/4dTMF5R7lsf5z09D70B1iuJrBjN3L9DySlGIw=; b=J+jgjN12pFqb1l6znM2VKmIwpE0NUkf6cJ/ef6vJtPG99/DhcAKQ9zlM/wetlRGEWH /FeKP3mI9dMJGdc6Oe/3BddZRS9IxdxL16kEPcCrkXk3hn33dBgFxyWIU+g0iCgWzkPp GYGWHQtq9h/IQkcj8qQYyIpHdvi/WYfGeETFsBKkaay6Bhx9rSWQxevEWqL9EqCXKFT4 VT9Dbl6+Kq4sLMlYsNZ+pV/aG/SKabih4G0k3gsbv04x4RtFzDXO3hrqAH3c3vkSCxL2 2SHXE9M55/WPe4oTikADyjZehtluj8xHCVpKj5lyekrgjUkrQyqp3MiCNZAmUUJN73K3 0W/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b69-20020a633448000000b0056532a83c64si5076767pga.516.2023.08.20.07.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 07:02:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 63BDF35D795; Sat, 19 Aug 2023 12:07:16 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359104AbjHRJad (ORCPT + 99 others); Fri, 18 Aug 2023 05:30:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359173AbjHRJa1 (ORCPT ); Fri, 18 Aug 2023 05:30:27 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8DB930E6; Fri, 18 Aug 2023 02:30:24 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qWvo6-005FRg-Ot; Fri, 18 Aug 2023 17:30:15 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 18 Aug 2023 17:30:15 +0800 Date: Fri, 18 Aug 2023 17:30:15 +0800 From: Herbert Xu To: meenakshi.aggarwal@nxp.com Cc: horia.geanta@nxp.com, V.sethi@nxp.com, pankaj.gupta@nxp.com, gaurav.jain@nxp.com, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: caam: fix unchecked return value error Message-ID: References: <20230808105527.1707039-1-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808105527.1707039-1-meenakshi.aggarwal@nxp.com> X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_00,HELO_DYNAMIC_IPADDR2, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_BLOCKED,RDNS_DYNAMIC,SPF_HELO_NONE, SPF_PASS,TVD_RCVD_IP,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Aug 08, 2023 at 12:55:25PM +0200, meenakshi.aggarwal@nxp.com wrote: > From: Gaurav Jain > > error: > Unchecked return value (CHECKED_RETURN) > check_return: Calling sg_miter_next without checking return value > > fix: > added check if(!sg_miter_next) > > Fixes: 8a2a0dd35f2e ("crypto: caam - strip input zeros from RSA input buffer") > Signed-off-by: Gaurav Jain > Signed-off-by: Meenakshi Aggarwal > --- > drivers/crypto/caam/caampkc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt